drm/i915: modeset probe/remove cleanup

Submitted by Jani Nikula on Oct. 7, 2019, 3:09 p.m.

Details

Reviewer None
Submitted Oct. 7, 2019, 3:09 p.m.
Last Updated Oct. 7, 2019, 4:30 p.m.
Revision 1

Cover Letter(s)

Revision 1
      Another attempt at trying to cleanup the probe/remove wrt
display. TL;DR: It's a mess.

I'm trying to chop up the intel_modeset_*() functions in intel_display.c
to smaller pieces, and eventually remove the extra
i915_driver_modeset_*() layer from i915_drv.c.

The intermediate steps aren't the prettiest. The error paths in
particular are hideous. (Not that they are great now.)

But I'm trying to probe (eh) if this would be a workable direction.

BR,
Jani.


Jani Nikula (11):
  drm/i915: register vga switcheroo later, unregister earlier
  drm/i915: switch i915_driver_probe() to use i915 local variable
  drm/i915: keep power domains init/remove calls at the same level
  drm/i915: split intel_modeset_driver_remove() to pre/post irq
    uninstall
  drm/i915: split i915_driver_modeset_remove() to pre/post irq uninstall
  drm/i915: split i915_driver_modeset_probe() to pre/post irq install
  drm/i915: split intel_modeset_init() to pre/post irq install
  drm/i915: split intel_modeset_init() pre/post gem init
  drm/i915: move more display related probe/remove stuff to display
  drm/i915: move modeset probe failures down to intel_display.c
  drm/i915: remove the now redundant i915_driver_modeset_* call layer

 drivers/gpu/drm/i915/display/intel_display.c |  82 +++++++--
 drivers/gpu/drm/i915/display/intel_display.h |   3 +
 drivers/gpu/drm/i915/i915_drv.c              | 183 +++++++------------
 3 files changed, 141 insertions(+), 127 deletions(-)
    

Revisions

Patches download mbox

Tests

CI Bug Log - changes from CI_DRM_7024 -> Patchwork_14691
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_14691 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_14691, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_14691:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_module_load@reload-with-fault-injection:
    - fi-cfl-guc:         [PASS][1] -> [INCOMPLETE][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-cfl-guc/igt@i915_module_load@reload-with-fault-injection.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-cfl-guc/igt@i915_module_load@reload-with-fault-injection.html
    - fi-skl-guc:         [PASS][3] -> [INCOMPLETE][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-skl-guc/igt@i915_module_load@reload-with-fault-injection.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-skl-guc/igt@i915_module_load@reload-with-fault-injection.html
    - fi-cfl-8700k:       [PASS][5] -> [INCOMPLETE][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-cfl-8700k/igt@i915_module_load@reload-with-fault-injection.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-cfl-8700k/igt@i915_module_load@reload-with-fault-injection.html
    - fi-skl-6700k2:      [PASS][7] -> [INCOMPLETE][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-skl-6700k2/igt@i915_module_load@reload-with-fault-injection.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-skl-6700k2/igt@i915_module_load@reload-with-fault-injection.html
    - fi-blb-e6850:       [PASS][9] -> [INCOMPLETE][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-blb-e6850/igt@i915_module_load@reload-with-fault-injection.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-blb-e6850/igt@i915_module_load@reload-with-fault-injection.html
    - fi-bwr-2160:        [PASS][11] -> [INCOMPLETE][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-bwr-2160/igt@i915_module_load@reload-with-fault-injection.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-bwr-2160/igt@i915_module_load@reload-with-fault-injection.html
    - fi-kbl-guc:         [PASS][13] -> [INCOMPLETE][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-kbl-guc/igt@i915_module_load@reload-with-fault-injection.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-kbl-guc/igt@i915_module_load@reload-with-fault-injection.html
    - fi-cfl-8109u:       [PASS][15] -> [INCOMPLETE][16]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-cfl-8109u/igt@i915_module_load@reload-with-fault-injection.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-cfl-8109u/igt@i915_module_load@reload-with-fault-injection.html
    - fi-skl-lmem:        [PASS][17] -> [INCOMPLETE][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-skl-lmem/igt@i915_module_load@reload-with-fault-injection.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-skl-lmem/igt@i915_module_load@reload-with-fault-injection.html
    - fi-kbl-r:           [PASS][19] -> [INCOMPLETE][20]
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-kbl-r/igt@i915_module_load@reload-with-fault-injection.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-kbl-r/igt@i915_module_load@reload-with-fault-injection.html
    - fi-skl-6260u:       [PASS][21] -> [INCOMPLETE][22]
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-skl-6260u/igt@i915_module_load@reload-with-fault-injection.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-skl-6260u/igt@i915_module_load@reload-with-fault-injection.html
    - fi-hsw-4770:        [PASS][23] -> [INCOMPLETE][24]
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-hsw-4770/igt@i915_module_load@reload-with-fault-injection.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-hsw-4770/igt@i915_module_load@reload-with-fault-injection.html
    - fi-whl-u:           [PASS][25] -> [INCOMPLETE][26]
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-whl-u/igt@i915_module_load@reload-with-fault-injection.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-whl-u/igt@i915_module_load@reload-with-fault-injection.html
    - fi-ilk-650:         [PASS][27] -> [INCOMPLETE][28]
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-ilk-650/igt@i915_module_load@reload-with-fault-injection.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-ilk-650/igt@i915_module_load@reload-with-fault-injection.html
    - fi-ivb-3770:        [PASS][29] -> [INCOMPLETE][30]
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-ivb-3770/igt@i915_module_load@reload-with-fault-injection.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-ivb-3770/igt@i915_module_load@reload-with-fault-injection.html
    - fi-hsw-peppy:       [PASS][31] -> [INCOMPLETE][32]
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-hsw-peppy/igt@i915_module_load@reload-with-fault-injection.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-hsw-peppy/igt@i915_module_load@reload-with-fault-injection.html
    - fi-hsw-4770r:       [PASS][33] -> [INCOMPLETE][34]
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-hsw-4770r/igt@i915_module_load@reload-with-fault-injection.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-hsw-4770r/igt@i915_module_load@reload-with-fault-injection.html
    - fi-kbl-x1275:       [PASS][35] -> [INCOMPLETE][36]
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-kbl-x1275/igt@i915_module_load@reload-with-fault-injection.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-kbl-x1275/igt@i915_module_load@reload-with-fault-injection.html
    - fi-kbl-7500u:       [PASS][37] -> [INCOMPLETE][38]
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-kbl-7500u/igt@i915_module_load@reload-with-fault-injection.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-kbl-7500u/igt@i915_module_load@reload-with-fault-injection.html
    - fi-bdw-5557u:       [PASS][39] -> [INCOMPLETE][40]
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-bdw-5557u/igt@i915_module_load@reload-with-fault-injection.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-bdw-5557u/igt@i915_module_load@reload-with-fault-injection.html

  * igt@runner@aborted:
    - fi-ilk-650:         NOTRUN -> [FAIL][41]
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-ilk-650/igt@runner@aborted.html
    - fi-cfl-8109u:       NOTRUN -> [FAIL][42]
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-cfl-8109u/igt@runner@aborted.html
    - fi-whl-u:           NOTRUN -> [FAIL][43]
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-whl-u/igt@runner@aborted.html
    - fi-cfl-guc:         NOTRUN -> [FAIL][44]
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-cfl-guc/igt@runner@aborted.html
    - fi-bsw-n3050:       NOTRUN -> [FAIL][45]
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-bsw-n3050/igt@runner@aborted.html
    - fi-bsw-kefka:       NOTRUN -> [FAIL][46]
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-bsw-kefka/igt@runner@aborted.html
    - fi-cfl-8700k:       NOTRUN -> [FAIL][47]
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-cfl-8700k/igt@runner@aborted.html

  
#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@i915_module_load@reload-with-fault-injection:
    - {fi-tgl-u}:         [PASS][48] -> [INCOMPLETE][49]
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-tgl-u/igt@i915_module_load@reload-with-fault-injection.html
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-tgl-u/igt@i915_module_load@reload-with-fault-injection.html
    - {fi-kbl-soraka}:    [PASS][50] -> [INCOMPLETE][51]
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-kbl-soraka/igt@i915_module_load@reload-with-fault-injection.html
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-kbl-soraka/igt@i915_module_load@reload-with-fault-injection.html

  * igt@runner@aborted:
    - {fi-tgl-u}:         NOTRUN -> [FAIL][52]
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-tgl-u/igt@runner@aborted.html

  
Known issues
------------

  Here are the changes found in Patchwork_14691 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_flink_basic@flink-lifetime:
    - fi-icl-u3:          [PASS][53] -> [DMESG-WARN][54] ([fdo#107724])
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-icl-u3/igt@gem_flink_basic@flink-lifetime.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-icl-u3/igt@gem_flink_basic@flink-lifetime.html

  * igt@i915_module_load@reload-with-fault-injection:
    - fi-kbl-8809g:       [PASS][55] -> [INCOMPLETE][56] ([fdo#103665])
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-kbl-8809g/igt@i915_module_load@reload-with-fault-injection.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-kbl-8809g/igt@i915_module_load@reload-with-fault-injection.html
    - fi-byt-j1900:       [PASS][57] -> [INCOMPLETE][58] ([fdo#102657])
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-byt-j1900/igt@i915_module_load@reload-with-fault-injection.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-byt-j1900/igt@i915_module_load@reload-with-fault-injection.html
    - fi-elk-e7500:       [PASS][59] -> [INCOMPLETE][60] ([fdo#103989])
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-elk-e7500/igt@i915_module_load@reload-with-fault-injection.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-elk-e7500/igt@i915_module_load@reload-with-fault-injection.html
    - fi-apl-guc:         [PASS][61] -> [INCOMPLETE][62] ([fdo#103927])
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-apl-guc/igt@i915_module_load@reload-with-fault-injection.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-apl-guc/igt@i915_module_load@reload-with-fault-injection.html
    - fi-bsw-kefka:       [PASS][63] -> [INCOMPLETE][64] ([fdo#105876])
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-bsw-kefka/igt@i915_module_load@reload-with-fault-injection.html
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-bsw-kefka/igt@i915_module_load@reload-with-fault-injection.html
    - fi-skl-6600u:       [PASS][65] -> [INCOMPLETE][66] ([fdo#104108])
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-skl-6600u/igt@i915_module_load@reload-with-fault-injection.html
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-skl-6600u/igt@i915_module_load@reload-with-fault-injection.html
    - fi-pnv-d510:        [PASS][67] -> [INCOMPLETE][68] ([fdo#110740])
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-pnv-d510/igt@i915_module_load@reload-with-fault-injection.html
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-pnv-d510/igt@i915_module_load@reload-with-fault-injection.html
    - fi-gdg-551:         [PASS][69] -> [INCOMPLETE][70] ([fdo#108316])
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-gdg-551/igt@i915_module_load@reload-with-fault-injection.html
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-gdg-551/igt@i915_module_load@reload-with-fault-injection.html
    - fi-byt-n2820:       [PASS][71] -> [INCOMPLETE][72] ([fdo#102657])
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-byt-n2820/igt@i915_module_load@reload-with-fault-injection.html
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-byt-n2820/igt@i915_module_load@reload-with-fault-injection.html
    - fi-cml-u2:          [PASS][73] -> [INCOMPLETE][74] ([fdo#110566])
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-cml-u2/igt@i915_module_load@reload-with-fault-injection.html
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-cml-u2/igt@i915_module_load@reload-with-fault-injection.html
    - fi-bxt-dsi:         [PASS][75] -> [INCOMPLETE][76] ([fdo#103927])
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-bxt-dsi/igt@i915_module_load@reload-with-fault-injection.html
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-bxt-dsi/igt@i915_module_load@reload-with-fault-injection.html
    - fi-snb-2600:        [PASS][77] -> [INCOMPLETE][78] ([fdo#105411])
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-snb-2600/igt@i915_module_load@reload-with-fault-injection.html
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-snb-2600/igt@i915_module_load@reload-with-fault-injection.html
    - fi-icl-u3:          [PASS][79] -> [INCOMPLETE][80] ([fdo#107713])
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-icl-u3/igt@i915_module_load@reload-with-fault-injection.html
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-icl-u3/igt@i915_module_load@reload-with-fault-injection.html
    - fi-bsw-n3050:       [PASS][81] -> [INCOMPLETE][82] ([fdo#105876])
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-bsw-n3050/igt@i915_module_load@reload-with-fault-injection.html
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-bsw-n3050/igt@i915_module_load@reload-with-fault-injection.html
    - fi-skl-iommu:       [PASS][83] -> [INCOMPLETE][84] ([fdo#104108])
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-skl-iommu/igt@i915_module_load@reload-with-fault-injection.html
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-skl-iommu/igt@i915_module_load@reload-with-fault-injection.html
    - fi-glk-dsi:         [PASS][85] -> [INCOMPLETE][86] ([fdo#103359] / [k.org#198133])
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-glk-dsi/igt@i915_module_load@reload-with-fault-injection.html
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-glk-dsi/igt@i915_module_load@reload-with-fault-injection.html
    - fi-snb-2520m:       [PASS][87] -> [INCOMPLETE][88] ([fdo#105411])
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-snb-2520m/igt@i915_module_load@reload-with-fault-injection.html
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-snb-2520m/igt@i915_module_load@reload-with-fault-injection.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       [PASS][89] -> [FAIL][90] ([fdo#111407])
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html

  
#### Possible fixes ####

  * igt@gem_mmap_gtt@basic-write-gtt:
    - fi-icl-u3:          [DMESG-WARN][91] ([fdo#107724]) -> [PASS][92] +1 similar issue
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-icl-u3/igt@gem_mmap_gtt@basic-write-gtt.html
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-icl-u3/igt@gem_mmap_gtt@basic-write-gtt.html

  * igt@kms_chamelium@dp-edid-read:
    - fi-kbl-7500u:       [WARN][93] ([fdo#109483]) -> [PASS][94]
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-kbl-7500u/igt@kms_chamelium@dp-edid-read.html
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-kbl-7500u/igt@kms_chamelium@dp-edid-read.html

  
#### Warnings ####

  * igt@i915_module_load@reload-with-fault-injection:
    - fi-icl-u2:          [DMESG-WARN][95] ([fdo#110595]) -> [INCOMPLETE][96] ([fdo#107713])
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7024/fi-icl-u2/igt@i915_module_load@reload-with-fault-injection.html
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14691/fi-icl-u2/igt@i915_module_load@reload-with-fault-injection.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#102657]: https://bugs.freedesktop.org/show_bug.cgi?id=102657
  [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#103989]: https://bugs.freedesktop.org/show_bug.cgi?id=103989
  [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
  [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
  [fdo#105876]: https://bugs.freedesktop.org/show_bug.cgi?id=105876
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
  [fdo#108316]: https://bugs.freedesktop.org/show_bug.cgi?id=108316
  [fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483
  [fdo#110566]: https://bugs.freedesktop.org/show_bug.cgi?id=110566
  [fdo#110595]: https://bugs.freedesktop.org/show_bug.cgi?id=110595
  [fdo#110740]: https://bugs.freedesktop.org/show_bug.cgi?id=110740
  [fdo#111381]: https://bugs.freedesktop.org/show_bug.cgi?id=111381
  [fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
  [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133


Participating hosts (52 -> 45)
------------------------------

  Missing    (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_7024 -> Patchwork_14691

  CI-20190529: 20190529
  CI_DRM_7024: b149aba92ace27b28e068c2541270653c23bca75 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5215: 880c8d3c9831349a269ac6822c8d44e80807089f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_14691: 5d53e56521e87c9f2b703626457847035c1aba91 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

5d53e56521e8 drm/i915: remove the now redundant i915_driver_modeset_* call layer
499509716c59 drm/i915: move modeset probe failures down to intel_display.c
528fb2a4b001 drm/i915: move more display related probe/remove stuff to display
69c89a6bb40d drm/i915: split intel_modeset_init() pre/post gem init
6d6664633090 drm/i915: split intel_modeset_init() to pre/post irq install
e83d085ced9a drm/i915: split i915_driver_modeset_probe() to pre/post irq install
5032d68c656d drm/i915: split i915_driver_modeset_remove() to pre/post irq uninstall
247360baa07e drm/i915: split intel_modeset_driver_remove() to pre/post irq uninstall
2a73bb27fbc4 drm/i915: keep power domains init/remove calls at the same level
4cea63d24b5c drm/i915: switch i915_driver_probe() to use i915 local variable
4f485ace7f46 drm/i915: register vga switcheroo later, unregister earlier
$ dim checkpatch origin/drm-tip
4f485ace7f46 drm/i915: register vga switcheroo later, unregister earlier
4cea63d24b5c drm/i915: switch i915_driver_probe() to use i915 local variable
2a73bb27fbc4 drm/i915: keep power domains init/remove calls at the same level
247360baa07e drm/i915: split intel_modeset_driver_remove() to pre/post irq uninstall
5032d68c656d drm/i915: split i915_driver_modeset_remove() to pre/post irq uninstall
e83d085ced9a drm/i915: split i915_driver_modeset_probe() to pre/post irq install
6d6664633090 drm/i915: split intel_modeset_init() to pre/post irq install
69c89a6bb40d drm/i915: split intel_modeset_init() pre/post gem init
528fb2a4b001 drm/i915: move more display related probe/remove stuff to display
499509716c59 drm/i915: move modeset probe failures down to intel_display.c
5d53e56521e8 drm/i915: remove the now redundant i915_driver_modeset_* call layer
-:91: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#91: FILE: drivers/gpu/drm/i915/i915_drv.c:1426:
+	 * working irqs for e.g. gmbus and dp aux transfers. */

total: 0 errors, 1 warnings, 0 checks, 111 lines checked
$ dim sparse origin/drm-tip
Sparse version: v0.6.0
Commit: drm/i915: register vga switcheroo later, unregister earlier
Okay!

Commit: drm/i915: switch i915_driver_probe() to use i915 local variable
Okay!

Commit: drm/i915: keep power domains init/remove calls at the same level
Okay!

Commit: drm/i915: split intel_modeset_driver_remove() to pre/post irq uninstall
Okay!

Commit: drm/i915: split i915_driver_modeset_remove() to pre/post irq uninstall
Okay!

Commit: drm/i915: split i915_driver_modeset_probe() to pre/post irq install
Okay!

Commit: drm/i915: split intel_modeset_init() to pre/post irq install
Okay!

Commit: drm/i915: split intel_modeset_init() pre/post gem init
Okay!

Commit: drm/i915: move more display related probe/remove stuff to display
Okay!

Commit: drm/i915: move modeset probe failures down to intel_display.c
Okay!

Commit: drm/i915: remove the now redundant i915_driver_modeset_* call layer
Okay!