Follow ups for CD emulation patch series

Submitted by Frediano Ziglio on July 30, 2019, 12:02 p.m.

Details

Reviewer None
Submitted July 30, 2019, 12:02 p.m.
Last Updated July 30, 2019, 12:04 p.m.
Revision

Cover Letter(s)

Revision 1
      Wrote some follow ups for CD emulation series.
Some are just style updates (spacing and indentations), some
minor comments, some interface improvements, some small fixes.
Beside that series is not far from the original sent one week
ago.
Added some minor patches for the CI to help catching some
issues (some fixed in this series).

Frediano Ziglio (36):
  fixup! usb-redir: define interfaces to support emulated devices
  fixup! usb-redir: define interfaces to support emulated devices
  fixup! usb-redir: define interfaces to support emulated devices
  fixup! usb-redir: define interfaces to support emulated devices
  fixup! usb-redir: define interfaces to support emulated devices
  fixup! usb-redir: define interfaces to support emulated devices
  fixup! usb-redir: define interfaces to support emulated devices
  fixup! usb-redir: define interfaces to support emulated devices
  fixup! usb-redir: define interfaces to support emulated devices
  fixup! usb-redir: define interfaces to support emulated devices
  fixup! usb-redir: extend USB backend to support emulated devices
  fixup! usb-redir: add files for SCSI and USB MSC implementation
  fixup! usb-redir: add files for SCSI and USB MSC implementation
  fixup! usb-redir: add files for SCSI and USB MSC implementation
  fixup! usb-redir: add files for SCSI and USB MSC implementation
  fixup! usb-redir: add files for SCSI and USB MSC implementation
  fixup! usb-redir: add files for SCSI and USB MSC implementation
  fixup! usb-redir: add files for SCSI and USB MSC implementation
  fixup! usb-redir: add files for SCSI and USB MSC implementation
  fixup! usb-redir: add files for SCSI and USB MSC implementation
  fixup! usb-redir: add files for SCSI and USB MSC implementation
  fixup! usb-redir: add files for SCSI and USB MSC implementation
  fixup! usb-redir: add files for SCSI and USB MSC implementation
  fixup! usb-redir: add implementation of emulated CD device
  fixup! usb-redir: add implementation of emulated CD device
  fixup! usb-redir: add implementation of emulated CD device
  fixup! usb-redir: add implementation of emulated CD device
  fixup! usb-redir: add implementation of emulated CD device
  fixup! usb-redir: add implementation of emulated CD device
  fixup! usb-redir: add implementation of emulated CD device
  fixup! usb-redir: add implementation of emulated CD device
  fixup! usb-redir: add implementation of emulated CD device
  CI: Add --werror
  CI: Add usbredir packages to Windows

Yuri Benditovich (8):
  usb-redir: define interfaces to support emulated devices
  usb-redir: device error signal without device object
  usb-redir: do not use spice_usb_acl_helper for emulated devices
  usb-redir: extend USB backend to support emulated devices
  usb-redir: add files for SCSI and USB MSC implementation
  usb-redir: add implementation of emulated CD device
  usb-redir: enable redirection of emulated CD drive
  usb-redir: Prepare for creation of emulated CD drive

 .gitlab-ci.yml           |   11 +-
 src/cd-scsi-dev-params.h |   49 +
 src/cd-scsi.c            | 2758 ++++++++++++++++++++++++++++++++++++++
 src/cd-scsi.h            |  121 ++
 src/cd-usb-bulk-msd.c    |  546 ++++++++
 src/cd-usb-bulk-msd.h    |  134 ++
 src/channel-usbredir.c   |   31 +-
 src/meson.build          |   16 +
 src/scsi-constants.h     |  324 +++++
 src/spice-option.c       |   15 +
 src/usb-backend.c        |  745 +++++++++-
 src/usb-backend.h        |    5 +-
 src/usb-device-cd.c      |  788 +++++++++++
 src/usb-device-cd.h      |   37 +
 src/usb-device-manager.c |   74 +-
 src/usb-emulation.h      |   91 ++
 16 files changed, 5670 insertions(+), 75 deletions(-)
 create mode 100644 src/cd-scsi-dev-params.h
 create mode 100644 src/cd-scsi.c
 create mode 100644 src/cd-scsi.h
 create mode 100644 src/cd-usb-bulk-msd.c
 create mode 100644 src/cd-usb-bulk-msd.h
 create mode 100644 src/scsi-constants.h
 create mode 100644 src/usb-device-cd.c
 create mode 100644 src/usb-device-cd.h
 create mode 100644 src/usb-emulation.h
    

Revisions

SERIES REVISION IS NOT COMPLETE. We've got 42 out of 44 expected patches.

Patches download mbox

# Name Submitter State A F R T
[spice-gtk,01/44] usb-redir: define interfaces to support emulated devices Frediano Ziglio Superseded
[spice-gtk,02/44] fixup! usb-redir: define interfaces to support emulated devices Frediano Ziglio Superseded
[spice-gtk,03/44] fixup! usb-redir: define interfaces to support emulated devices Frediano Ziglio Superseded
[spice-gtk,04/44] fixup! usb-redir: define interfaces to support emulated devices Frediano Ziglio Superseded
[spice-gtk,05/44] fixup! usb-redir: define interfaces to support emulated devices Frediano Ziglio Superseded
[spice-gtk,06/44] fixup! usb-redir: define interfaces to support emulated devices Frediano Ziglio Superseded
[spice-gtk,07/44] fixup! usb-redir: define interfaces to support emulated devices Frediano Ziglio Superseded
[spice-gtk,08/44] fixup! usb-redir: define interfaces to support emulated devices Frediano Ziglio Superseded
[spice-gtk,09/44] fixup! usb-redir: define interfaces to support emulated devices Frediano Ziglio Superseded
[spice-gtk,10/44] fixup! usb-redir: define interfaces to support emulated devices Frediano Ziglio Superseded
[spice-gtk,11/44] fixup! usb-redir: define interfaces to support emulated devices Frediano Ziglio Superseded
[spice-gtk,12/44] usb-redir: device error signal without device object Frediano Ziglio Superseded
[spice-gtk,13/44] usb-redir: do not use spice_usb_acl_helper for emulated devices Frediano Ziglio Accepted
[spice-gtk,14/44] usb-redir: extend USB backend to support emulated devices Frediano Ziglio Superseded
[spice-gtk,15/44] fixup! usb-redir: extend USB backend to support emulated devices Frediano Ziglio Superseded
[spice-gtk,16/44] usb-redir: add files for SCSI and USB MSC implementation Frediano Ziglio Superseded
[spice-gtk,18/44] fixup! usb-redir: add files for SCSI and USB MSC implementation Frediano Ziglio Superseded
[spice-gtk,19/44] fixup! usb-redir: add files for SCSI and USB MSC implementation Frediano Ziglio Superseded
[spice-gtk,20/44] fixup! usb-redir: add files for SCSI and USB MSC implementation Frediano Ziglio Superseded
[spice-gtk,21/44] fixup! usb-redir: add files for SCSI and USB MSC implementation Frediano Ziglio Superseded
[spice-gtk,22/44] fixup! usb-redir: add files for SCSI and USB MSC implementation Frediano Ziglio Superseded
[spice-gtk,23/44] fixup! usb-redir: add files for SCSI and USB MSC implementation Frediano Ziglio Superseded
[spice-gtk,24/44] fixup! usb-redir: add files for SCSI and USB MSC implementation Frediano Ziglio Superseded
[spice-gtk,25/44] fixup! usb-redir: add files for SCSI and USB MSC implementation Frediano Ziglio Superseded
[spice-gtk,26/44] fixup! usb-redir: add files for SCSI and USB MSC implementation Frediano Ziglio Superseded
[spice-gtk,27/44] fixup! usb-redir: add files for SCSI and USB MSC implementation Frediano Ziglio Superseded
[spice-gtk,28/44] fixup! usb-redir: add files for SCSI and USB MSC implementation Frediano Ziglio Superseded
[spice-gtk,29/44] fixup! usb-redir: add files for SCSI and USB MSC implementation Frediano Ziglio Superseded
[spice-gtk,30/44] usb-redir: add implementation of emulated CD device Frediano Ziglio Superseded
[spice-gtk,31/44] fixup! usb-redir: add implementation of emulated CD device Frediano Ziglio Superseded
[spice-gtk,32/44] fixup! usb-redir: add implementation of emulated CD device Frediano Ziglio Superseded
[spice-gtk,33/44] fixup! usb-redir: add implementation of emulated CD device Frediano Ziglio Superseded
[spice-gtk,35/44] fixup! usb-redir: add implementation of emulated CD device Frediano Ziglio Superseded
[spice-gtk,36/44] fixup! usb-redir: add implementation of emulated CD device Frediano Ziglio Superseded
[spice-gtk,37/44] fixup! usb-redir: add implementation of emulated CD device Frediano Ziglio Superseded
[spice-gtk,38/44] fixup! usb-redir: add implementation of emulated CD device Frediano Ziglio Superseded
[spice-gtk,39/44] fixup! usb-redir: add implementation of emulated CD device Frediano Ziglio Superseded
[spice-gtk,40/44] fixup! usb-redir: add implementation of emulated CD device Frediano Ziglio Superseded
[spice-gtk,41/44] usb-redir: enable redirection of emulated CD drive Frediano Ziglio Superseded
[spice-gtk,42/44] usb-redir: Prepare for creation of emulated CD drive Frediano Ziglio Superseded
[spice-gtk,43/44] CI: Add --werror Frediano Ziglio Accepted
[spice-gtk,44/44] CI: Add usbredir packages to Windows Frediano Ziglio Accepted