Add Multi Segment Gamma Support

Submitted by Shankar, Uma on March 19, 2019, 8:05 a.m.

Details

Reviewer None
Submitted March 19, 2019, 8:05 a.m.
Last Updated April 12, 2019, 12:50 p.m.
Revision 3

Cover Letter(s)

Revision 1
      This series adds support for programmable gamma modes and
exposes a property interface for the same. Also added,
support for mult segment gamma mode introduced in ICL+

Uma Shankar (7):
  drm/i915: Add gamma mode property
  drm/i915: Add intel crtc set and get property callback
  drm/i915: Add Support for Multi Segment Gamma Mode
  drm/i915: Implement get set property handler for multi segment gamma
  drm/i915/icl: Add register definitions for Multi Segmented gamma
  drm/i915/icl: Add support for multi segmented gamma mode
  drm/i915: Add multi segment gamma for icl

 drivers/gpu/drm/i915/i915_drv.h      |   3 +
 drivers/gpu/drm/i915/i915_reg.h      |  17 +++
 drivers/gpu/drm/i915/intel_color.c   | 194 ++++++++++++++++++++++++++++++++---
 drivers/gpu/drm/i915/intel_display.c | 104 +++++++++++++++++++
 drivers/gpu/drm/i915/intel_drv.h     |  15 +++
 include/uapi/drm/i915_drm.h          |  14 +++
 6 files changed, 332 insertions(+), 15 deletions(-)
    
Revision 2
      This series adds support for programmable gamma modes and
exposes a property interface for the same. Also added,
support for multi segment gamma mode introduced in ICL+

It creates 2 property interfaces :
1. GAMMA_MODE_CAPS: This is immutable property and exposes
the various gamma modes supported and the lut ranges. This
is an enum property with element as blob id. Getting the
blob id in userspace, user can get the mode supported and
also the range of gamma mode supported with number of lut
coefficients.

2. GAMMA_MODE: This is for user to set the gamma mode and
send the lut values for that particular mode.

v2: Used Ville's design and approach to define the interfaces.
Addressed Matt Roper's review feedback and re-ordered the
patches.

Uma Shankar (5):
  drm: Add gamma mode property
  drm/i915/icl: Add register definitions for Multi Segmented gamma
  drm/i915/icl: Add support for multi segmented gamma mode
  drm/i915: Add gamma mode caps property
  drm/i915: Attach gamma mode property

Ville Syrjälä (2):
  drm: Add gamma mode caps property
  drm/i915: Define color lut range structure

 drivers/gpu/drm/drm_atomic_uapi.c    |  13 +
 drivers/gpu/drm/drm_color_mgmt.c     | 110 +++++++++
 drivers/gpu/drm/i915/i915_reg.h      |  17 ++
 drivers/gpu/drm/i915/intel_color.c   | 465 ++++++++++++++++++++++++++++++++++-
 drivers/gpu/drm/i915/intel_display.c |   5 +
 include/drm/drm_color_mgmt.h         |  11 +
 include/drm/drm_crtc.h               |  17 ++
 include/drm/drm_mode_config.h        |  10 +
 include/uapi/drm/drm_mode.h          |  49 ++++
 9 files changed, 690 insertions(+), 7 deletions(-)
    
Revision 3
      This series adds support for programmable gamma modes and
exposes a property interface for the same. Also added,
support for multi segment gamma mode introduced in ICL+

It creates GAMMA_MODE property interface. This is an enum
property with values as blob_id's and exposes
the various gamma modes supported and the lut ranges  Getting the
blob id in userspace, user can get the mode supported and
also the range of gamma mode supported with number of lut
coefficients. It can then set one of the modes using this
enum property.

Lut values will be sent through already available GAMMA_LUT
blob property.

It also introduces a CLIENT CAP for advanced GAMMA_MODE.
 This is for user to set the and use advance gamma mode and older
userspace can continue using the legacy paths.

v2: Used Ville's design and approach to define the interfaces.
Addressed Matt Roper's review feedback and re-ordered the
patches.

v3: Converged to 1 property interface and introduced a Client cap
as suggested by Ville. Fixed review comments received.

Uma Shankar (5):
  drm/i915/icl: Add register definitions for Multi Segmented gamma
  drm/i915/icl: Add support for multi segmented gamma mode
  drm/i915: Attach gamma mode property
  drm: Add Client Cap for advance gamma mode
  drm/i915: Enable advance gamma mode

Ville Syrjälä (2):
  drm: Add gamma mode property
  drm/i915: Define color lut range structure

 drivers/gpu/drm/drm_atomic_uapi.c    |   8 +
 drivers/gpu/drm/drm_color_mgmt.c     |  77 ++++
 drivers/gpu/drm/drm_ioctl.c          |   5 +
 drivers/gpu/drm/i915/i915_reg.h      |  17 +
 drivers/gpu/drm/i915/intel_color.c   | 735 ++++++++++++++++++++++++++++++++++-
 drivers/gpu/drm/i915/intel_display.c |   3 +
 include/drm/drm_atomic.h             |   1 +
 include/drm/drm_color_mgmt.h         |   8 +
 include/drm/drm_crtc.h               |  17 +
 include/drm/drm_file.h               |   8 +
 include/drm/drm_mode_config.h        |   6 +
 include/uapi/drm/drm.h               |   2 +
 include/uapi/drm/drm_mode.h          |  38 ++
 13 files changed, 918 insertions(+), 7 deletions(-)
    

Revisions

Patches download mbox

Tests

CI Bug Log - changes from CI_DRM_5770 -> Patchwork_12509
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_12509 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_12509, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/58169/revisions/1/mbox/

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_12509:

### IGT changes ###

#### Possible regressions ####

  * igt@runner@aborted:
    - fi-ilk-650:         NOTRUN -> FAIL
    - fi-pnv-d510:        NOTRUN -> FAIL
    - fi-bdw-gvtdvm:      NOTRUN -> FAIL
    - fi-hsw-peppy:       NOTRUN -> FAIL
    - fi-gdg-551:         NOTRUN -> FAIL
    - fi-snb-2520m:       NOTRUN -> FAIL
    - fi-hsw-4770:        NOTRUN -> FAIL
    - fi-whl-u:           NOTRUN -> FAIL
    - fi-icl-u3:          NOTRUN -> FAIL
    - fi-ivb-3770:        NOTRUN -> FAIL
    - fi-byt-j1900:       NOTRUN -> FAIL
    - fi-bsw-n3050:       NOTRUN -> FAIL
    - fi-blb-e6850:       NOTRUN -> FAIL
    - fi-bsw-kefka:       NOTRUN -> FAIL
    - fi-hsw-4770r:       NOTRUN -> FAIL
    - fi-byt-clapper:     NOTRUN -> FAIL
    - fi-bdw-5557u:       NOTRUN -> FAIL
    - fi-bwr-2160:        NOTRUN -> FAIL
    - fi-byt-n2820:       NOTRUN -> FAIL
    - fi-elk-e7500:       NOTRUN -> FAIL

  
#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@runner@aborted:
    - {fi-icl-y}:         NOTRUN -> FAIL

  
Known issues
------------

  Here are the changes found in Patchwork_12509 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@runner@aborted:
    - fi-cfl-8109u:       NOTRUN -> FAIL [k.org#202107] / [k.org#202109]
    - fi-bxt-j4205:       NOTRUN -> FAIL [fdo#109516]
    - fi-skl-iommu:       NOTRUN -> FAIL [fdo#104108]
    - fi-cfl-guc:         NOTRUN -> FAIL [k.org#202107] / [k.org#202109]
    - fi-kbl-7567u:       NOTRUN -> FAIL [fdo#108903] / [fdo#108904] / [fdo#108905]
    - fi-skl-guc:         NOTRUN -> FAIL [fdo#104108]
    - fi-skl-6700k2:      NOTRUN -> FAIL [fdo#104108]
    - fi-kbl-x1275:       NOTRUN -> FAIL [fdo#108903] / [fdo#108904] / [fdo#108905]
    - fi-cfl-8700k:       NOTRUN -> FAIL [k.org#202107] / [k.org#202109]
    - fi-skl-6600u:       NOTRUN -> FAIL [fdo#104108]
    - fi-kbl-8809g:       NOTRUN -> FAIL [fdo#108903] / [fdo#108904] / [fdo#108905]
    - fi-apl-guc:         NOTRUN -> FAIL [fdo#109373]
    - fi-kbl-r:           NOTRUN -> FAIL [fdo#108903] / [fdo#108904] / [fdo#108905]
    - fi-skl-6770hq:      NOTRUN -> FAIL [fdo#104108]
    - fi-kbl-guc:         NOTRUN -> FAIL [fdo#108903] / [fdo#108904] / [fdo#108905]
    - fi-skl-gvtdvm:      NOTRUN -> FAIL [fdo#104108]
    - fi-snb-2600:        NOTRUN -> FAIL [fdo#108929]
    - fi-skl-6260u:       NOTRUN -> FAIL [fdo#104108]

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
  [fdo#108903]: https://bugs.freedesktop.org/show_bug.cgi?id=108903
  [fdo#108904]: https://bugs.freedesktop.org/show_bug.cgi?id=108904
  [fdo#108905]: https://bugs.freedesktop.org/show_bug.cgi?id=108905
  [fdo#108929]: https://bugs.freedesktop.org/show_bug.cgi?id=108929
  [fdo#109373]: https://bugs.freedesktop.org/show_bug.cgi?id=109373
  [fdo#109516]: https://bugs.freedesktop.org/show_bug.cgi?id=109516
  [k.org#202107]: https://bugzilla.kernel.org/show_bug.cgi?id=202107
  [k.org#202109]: https://bugzilla.kernel.org/show_bug.cgi?id=202109


Participating hosts (44 -> 42)
------------------------------

  Additional (2): fi-bsw-kefka fi-bsw-n3050 
  Missing    (4): fi-kbl-soraka fi-bsw-cyan fi-bdw-samus fi-hsw-4200u 


Build changes
-------------

    * Linux: CI_DRM_5770 -> Patchwork_12509

  CI_DRM_5770: 7f60fa0ec6f20661a49a3eeed6e4b0a175783cf6 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4888: 71ad19eb8fe4f0eecae3bf063e107293b90b9abc @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_12509: d23e8eac8e99b570921ae2225b87f1cea6e4828f @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

d23e8eac8e99 drm/i915: Add multi segment gamma for icl
286cdabed18f drm/i915/icl: Add support for multi segmented gamma mode
cd708119e5a6 drm/i915/icl: Add register definitions for Multi Segmented gamma
103a131a2e19 drm/i915: Implement get set property handler for multi segment gamma
e83f5dac54cc drm/i915: Add Support for Multi Segment Gamma Mode
a2f2f0bff701 drm/i915: Add intel crtc set and get property callback
21ee2af67f85 drm/i915: Add gamma mode property
$ dim checkpatch origin/drm-tip
21ee2af67f85 drm/i915: Add gamma mode property
a2f2f0bff701 drm/i915: Add intel crtc set and get property callback
e83f5dac54cc drm/i915: Add Support for Multi Segment Gamma Mode
103a131a2e19 drm/i915: Implement get set property handler for multi segment gamma
-:79: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#79: FILE: drivers/gpu/drm/i915/intel_display.c:13772:
+		ret = intel_atomic_replace_property_blob_from_id(dev,
+					&intel_crtc_state->multi_segment_gamma_lut,

total: 0 errors, 0 warnings, 1 checks, 87 lines checked
cd708119e5a6 drm/i915/icl: Add register definitions for Multi Segmented gamma
286cdabed18f drm/i915/icl: Add support for multi segmented gamma mode
-:61: CHECK:SPACING: space preferred before that '|' (ctx:VxE)
#61: FILE: drivers/gpu/drm/i915/intel_color.c:591:
+					(GEN11_GET_LS6BITS_OF_LUT(lut[i].green) << 10)|
 					                                              ^

total: 0 errors, 0 warnings, 1 checks, 152 lines checked
d23e8eac8e99 drm/i915: Add multi segment gamma for icl
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915: Add gamma mode property
+drivers/gpu/drm/i915/intel_color.c:131:1: warning: symbol 'intel_attach_gamma_mode_property' was not declared. Should it be static?
-drivers/gpu/drm/i915/selftests/../i915_drv.h:3558:16: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/selftests/../i915_drv.h:3560:16: warning: expression using sizeof(void)

Commit: drm/i915: Add intel crtc set and get property callback
+                                ^~~~~~~~
+drivers/gpu/drm/i915/intel_display.c:13691:5: warning: symbol 'intel_crtc_atomic_get_property' was not declared. Should it be static?
+drivers/gpu/drm/i915/intel_display.c:13730:32: error: ‘replaced’ undeclared (first use in this function); did you mean ‘replace_fd’?
+drivers/gpu/drm/i915/intel_display.c:13730:32: note: each undeclared identifier is reported only once for each function it appears in
+drivers/gpu/drm/i915/intel_display.c:13730:46: error: undefined identifier 'replaced'
+drivers/gpu/drm/i915/intel_display.c: In function ‘intel_crtc_atomic_set_property’:
+make[1]: *** [drivers/gpu/drm/] Error 2
+make[2]: *** [drivers/gpu/drm/i915] Error 2
+make[3]: *** [drivers/gpu/drm/i915/intel_display.o] Error 1
+make: *** [sub-make] Error 2
+                                replace_fd
+   state->color_mgmt_changed |= replaced;

Commit: drm/i915: Add Support for Multi Segment Gamma Mode
+drivers/gpu/drm/i915/intel_color.c:153:1: warning: symbol 'intel_attach_multi_segment_gamma_mode_property' was not declared. Should it be static?
-drivers/gpu/drm/i915/selftests/../i915_drv.h:3560:16: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/selftests/../i915_drv.h:3561:16: warning: expression using sizeof(void)
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)

Commit: drm/i915: Implement get set property handler for multi segment gamma
-                                ^~~~~~~~
+drivers/gpu/drm/i915/gvt/gtt.c:757:9:    expected void [noderef] <asn:4>**slot
+drivers/gpu/drm/i915/gvt/gtt.c:757:9:    expected void **slot
+drivers/gpu/drm/i915/gvt/gtt.c:757:9:    expected void **slot
+drivers/gpu/drm/i915/gvt/gtt.c:757:9:    expected void **slot
+drivers/gpu/drm/i915/gvt/gtt.c:757:9:    got void [noderef] <asn:4>**
+drivers/gpu/drm/i915/gvt/gtt.c:757:9:    got void [noderef] <asn:4>**
+drivers/gpu/drm/i915/gvt/gtt.c:757:9:    got void [noderef] <asn:4>**
+drivers/gpu/drm/i915/gvt/gtt.c:757:9:    got void **slot
+drivers/gpu/drm/i915/gvt/gtt.c:757:9: warning: incorrect type in argument 1 (different address spaces)
+drivers/gpu/drm/i915/gvt/gtt.c:757:9: warning: incorrect type in assignment (different address spaces)
+drivers/gpu/drm/i915/gvt/gtt.c:757:9: warning: incorrect type in assignment (different address spaces)
+drivers/gpu/drm/i915/gvt/gtt.c:757:9: warning: incorrect type in assignment (different address spaces)
+drivers/gpu/drm/i915/gvt/gtt.c:758:45:    expected void [noderef] <asn:4>**slot
+drivers/gpu/drm/i915/gvt/gtt.c:758:45:    got void **slot
+drivers/gpu/drm/i915/gvt/gtt.c:758:45: warning: incorrect type in argument 1 (different address spaces)
+drivers/gpu/drm/i915/gvt/mmio.c:282:23: warning: memcpy with byte count of 279040
+drivers/gpu/drm/i915/gvt/mmio.c:283:23: warning: memcpy with byte count of 279040
+drivers/gpu/drm/i915/gvt/vgpu.c:196:48: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/gvt/vgpu.c:196:48: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/gvt/vgpu.c:196:48: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/gvt/vgpu.c:196:48: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/gvt/vgpu.c:196:48: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/gvt/vgpu.c:196:48: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/gvt/vgpu.c:196:48: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/gvt/vgpu.c:196:48: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/gvt/vgpu.c:196:48: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/gvt/vgpu.c:196:48: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/gvt/vgpu.c:196:48: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/gvt/vgpu.c:196:48: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/gvt/vgpu.c:196:48: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/gvt/vgpu.c:196:48: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_display.c:13730:32: error: ‘replaced’ undeclared (first use in this function); did you mean ‘replace_fd’?
-O:drivers/gpu/drm/i915/intel_display.c:13730:32: note: each undeclared identifier is reported only once for each function it appears in
-O:drivers/gpu/drm/i915/intel_display.c:13730:46: error: undefined identifier 'replaced'
+drivers/gpu/drm/i915/intel_display.c:13755:5: warning: symbol 'intel_crtc_atomic_set_property' was not declared. Should it be static?
-drivers/gpu/drm/i915/intel_display.c: In function ‘intel_crtc_atomic_set_property’:
+./include/linux/overflow.h:251:13: error: incorrect type in conditional
+./include/linux/overflow.h:251:13: error: incorrect type in conditional
+./include/linux/overflow.h:251:13: error: undefined identifier '__builtin_mul_overflow'
+./include/linux/overflow.h:251:13: error: undefined identifier '__builtin_mul_overflow'
+./include/linux/overflow.h:251:13:    got void
+./include/linux/overflow.h:251:13:    got void
+./include/linux/overflow.h:251:13: warning: call with no type!
+./include/linux/overflow.h:251:13: warning: call with no type!
+./include/linux/slab.h:664:13: error: undefined identifier '__builtin_mul_overflow'
+./include/linux/slab.h:664:13: error: undefined identifier '__builtin_mul_overflow'
+./include/linux/slab.h:664:13: warning: call with no type!
+./include/linux/slab.h:664:13: warning: call with no type!
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
-make[1]: *** [drivers/gpu/drm/] Error 2
-make[2]: *** [drivers/gpu/drm/i915] Error 2
-make[3]: *** [drivers/gpu/drm/i915/intel_display.o] Error 1
-make[3]: *** Waiting for unfinished jobs....
-make: *** [sub-make] Error 2
-                                replace_fd
-   state->color_mgmt_changed |= replaced;

Commit: drm/i915/icl: Add register definitions for Multi Segmented gamma
Okay!

Commit: drm/i915/icl: Add support for multi segmented gamma mode
Okay!

Commit: drm/i915: Add multi segment gamma for icl
Okay!

Patches download mbox

Tests

CI Bug Log - changes from CI_DRM_5854 -> Patchwork_12653
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_12653 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_12653, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/58169/revisions/2/mbox/

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_12653:

### IGT changes ###

#### Possible regressions ####

  * igt@runner@aborted:
    - fi-icl-u3:          NOTRUN -> FAIL
    - fi-icl-y:           NOTRUN -> FAIL

  
Known issues
------------

  Here are the changes found in Patchwork_12653 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@kms_pipe_crc_basic@read-crc-pipe-b:
    - fi-byt-clapper:     PASS -> FAIL [fdo#107362]

  * igt@runner@aborted:
    - fi-icl-u2:          NOTRUN -> FAIL [k.org#202973]
    - fi-apl-guc:         NOTRUN -> FAIL [fdo#108622] / [fdo#109720]

  
#### Possible fixes ####

  * igt@i915_selftest@live_contexts:
    - fi-skl-gvtdvm:      DMESG-FAIL [fdo#110235 ] -> PASS

  * igt@i915_selftest@live_uncore:
    - fi-ivb-3770:        DMESG-FAIL [fdo#110210] -> PASS

  * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
    - fi-byt-clapper:     FAIL [fdo#103191] / [fdo#107362] -> PASS

  
  [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
  [fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
  [fdo#108622]: https://bugs.freedesktop.org/show_bug.cgi?id=108622
  [fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
  [fdo#110210]: https://bugs.freedesktop.org/show_bug.cgi?id=110210
  [fdo#110235 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110235 
  [k.org#202973]: https://bugzilla.kernel.org/show_bug.cgi?id=202973


Participating hosts (51 -> 40)
------------------------------

  Missing    (11): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-j1900 fi-hsw-peppy fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-gdg-551 fi-pnv-d510 fi-bdw-samus 


Build changes
-------------

    * Linux: CI_DRM_5854 -> Patchwork_12653

  CI_DRM_5854: 3b59d4fb5ba3fb53a87c7a4495d81b0a25aa96eb @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4919: f539e21e934019f0196fee646f351b4e30a8c341 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_12653: a7d35ed03858e1ceb89578d7bf0bb7d9196e0a9a @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

a7d35ed03858 drm/i915: Attach gamma mode property
7e97b366c05e drm/i915: Add gamma mode caps property
3b03f07ba428 drm/i915/icl: Add support for multi segmented gamma mode
a5deda67bb81 drm/i915/icl: Add register definitions for Multi Segmented gamma
a059b6bf4fe1 drm: Add gamma mode property
659fe8427470 drm/i915: Define color lut range structure
75ad704a2b21 drm: Add gamma mode caps property
$ dim checkpatch origin/drm-tip
75ad704a2b21 drm: Add gamma mode caps property
659fe8427470 drm/i915: Define color lut range structure
-:61: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#61: FILE: drivers/gpu/drm/i915/intel_color.c:1124:
+#define I965_GAMMA_10 \
+	{ \
+		.flags = (DRM_MODE_LUT_GAMMA | \
+			  DRM_MODE_LUT_INTERPOLATE | \
+			  DRM_MODE_LUT_NON_DECREASING), \
+		.count = 128, \
+		.input_bpc = 10, .output_bpc = 16, \
+		.start = 0, .end = (1 << 10) - (1 << 10) / 128, \
+		.min = 0, .max = (1 << 16) - 1, \
+	}, \
+	/* PIPEGCMAX */ \
+	{ \
+		.flags = (DRM_MODE_LUT_GAMMA | \
+			  DRM_MODE_LUT_INTERPOLATE | \
+			  DRM_MODE_LUT_REUSE_LAST | \
+			  DRM_MODE_LUT_NON_DECREASING), \
+		.count = 1, \
+		.input_bpc = 10, .output_bpc = 16, \
+		.start = (1 << 10) - (1 << 10) / 128, .end = 1 << 10, \
+		.min = 0, .max = 1 << 16, \
+	}

total: 1 errors, 0 warnings, 0 checks, 320 lines checked
a059b6bf4fe1 drm: Add gamma mode property
-:26: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#26: FILE: drivers/gpu/drm/drm_atomic_uapi.c:464:
+		ret = drm_atomic_replace_property_blob_from_id(dev,
+					&state->gamma_mode,

total: 0 errors, 0 warnings, 1 checks, 110 lines checked
a5deda67bb81 drm/i915/icl: Add register definitions for Multi Segmented gamma
3b03f07ba428 drm/i915/icl: Add support for multi segmented gamma mode
-:79: ERROR:TRAILING_WHITESPACE: trailing whitespace
#79: FILE: drivers/gpu/drm/i915/intel_color.c:719:
+^I$

-:102: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#102: FILE: drivers/gpu/drm/i915/intel_color.c:742:
+	 * from 3.0 to 7.0
+	*/

total: 1 errors, 1 warnings, 0 checks, 211 lines checked
7e97b366c05e drm/i915: Add gamma mode caps property
a7d35ed03858 drm/i915: Attach gamma mode property
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm: Add gamma mode caps property
Okay!

Commit: drm/i915: Define color lut range structure
Okay!

Commit: drm: Add gamma mode property
Okay!

Commit: drm/i915/icl: Add register definitions for Multi Segmented gamma
Okay!

Commit: drm/i915/icl: Add support for multi segmented gamma mode
Okay!

Commit: drm/i915: Add gamma mode caps property
Okay!

Commit: drm/i915: Attach gamma mode property
Okay!

Patches download mbox

Tests

CI Bug Log - changes from CI_DRM_5922 -> Patchwork_12776
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_12776 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_12776, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/58169/revisions/3/mbox/

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_12776:

### IGT changes ###

#### Possible regressions ####

  * igt@runner@aborted:
    - fi-icl-u3:          NOTRUN -> FAIL
    - fi-icl-y:           NOTRUN -> FAIL

  
Known issues
------------

  Here are the changes found in Patchwork_12776 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_suspend@basic-s3:
    - fi-blb-e6850:       PASS -> INCOMPLETE [fdo#107718]

  * igt@i915_selftest@live_execlists:
    - fi-apl-guc:         PASS -> INCOMPLETE [fdo#103927] / [fdo#109720]

  
#### Possible fixes ####

  * igt@i915_pm_rpm@module-reload:
    - fi-skl-6770hq:      FAIL [fdo#108511] -> PASS

  * igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
    - fi-glk-dsi:         FAIL [fdo#103191] -> PASS

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
  [fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
  [fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
  [k.org#202973]: https://bugzilla.kernel.org/show_bug.cgi?id=202973


Participating hosts (49 -> 40)
------------------------------

  Additional (1): fi-icl-u2 
  Missing    (10): fi-kbl-soraka fi-bxt-dsi fi-hsw-4200u fi-hsw-peppy fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-gdg-551 fi-pnv-d510 fi-byt-clapper 


Build changes
-------------

    * Linux: CI_DRM_5922 -> Patchwork_12776

  CI_DRM_5922: 849ac6dbff7f5073c3181c5eba07936fe3f576ec @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4944: 9b74b8226e8c108db091bd3b1d105a71dc0fb861 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_12776: b242a6ad7aac6fbe4a9781fe47f183533be9f4c2 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

b242a6ad7aac drm/i915: Enable advance gamma mode
bdc37237baa1 drm: Add Client Cap for advance gamma mode
b369c50ff3bc drm/i915: Attach gamma mode property
cf96572ff8b3 drm/i915/icl: Add support for multi segmented gamma mode
d5c82ca71cfe drm/i915/icl: Add register definitions for Multi Segmented gamma
938ac10de262 drm/i915: Define color lut range structure
d60e638b9241 drm: Add gamma mode property
$ dim checkpatch origin/drm-tip
d60e638b9241 drm: Add gamma mode property
938ac10de262 drm/i915: Define color lut range structure
-:28: ERROR:CODE_INDENT: code indent should use tabs where possible
#28: FILE: drivers/gpu/drm/i915/intel_color.c:388:
+        /*$

-:29: ERROR:CODE_INDENT: code indent should use tabs where possible
#29: FILE: drivers/gpu/drm/i915/intel_color.c:389:
+         * Bspec:$

-:30: ERROR:CODE_INDENT: code indent should use tabs where possible
#30: FILE: drivers/gpu/drm/i915/intel_color.c:390:
+         " "NOTE: The 8-bit (non-10-bit) mode is the only$

-:31: ERROR:CODE_INDENT: code indent should use tabs where possible
#31: FILE: drivers/gpu/drm/i915/intel_color.c:391:
+         *  mode supported by BrookDale-G and Springdale-G."$

-:32: ERROR:CODE_INDENT: code indent should use tabs where possible
#32: FILE: drivers/gpu/drm/i915/intel_color.c:392:
+         * and$

-:33: ERROR:CODE_INDENT: code indent should use tabs where possible
#33: FILE: drivers/gpu/drm/i915/intel_color.c:393:
+         * "NOTE: The 8-bit (non-10-bit) mode is the only$

-:34: ERROR:CODE_INDENT: code indent should use tabs where possible
#34: FILE: drivers/gpu/drm/i915/intel_color.c:394:
+         * mode supported by Alviso and Grantsdale."$

-:35: ERROR:CODE_INDENT: code indent should use tabs where possible
#35: FILE: drivers/gpu/drm/i915/intel_color.c:395:
+         */$

-:36: ERROR:CODE_INDENT: code indent should use tabs where possible
#36: FILE: drivers/gpu/drm/i915/intel_color.c:396:
+        return !IS_I845G(dev_priv) && !IS_I865G(dev_priv) &&$

-:36: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#36: FILE: drivers/gpu/drm/i915/intel_color.c:396:
+        return !IS_I845G(dev_priv) && !IS_I865G(dev_priv) &&$

-:37: ERROR:CODE_INDENT: code indent should use tabs where possible
#37: FILE: drivers/gpu/drm/i915/intel_color.c:397:
+                !IS_I915G(dev_priv) && !IS_I915GM(dev_priv);$

-:37: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#37: FILE: drivers/gpu/drm/i915/intel_color.c:397:
+                !IS_I915G(dev_priv) && !IS_I915GM(dev_priv);$

-:85: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#85: FILE: drivers/gpu/drm/i915/intel_color.c:1276:
+#define I965_GAMMA_10 \
+	{ \
+		.flags = (DRM_MODE_LUT_GAMMA | \
+			  DRM_MODE_LUT_INTERPOLATE | \
+			  DRM_MODE_LUT_NON_DECREASING), \
+		.count = 128, \
+		.input_bpc = 10, .output_bpc = 16, \
+		.start = 0, .end = (1 << 10) - (1 << 10) / 128, \
+		.min = 0, .max = (1 << 16) - 1, \
+	}, \
+	/* PIPEGCMAX */ \
+	{ \
+		.flags = (DRM_MODE_LUT_GAMMA | \
+			  DRM_MODE_LUT_INTERPOLATE | \
+			  DRM_MODE_LUT_REUSE_LAST | \
+			  DRM_MODE_LUT_NON_DECREASING), \
+		.count = 1, \
+		.input_bpc = 10, .output_bpc = 16, \
+		.start = (1 << 10) - (1 << 10) / 128, .end = 1 << 10, \
+		.min = 0, .max = 1 << 16, \
+	}

-:112: ERROR:CODE_INDENT: code indent should use tabs where possible
#112: FILE: drivers/gpu/drm/i915/intel_color.c:1303:
+        { \$

-:112: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#112: FILE: drivers/gpu/drm/i915/intel_color.c:1303:
+        { \$

-:113: ERROR:CODE_INDENT: code indent should use tabs where possible
#113: FILE: drivers/gpu/drm/i915/intel_color.c:1304:
+                .flags = (DRM_MODE_LUT_DEGAMMA | \$

-:113: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#113: FILE: drivers/gpu/drm/i915/intel_color.c:1304:
+                .flags = (DRM_MODE_LUT_DEGAMMA | \$

-:114: ERROR:CODE_INDENT: code indent should use tabs where possible
#114: FILE: drivers/gpu/drm/i915/intel_color.c:1305:
+                          DRM_MODE_LUT_INTERPOLATE | \$

-:114: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#114: FILE: drivers/gpu/drm/i915/intel_color.c:1305:
+                          DRM_MODE_LUT_INTERPOLATE | \$

-:115: ERROR:CODE_INDENT: code indent should use tabs where possible
#115: FILE: drivers/gpu/drm/i915/intel_color.c:1306:
+                          DRM_MODE_LUT_NON_DECREASING), \$

-:115: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#115: FILE: drivers/gpu/drm/i915/intel_color.c:1306:
+                          DRM_MODE_LUT_NON_DECREASING), \$

-:116: ERROR:CODE_INDENT: code indent should use tabs where possible
#116: FILE: drivers/gpu/drm/i915/intel_color.c:1307:
+                .count = 65, \$

-:116: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#116: FILE: drivers/gpu/drm/i915/intel_color.c:1307:
+                .count = 65, \$

-:117: ERROR:CODE_INDENT: code indent should use tabs where possible
#117: FILE: drivers/gpu/drm/i915/intel_color.c:1308:
+                .input_bpc = 10, .output_bpc = 14, \$

-:117: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#117: FILE: drivers/gpu/drm/i915/intel_color.c:1308:
+                .input_bpc = 10, .output_bpc = 14, \$

-:118: ERROR:CODE_INDENT: code indent should use tabs where possible
#118: FILE: drivers/gpu/drm/i915/intel_color.c:1309:
+                .start = 0, .end = 1 << 10, \$

-:118: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#118: FILE: drivers/gpu/drm/i915/intel_color.c:1309:
+                .start = 0, .end = 1 << 10, \$

-:119: ERROR:CODE_INDENT: code indent should use tabs where possible
#119: FILE: drivers/gpu/drm/i915/intel_color.c:1310:
+                .min = 0, .max = (1 << 14) - 1, \$

-:119: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#119: FILE: drivers/gpu/drm/i915/intel_color.c:1310:
+                .min = 0, .max = (1 << 14) - 1, \$

-:120: ERROR:CODE_INDENT: code indent should use tabs where possible
#120: FILE: drivers/gpu/drm/i915/intel_color.c:1311:
+        }$

-:120: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#120: FILE: drivers/gpu/drm/i915/intel_color.c:1311:
+        }$

-:122: ERROR:CODE_INDENT: code indent should use tabs where possible
#122: FILE: drivers/gpu/drm/i915/intel_color.c:1313:
+        { \$

-:122: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#122: FILE: drivers/gpu/drm/i915/intel_color.c:1313:
+        { \$

-:123: ERROR:CODE_INDENT: code indent should use tabs where possible
#123: FILE: drivers/gpu/drm/i915/intel_color.c:1314:
+                .flags = (DRM_MODE_LUT_GAMMA | \$

-:123: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#123: FILE: drivers/gpu/drm/i915/intel_color.c:1314:
+                .flags = (DRM_MODE_LUT_GAMMA | \$

-:124: ERROR:CODE_INDENT: code indent should use tabs where possible
#124: FILE: drivers/gpu/drm/i915/intel_color.c:1315:
+                          DRM_MODE_LUT_INTERPOLATE | \$

-:124: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#124: FILE: drivers/gpu/drm/i915/intel_color.c:1315:
+                          DRM_MODE_LUT_INTERPOLATE | \$

-:125: ERROR:CODE_INDENT: code indent should use tabs where possible
#125: FILE: drivers/gpu/drm/i915/intel_color.c:1316:
+                          DRM_MODE_LUT_NON_DECREASING), \$

-:125: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#125: FILE: drivers/gpu/drm/i915/intel_color.c:1316:
+                          DRM_MODE_LUT_NON_DECREASING), \$

-:126: ERROR:CODE_INDENT: code indent should use tabs where possible
#126: FILE: drivers/gpu/drm/i915/intel_color.c:1317:
+                .count = 257, \$

-:126: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#126: FILE: drivers/gpu/drm/i915/intel_color.c:1317:
+                .count = 257, \$

-:127: ERROR:CODE_INDENT: code indent should use tabs where possible
#127: FILE: drivers/gpu/drm/i915/intel_color.c:1318:
+                .input_bpc = 14, .output_bpc = 10, \$

-:127: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#127: FILE: drivers/gpu/drm/i915/intel_color.c:1318:
+                .input_bpc = 14, .output_bpc = 10, \$

-:128: ERROR:CODE_INDENT: code indent should use tabs where possible
#128: FILE: drivers/gpu/drm/i915/intel_color.c:1319:
+                .start = 0, .end = 1 << 14, \$

-:128: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#128: FILE: drivers/gpu/drm/i915/intel_color.c:1319:
+                .start = 0, .end = 1 << 14, \$

-:129: ERROR:CODE_INDENT: code indent should use tabs where possible
#129: FILE: drivers/gpu/drm/i915/intel_color.c:1320:
+                .min = 0, .max = (1 << 10) - 1, \$

-:129: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#129: FILE: drivers/gpu/drm/i915/intel_color.c:1320:
+                .min = 0, .max = (1 << 10) - 1, \$

-:130: ERROR:CODE_INDENT: code indent should use tabs where possible
#130: FILE: drivers/gpu/drm/i915/intel_color.c:1321:
+        }$

-:130: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#130: FILE: drivers/gpu/drm/i915/intel_color.c:1321:
+        }$

-:133: ERROR:CODE_INDENT: code indent should use tabs where possible
#133: FILE: drivers/gpu/drm/i915/intel_color.c:1324:
+        CHV_CGM_DEGAMMA,$

-:133: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#133: FILE: drivers/gpu/drm/i915/intel_color.c:1324:
+        CHV_CGM_DEGAMMA,$

-:137: ERROR:CODE_INDENT: code indent should use tabs where possible
#137: FILE: drivers/gpu/drm/i915/intel_color.c:1328:
+        CHV_CGM_GAMMA,$

-:137: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#137: FILE: drivers/gpu/drm/i915/intel_color.c:1328:
+        CHV_CGM_GAMMA,$

-:141: ERROR:CODE_INDENT: code indent should use tabs where possible
#141: FILE: drivers/gpu/drm/i915/intel_color.c:1332:
+        CHV_CGM_DEGAMMA,$

-:141: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#141: FILE: drivers/gpu/drm/i915/intel_color.c:1332:
+        CHV_CGM_DEGAMMA,$

-:142: ERROR:CODE_INDENT: code indent should use tabs where possible
#142: FILE: drivers/gpu/drm/i915/intel_color.c:1333:
+        I9XX_GAMMA_8,$

-:142: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#142: FILE: drivers/gpu/drm/i915/intel_color.c:1333:
+        I9XX_GAMMA_8,$

-:146: ERROR:CODE_INDENT: code indent should use tabs where possible
#146: FILE: drivers/gpu/drm/i915/intel_color.c:1337:
+        CHV_CGM_DEGAMMA,$

-:146: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#146: FILE: drivers/gpu/drm/i915/intel_color.c:1337:
+        CHV_CGM_DEGAMMA,$

-:147: ERROR:CODE_INDENT: code indent should use tabs where possible
#147: FILE: drivers/gpu/drm/i915/intel_color.c:1338:
+        I965_GAMMA_10,$

-:147: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#147: FILE: drivers/gpu/drm/i915/intel_color.c:1338:
+        I965_GAMMA_10,$

-:151: ERROR:CODE_INDENT: code indent should use tabs where possible
#151: FILE: drivers/gpu/drm/i915/intel_color.c:1342:
+        CHV_CGM_DEGAMMA,$

-:151: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#151: FILE: drivers/gpu/drm/i915/intel_color.c:1342:
+        CHV_CGM_DEGAMMA,$

-:152: ERROR:CODE_INDENT: code indent should use tabs where possible
#152: FILE: drivers/gpu/drm/i915/intel_color.c:1343:
+        CHV_CGM_GAMMA,$

-:152: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#152: FILE: drivers/gpu/drm/i915/intel_color.c:1343:
+        CHV_CGM_GAMMA,$

-:203: ERROR:CODE_INDENT: code indent should use tabs where possible
#203: FILE: drivers/gpu/drm/i915/intel_color.c:1394:
+        {$

-:203: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#203: FILE: drivers/gpu/drm/i915/intel_color.c:1394:
+        {$

-:204: ERROR:CODE_INDENT: code indent should use tabs where possible
#204: FILE: drivers/gpu/drm/i915/intel_color.c:1395:
+                .flags = (DRM_MODE_LUT_GAMMA |$

-:204: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#204: FILE: drivers/gpu/drm/i915/intel_color.c:1395:
+                .flags = (DRM_MODE_LUT_GAMMA |$

-:205: ERROR:CODE_INDENT: code indent should use tabs where possible
#205: FILE: drivers/gpu/drm/i915/intel_color.c:1396:
+                          DRM_MODE_LUT_DEGAMMA |$

-:205: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#205: FILE: drivers/gpu/drm/i915/intel_color.c:1396:
+                          DRM_MODE_LUT_DEGAMMA |$

-:206: ERROR:CODE_INDENT: code indent should use tabs where possible
#206: FILE: drivers/gpu/drm/i915/intel_color.c:1397:
+                          DRM_MODE_LUT_REFLECT_NEGATIVE),$

-:206: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#206: FILE: drivers/gpu/drm/i915/intel_color.c:1397:
+                          DRM_MODE_LUT_REFLECT_NEGATIVE),$

-:207: ERROR:CODE_INDENT: code indent should use tabs where possible
#207: FILE: drivers/gpu/drm/i915/intel_color.c:1398:
+                .count = 1024,$

-:207: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#207: FILE: drivers/gpu/drm/i915/intel_color.c:1398:
+                .count = 1024,$

-:208: ERROR:CODE_INDENT: code indent should use tabs where possible
#208: FILE: drivers/gpu/drm/i915/intel_color.c:1399:
+                .input_bpc = 10, .output_bpc = 10,$

-:208: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#208: FILE: drivers/gpu/drm/i915/intel_color.c:1399:
+                .input_bpc = 10, .output_bpc = 10,$

-:209: ERROR:CODE_INDENT: code indent should use tabs where possible
#209: FILE: drivers/gpu/drm/i915/intel_color.c:1400:
+                .start = 0, .end = (1 << 10) - 1,$

-:209: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#209: FILE: drivers/gpu/drm/i915/intel_color.c:1400:
+                .start = 0, .end = (1 << 10) - 1,$

-:210: ERROR:CODE_INDENT: code indent should use tabs where possible
#210: FILE: drivers/gpu/drm/i915/intel_color.c:1401:
+                .min = 0, .max = (1 << 10) - 1,$

-:210: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#210: FILE: drivers/gpu/drm/i915/intel_color.c:1401:
+                .min = 0, .max = (1 << 10) - 1,$

-:211: ERROR:CODE_INDENT: code indent should use tabs where possible
#211: FILE: drivers/gpu/drm/i915/intel_color.c:1402:
+        },$

-:211: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#211: FILE: drivers/gpu/drm/i915/intel_color.c:1402:
+        },$

-:212: ERROR:CODE_INDENT: code indent should use tabs where possible
#212: FILE: drivers/gpu/drm/i915/intel_color.c:1403:
+        /* PAL_EXT_GC_MAX */$

-:213: ERROR:CODE_INDENT: code indent should use tabs where possible
#213: FILE: drivers/gpu/drm/i915/intel_color.c:1404:
+        {$

-:213: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#213: FILE: drivers/gpu/drm/i915/intel_color.c:1404:
+        {$

-:214: ERROR:CODE_INDENT: code indent should use tabs where possible
#214: FILE: drivers/gpu/drm/i915/intel_color.c:1405:
+                .flags = (DRM_MODE_LUT_GAMMA |$

-:214: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#214: FILE: drivers/gpu/drm/i915/intel_color.c:1405:
+                .flags = (DRM_MODE_LUT_GAMMA |$

-:215: ERROR:CODE_INDENT: code indent should use tabs where possible
#215: FILE: drivers/gpu/drm/i915/intel_color.c:1406:
+                          DRM_MODE_LUT_DEGAMMA |$

-:215: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#215: FILE: drivers/gpu/drm/i915/intel_color.c:1406:
+                          DRM_MODE_LUT_DEGAMMA |$

-:216: ERROR:CODE_INDENT: code indent should use tabs where possible
#216: FILE: drivers/gpu/drm/i915/intel_color.c:1407:
+                          DRM_MODE_LUT_REFLECT_NEGATIVE |$

-:216: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#216: FILE: drivers/gpu/drm/i915/intel_color.c:1407:
+                          DRM_MODE_LUT_REFLECT_NEGATIVE |$

-:217: ERROR:CODE_INDENT: code indent should use tabs where possible
#217: FILE: drivers/gpu/drm/i915/intel_color.c:1408:
+                          DRM_MODE_LUT_INTERPOLATE |$

-:217: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#217: FILE: drivers/gpu/drm/i915/intel_color.c:1408:
+                          DRM_MODE_LUT_INTERPOLATE |$

-:218: ERROR:CODE_INDENT: code indent should use tabs where possible
#218: FILE: drivers/gpu/drm/i915/intel_color.c:1409:
+                          DRM_MODE_LUT_REUSE_LAST |$

-:218: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#218: FILE: drivers/gpu/drm/i915/intel_color.c:1409:
+                          DRM_MODE_LUT_REUSE_LAST |$

-:219: ERROR:CODE_INDENT: code indent should use tabs where possible
#219: FILE: drivers/gpu/drm/i915/intel_color.c:1410:
+                          DRM_MODE_LUT_NON_DECREASING),$

-:219: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#219: FILE: drivers/gpu/drm/i915/intel_color.c:1410:
+                          DRM_MODE_LUT_NON_DECREASING),$

-:220: ERROR:CODE_INDENT: code indent should use tabs where possible
#220: FILE: drivers/gpu/drm/i915/intel_color.c:1411:
+                .count = 1,$

-:220: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#220: FILE: drivers/gpu/drm/i915/intel_color.c:1411:
+                .count = 1,$

-:221: ERROR:CODE_INDENT: code indent should use tabs where possible
#221: FILE: drivers/gpu/drm/i915/intel_color.c:1412:
+                .input_bpc = 10, .output_bpc = 16,$

-:221: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#221: FILE: drivers/gpu/drm/i915/intel_color.c:1412:
+                .input_bpc = 10, .output_bpc = 16,$

-:222: ERROR:CODE_INDENT: code indent should use tabs where possible
#222: FILE: drivers/gpu/drm/i915/intel_color.c:1413:
+                .start = 1 << 10, .end = 3 << 10,$

-:222: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#222: FILE: drivers/gpu/drm/i915/intel_color.c:1413:
+                .start = 1 << 10, .end = 3 << 10,$

-:223: ERROR:CODE_INDENT: code indent should use tabs where possible
#223: FILE: drivers/gpu/drm/i915/intel_color.c:1414:
+                .min = 0, .max = (8 << 16) - 1,$

-:223: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#223: FILE: drivers/gpu/drm/i915/intel_color.c:1414:
+                .min = 0, .max = (8 << 16) - 1,$

-:224: ERROR:CODE_INDENT: code indent should use tabs where possible
#224: FILE: drivers/gpu/drm/i915/intel_color.c:1415:
+        }$

-:224: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#224: FILE: drivers/gpu/drm/i915/intel_color.c:1415:
+        }$

-:313: ERROR:CODE_INDENT: code indent should use tabs where possible
#313: FILE: drivers/gpu/drm/i915/intel_color.c:1504:
+        {$

-:313: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#313: FILE: drivers/gpu/drm/i915/intel_color.c:1504:
+        {$

-:314: ERROR:CODE_INDENT: code indent should use tabs where possible
#314: FILE: drivers/gpu/drm/i915/intel_color.c:1505:
+                .flags = (DRM_MODE_LUT_DEGAMMA |$

-:314: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#314: FILE: drivers/gpu/drm/i915/intel_color.c:1505:
+                .flags = (DRM_MODE_LUT_DEGAMMA |$

-:315: ERROR:CODE_INDENT: code indent should use tabs where possible
#315: FILE: drivers/gpu/drm/i915/intel_color.c:1506:
+                          DRM_MODE_LUT_REFLECT_NEGATIVE),$

-:315: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#315: FILE: drivers/gpu/drm/i915/intel_color.c:1506:
+                          DRM_MODE_LUT_REFLECT_NEGATIVE),$

-:316: ERROR:CODE_INDENT: code indent should use tabs where possible
#316: FILE: drivers/gpu/drm/i915/intel_color.c:1507:
+                .count = 512,$

-:316: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#316: FILE: drivers/gpu/drm/i915/intel_color.c:1507:
+                .count = 512,$

-:317: ERROR:CODE_INDENT: code indent should use tabs where possible
#317: FILE: drivers/gpu/drm/i915/intel_color.c:1508:
+                .input_bpc = 9, .output_bpc = 10,$

-:317: WARNING:LEADING_SPACE: please, no spaces at the start o
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm: Add gamma mode property
Okay!

Commit: drm/i915: Define color lut range structure
Okay!

Commit: drm/i915/icl: Add register definitions for Multi Segmented gamma
Okay!

Commit: drm/i915/icl: Add support for multi segmented gamma mode
Okay!

Commit: drm/i915: Attach gamma mode property
Okay!

Commit: drm: Add Client Cap for advance gamma mode
Okay!

Commit: drm/i915: Enable advance gamma mode
Okay!