small code improvements on clipboard

Submitted by Victor Toso on Dec. 10, 2018, 11:02 a.m.

Details

Reviewer None
Submitted Dec. 10, 2018, 11:02 a.m.
Last Updated Dec. 10, 2018, 11:03 a.m.
Revision 1

Cover Letter(s)

Revision 1
      From: Victor Toso <me@victortoso.com>

v1: https://lists.freedesktop.org/archives/spice-devel/2018-December/046337.html

From v1, pushed two patches and the other two are the 01/07 and 07/07
in this series.

The extra 5 changes, with channel-main prefix, they are related to the
discussin with Frediano in the v1. The main goal of this small
improvements are:

- on a function that queues a message to the agent, logs a critical if
  the agent is disconnected. The main reason to that is that spice
  client's should be following agent-connected property from
  channel-main. So, logging a critical is a good way to find actual bugs
  in the code;

- do not wakeup channel when failing to queue a message to be sent to
  the agent as it should not be needed;

Cheers,
Victor

Victor Toso (7):
  gtk-session: prefer early check to agent connectivity
  channel-main: clipboard request: wakeup only when needed
  channel-main: clipboard grab: wakeup only when needed
  channel-main: clipboard release: wakeup only when needed
  channel-main: clipboard release: don't fail silently
  channel-main: clipboard grab: don't fail silently
  gtk-session: remove extra clipboard selection check

 src/channel-main.c      | 58 +++++++++++++++++++++--------------------
 src/spice-gtk-session.c | 21 ++++++---------
 2 files changed, 38 insertions(+), 41 deletions(-)
    

Revisions