drm/i915: Force minimum required CDCLK for audio

Submitted by Imre Deak on Sept. 14, 2018, 5:03 p.m.

Details

Reviewer None
Submitted Sept. 14, 2018, 5:03 p.m.
Last Updated Sept. 14, 2018, 7:44 p.m.
Revision 1

Cover Letter(s)

Revision 1
      Imre Deak (2):
  drm/i915: Split resume time display HW readout and modeset
  drm/i915: Move display HW state readout to early resume phase

Takashi Iwai (1):
  sound/hdac_hdmi: Make jack handling asynchronous

Ville Syrjälä (2):
  drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled
  drm/i915: Skip modeset for cdclk changes if possible

 drivers/gpu/drm/i915/i915_drv.c      | 138 +++++++++++++-------------
 drivers/gpu/drm/i915/i915_drv.h      |   7 +-
 drivers/gpu/drm/i915/i915_reg.h      |   3 +-
 drivers/gpu/drm/i915/intel_audio.c   |  65 ++++++++++++-
 drivers/gpu/drm/i915/intel_cdclk.c   | 183 +++++++++++++++++++++++++----------
 drivers/gpu/drm/i915/intel_display.c |  74 ++++++++++++--
 drivers/gpu/drm/i915/intel_drv.h     |  18 +++-
 sound/soc/codecs/hdac_hdmi.c         |  49 ++++++++--
 8 files changed, 395 insertions(+), 142 deletions(-)
    

Revisions

Patches download mbox

Tests

= CI Bug Log - changes from CI_DRM_4828 -> Trybot_2914 =

== Summary - FAILURE ==

  Serious unknown changes coming with Trybot_2914 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Trybot_2914, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/49732/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in Trybot_2914:

  === IGT changes ===

    ==== Possible regressions ====

    igt@drv_module_reload@basic-reload:
      fi-kbl-x1275:       PASS -> INCOMPLETE

    igt@drv_module_reload@basic-reload-inject:
      fi-kbl-guc:         PASS -> TIMEOUT +1
      fi-kbl-8809g:       PASS -> TIMEOUT +1
      fi-kbl-x1275:       PASS -> TIMEOUT +1

    igt@gem_basic@create-close:
      fi-bwr-2160:        PASS -> DMESG-WARN +6

    igt@gem_close_race@basic-threads:
      fi-gdg-551:         PASS -> DMESG-WARN +6

    igt@gem_exec_fence@basic-busy-default:
      fi-blb-e6850:       PASS -> DMESG-WARN +6

    igt@gem_exec_suspend@basic-s3:
      fi-byt-n2820:       PASS -> DMESG-WARN
      fi-byt-j1900:       PASS -> DMESG-WARN

    igt@gem_exec_suspend@basic-s4-devices:
      fi-bsw-kefka:       PASS -> DMESG-WARN +1
      fi-kbl-guc:         PASS -> FAIL
      fi-skl-guc:         PASS -> FAIL
      fi-cfl-guc:         PASS -> FAIL

    igt@kms_busy@basic-flip-a:
      fi-skl-6700k2:      PASS -> INCOMPLETE
      fi-kbl-7500u:       PASS -> INCOMPLETE
      fi-cfl-8109u:       PASS -> INCOMPLETE

    igt@kms_busy@basic-flip-c:
      fi-bsw-n3050:       PASS -> DMESG-WARN +2

    igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
      fi-ivb-3770:        PASS -> DMESG-WARN +30

    igt@kms_cursor_legacy@basic-flip-after-cursor-varying-size:
      fi-ivb-3520m:       PASS -> DMESG-WARN +28

    igt@kms_cursor_legacy@basic-flip-before-cursor-atomic:
      fi-snb-2520m:       PASS -> DMESG-WARN +28

    igt@kms_flip@basic-flip-vs-wf_vblank:
      fi-snb-2600:        PASS -> DMESG-WARN +28

    igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
      fi-ivb-3770:        PASS -> DMESG-FAIL +6

    igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a:
      fi-ivb-3520m:       PASS -> DMESG-FAIL +6

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
      fi-whl-u:           PASS -> INCOMPLETE
      fi-cfl-8700k:       PASS -> INCOMPLETE
      fi-kbl-7560u:       PASS -> INCOMPLETE
      fi-kbl-r:           PASS -> INCOMPLETE
      fi-bdw-5557u:       PASS -> INCOMPLETE
      fi-hsw-peppy:       NOTRUN -> INCOMPLETE

    
    ==== Warnings ====

    igt@drv_selftest@live_evict:
      fi-kbl-x1275:       PASS -> SKIP +31

    igt@drv_selftest@live_gtt:
      fi-kbl-8809g:       PASS -> SKIP +31
      fi-kbl-guc:         PASS -> SKIP +30

    
== Known issues ==

  Here are the changes found in Trybot_2914 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_module_reload@basic-reload:
      fi-kbl-8809g:       PASS -> INCOMPLETE (fdo#103665)
      fi-kbl-guc:         PASS -> INCOMPLETE (fdo#106693)

    igt@gem_exec_suspend@basic-s4-devices:
      fi-byt-n2820:       PASS -> DMESG-WARN (fdo#106086)
      fi-byt-clapper:     PASS -> DMESG-WARN (fdo#107751) +1
      fi-byt-j1900:       PASS -> DMESG-WARN (fdo#106086)

    igt@kms_busy@basic-flip-a:
      fi-skl-guc:         PASS -> INCOMPLETE (fdo#106693)

    igt@kms_flip@basic-flip-vs-dpms:
      fi-ilk-650:         PASS -> DMESG-WARN (fdo#106387) +32

    igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
      fi-byt-clapper:     PASS -> FAIL (fdo#107362, fdo#103191)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
      fi-skl-6770hq:      PASS -> INCOMPLETE (fdo#104108)
      fi-cfl-guc:         PASS -> INCOMPLETE (fdo#106693)
      fi-snb-2520m:       PASS -> INCOMPLETE (fdo#103713)
      fi-byt-clapper:     PASS -> INCOMPLETE (fdo#102657)
      fi-kbl-7567u:       PASS -> INCOMPLETE (fdo#103665)
      fi-glk-dsi:         PASS -> INCOMPLETE (fdo#103359, k.org#198133)
      fi-bxt-j4205:       PASS -> INCOMPLETE (fdo#103927)
      fi-bsw-kefka:       PASS -> INCOMPLETE (fdo#105876)
      fi-hsw-4770:        PASS -> INCOMPLETE (fdo#103540)
      fi-bxt-dsi:         PASS -> INCOMPLETE (fdo#103927)
      fi-skl-6600u:       PASS -> INCOMPLETE (fdo#104108)
      fi-snb-2600:        PASS -> INCOMPLETE (fdo#105411)
      fi-skl-6260u:       PASS -> INCOMPLETE (fdo#104108)
      fi-skl-iommu:       PASS -> INCOMPLETE (fdo#104108)
      fi-cfl-s3:          PASS -> INCOMPLETE (k.org#199541, fdo#105524)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-ivb-3520m:       PASS -> INCOMPLETE (fdo#106220)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      fi-bsw-n3050:       PASS -> INCOMPLETE (fdo#105876)

    
    ==== Possible fixes ====

    igt@drv_selftest@live_guc:
      fi-kbl-guc:         DMESG-WARN (fdo#107258) -> SKIP

    igt@kms_frontbuffer_tracking@basic:
      fi-byt-clapper:     FAIL (fdo#103167) -> PASS

    igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a:
      fi-byt-clapper:     FAIL (fdo#107362) -> PASS

    
  fdo#102657 https://bugs.freedesktop.org/show_bug.cgi?id=102657
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
  fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#105524 https://bugs.freedesktop.org/show_bug.cgi?id=105524
  fdo#105876 https://bugs.freedesktop.org/show_bug.cgi?id=105876
  fdo#106086 https://bugs.freedesktop.org/show_bug.cgi?id=106086
  fdo#106220 https://bugs.freedesktop.org/show_bug.cgi?id=106220
  fdo#106387 https://bugs.freedesktop.org/show_bug.cgi?id=106387
  fdo#106693 https://bugs.freedesktop.org/show_bug.cgi?id=106693
  fdo#107258 https://bugs.freedesktop.org/show_bug.cgi?id=107258
  fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
  fdo#107751 https://bugs.freedesktop.org/show_bug.cgi?id=107751
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
  k.org#199541 https://bugzilla.kernel.org/show_bug.cgi?id=199541


== Participating hosts (46 -> 40) ==

  Additional (1): fi-hsw-peppy 
  Missing    (7): fi-hsw-4770r fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-glk-j4005 fi-pnv-d510 fi-icl-u 


== Build changes ==

    * Linux: CI_DRM_4828 -> Trybot_2914

  CI_DRM_4828: e03a83554b1f976d09b636e0cb386f747310a6d3 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4644: 0b59bb3231ab481959528c5c7b3a98762772e1b0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Trybot_2914: 80fa8d1ac82989d2c929175d7b93e31d8b3f3d16 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

80fa8d1ac829 drm/i915: Skip modeset for cdclk changes if possible
06a022d6bb9f drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled
3ec397fa7477 drm/i915: Move display HW state readout to early resume phase
e7c01bafbdfd drm/i915: Split resume time display HW readout and modeset
f44c5b4ca00c sound/hdac_hdmi: Make jack handling asynchronous