drm/i915: Handle pipe CRC around enabling/disabling pipe.

Submitted by Maarten Lankhorst on March 7, 2018, 8:17 a.m.

Details

Reviewer None
Submitted March 7, 2018, 8:17 a.m.
Last Updated March 8, 2018, 3:25 p.m.
Revision 6

Revisions

Patches download mbox

Tests

Series 39508v1 drm/i915: Handle pipe CRC around enabling/disabling pipe.
https://patchwork.freedesktop.org/api/1.0/series/39508/revisions/1/mbox/

fi-bdw-5557u failed to collect. IGT log at Patchwork_8256/fi-bdw-5557u/run0.log
fi-bdw-gvtdvm failed to collect. IGT log at Patchwork_8256/fi-bdw-gvtdvm/run0.log
fi-blb-e6850 failed to collect. IGT log at Patchwork_8256/fi-blb-e6850/run0.log
fi-bsw-n3050 failed to collect. IGT log at Patchwork_8256/fi-bsw-n3050/run0.log
fi-bwr-2160 failed to collect. IGT log at Patchwork_8256/fi-bwr-2160/run0.log
fi-bxt-dsi failed to collect. IGT log at Patchwork_8256/fi-bxt-dsi/run0.log
fi-bxt-j4205 failed to collect. IGT log at Patchwork_8256/fi-bxt-j4205/run0.log
fi-byt-j1900 failed to collect. IGT log at Patchwork_8256/fi-byt-j1900/run0.log
fi-byt-n2820 failed to collect. IGT log at Patchwork_8256/fi-byt-n2820/run0.log
fi-cfl-8700k failed to collect. IGT log at Patchwork_8256/fi-cfl-8700k/run0.log
fi-cfl-s2 failed to collect. IGT log at Patchwork_8256/fi-cfl-s2/run0.log
fi-elk-e7500 failed to collect. IGT log at Patchwork_8256/fi-elk-e7500/run0.log
fi-gdg-551 failed to collect. IGT log at Patchwork_8256/fi-gdg-551/run0.log
fi-glk-1 failed to collect. IGT log at Patchwork_8256/fi-glk-1/run0.log
fi-hsw-4770 failed to collect. IGT log at Patchwork_8256/fi-hsw-4770/run0.log
fi-ilk-650 failed to collect. IGT log at Patchwork_8256/fi-ilk-650/run0.log
fi-ivb-3520m failed to collect. IGT log at Patchwork_8256/fi-ivb-3520m/run0.log
fi-ivb-3770 failed to collect. IGT log at Patchwork_8256/fi-ivb-3770/run0.log
fi-kbl-7500u failed to collect. IGT log at Patchwork_8256/fi-kbl-7500u/run0.log
fi-kbl-7560u failed to collect. IGT log at Patchwork_8256/fi-kbl-7560u/run0.log
fi-kbl-7567u failed to collect. IGT log at Patchwork_8256/fi-kbl-7567u/run0.log
fi-kbl-r failed to collect. IGT log at Patchwork_8256/fi-kbl-r/run0.log
fi-pnv-d510 failed to collect. IGT log at Patchwork_8256/fi-pnv-d510/run0.log
fi-skl-6260u failed to collect. IGT log at Patchwork_8256/fi-skl-6260u/run0.log
fi-skl-6600u failed to collect. IGT log at Patchwork_8256/fi-skl-6600u/run0.log
fi-skl-6700hq failed to collect. IGT log at Patchwork_8256/fi-skl-6700hq/run0.log
fi-skl-6700k2 failed to collect. IGT log at Patchwork_8256/fi-skl-6700k2/run0.log
fi-skl-6770hq failed to collect. IGT log at Patchwork_8256/fi-skl-6770hq/run0.log
fi-skl-guc failed to collect. IGT log at Patchwork_8256/fi-skl-guc/run0.log
fi-snb-2520m failed to collect. IGT log at Patchwork_8256/fi-snb-2520m/run0.log
fi-snb-2600 failed to collect. IGT log at Patchwork_8256/fi-snb-2600/run0.log

8a4eb4556f66d7ab7ad512d5c3d239da8de6b750 drm-tip: 2018y-03m-06d-22h-59m-29s UTC integration manifest
111b6a4c5cd7 drm/i915: Handle pipe CRC around enabling/disabling pipe.
$ dim checkpatch origin/drm-tip
111b6a4c5cd7 drm/i915: Handle pipe CRC around enabling/disabling pipe.
---- Possible new issues:

Test kms_chv_cursor_fail:
        Subgroup pipe-a-128x128-bottom-edge:
                pass       -> INCOMPLETE (shard-hsw)
        Subgroup pipe-a-128x128-left-edge:
                pass       -> INCOMPLETE (shard-hsw)
        Subgroup pipe-a-128x128-right-edge:
                pass       -> INCOMPLETE (shard-hsw)
        Subgroup pipe-a-128x128-top-edge:
                pass       -> INCOMPLETE (shard-hsw)
        Subgroup pipe-a-256x256-left-edge:
                pass       -> INCOMPLETE (shard-hsw)
        Subgroup pipe-a-256x256-right-edge:
                pass       -> INCOMPLETE (shard-hsw)
        Subgroup pipe-a-256x256-top-edge:
                pass       -> INCOMPLETE (shard-hsw)
        Subgroup pipe-a-64x64-bottom-edge:
                pass       -> INCOMPLETE (shard-hsw)

---- Known issues:

Test gem_eio:
        Subgroup in-flight-external:
                pass       -> INCOMPLETE (shard-apl) fdo#105341
Test gem_softpin:
        Subgroup noreloc-s3:
                skip       -> PASS       (shard-snb) fdo#103375
Test kms_chv_cursor_fail:
        Subgroup pipe-a-64x64-top-edge:
                pass       -> INCOMPLETE (shard-hsw) fdo#105185 +9
Test kms_flip:
        Subgroup 2x-plain-flip-ts-check:
                fail       -> PASS       (shard-hsw) fdo#100368 +1
Test kms_frontbuffer_tracking:
        Subgroup fbc-suspend:
                pass       -> FAIL       (shard-apl) fdo#101623
Test kms_setmode:
        Subgroup basic:
                fail       -> PASS       (shard-apl) fdo#99912
Test perf:
        Subgroup polling:
                fail       -> PASS       (shard-hsw) fdo#102252 +1
Test pm_lpsp:
        Subgroup screens-disabled:
                fail       -> PASS       (shard-hsw) fdo#104941

fdo#105341 https://bugs.freedesktop.org/show_bug.cgi?id=105341
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#105185 https://bugs.freedesktop.org/show_bug.cgi?id=105185
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#104941 https://bugs.freedesktop.org/show_bug.cgi?id=104941

shard-apl        total:3381 pass:1780 dwarn:1   dfail:0   fail:7   skip:1591 time:11795s
shard-hsw        total:2949 pass:1515 dwarn:1   dfail:0   fail:0   skip:1420 time:8325s
shard-snb        total:3467 pass:1361 dwarn:4   dfail:0   fail:2   skip:2100 time:7038s
Blacklisted hosts:
shard-kbl        total:3377 pass:1898 dwarn:1   dfail:0   fail:8   skip:1468 time:8757s
$ dim sparse origin/drm-tip
Commit: drm/i915: Handle pipe CRC around enabling/disabling pipe.
Okay!

Patches download mbox

Tests

Series 39508v2 drm/i915: Handle pipe CRC around enabling/disabling pipe.
https://patchwork.freedesktop.org/api/1.0/series/39508/revisions/2/mbox/

---- Known issues:

Test prime_vgem:
        Subgroup basic-fence-flip:
                fail       -> PASS       (fi-ilk-650) fdo#104008

fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:423s
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:425s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:370s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:504s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:278s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:485s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:478s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:466s
fi-cfl-8700k     total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:405s
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:578s
fi-cfl-u         total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:502s
fi-elk-e7500     total:288  pass:229  dwarn:0   dfail:0   fail:0   skip:59  time:415s
fi-gdg-551       total:288  pass:179  dwarn:0   dfail:0   fail:1   skip:108 time:290s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:515s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:395s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:411s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:458s
fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:425s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:466s
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:460s
fi-kbl-r         total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:510s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:584s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:434s
fi-skl-6600u     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:521s
fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:533s
fi-skl-6700k2    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:507s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:477s
fi-skl-guc       total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:419s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:426s
fi-snb-2520m     total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:522s
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:394s

8a4eb4556f66d7ab7ad512d5c3d239da8de6b750 drm-tip: 2018y-03m-06d-22h-59m-29s UTC integration manifest
f64f76ced1a4 drm/i915: Handle pipe CRC around enabling/disabling pipe.
$ dim checkpatch origin/drm-tip
f64f76ced1a4 drm/i915: Handle pipe CRC around enabling/disabling pipe.
-:56: WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#56: 
- Don't try to apply CRC workaround when enabling pipe, it should already be enabled.

-:108: CHECK: Prefer kernel type 'u32' over 'uint32_t'
#108: FILE: drivers/gpu/drm/i915/intel_pipe_crc.c:572:
+				uint32_t *val,

-:119: CHECK: Alignment should match open parenthesis
#119: FILE: drivers/gpu/drm/i915/intel_pipe_crc.c:587:
+		if (set_wa && (IS_HASWELL(dev_priv) ||
 		     IS_BROADWELL(dev_priv)) && pipe == PIPE_A)

-:137: WARNING: line over 80 characters
#137: FILE: drivers/gpu/drm/i915/intel_pipe_crc.c:616:
+		return ivb_pipe_crc_ctl_reg(dev_priv, pipe, source, val, set_wa);

-:185: WARNING: line over 80 characters
#185: FILE: drivers/gpu/drm/i915/intel_pipe_crc.c:977:
+	if (get_new_crc_ctl_reg(dev_priv, crtc->index, &source, &val, false) < 0)

total: 0 errors, 3 warnings, 2 checks, 114 lines checked
---- Known issues:

Test gem_eio:
        Subgroup in-flight-contexts:
                pass       -> INCOMPLETE (shard-apl) fdo#105341 +1
Test kms_chv_cursor_fail:
        Subgroup pipe-b-256x256-top-edge:
                dmesg-warn -> PASS       (shard-snb) fdo#105185 +1
Test kms_cursor_crc:
        Subgroup cursor-64x64-suspend:
                pass       -> INCOMPLETE (shard-hsw) fdo#103540
Test kms_flip:
        Subgroup plain-flip-fb-recreate:
                pass       -> FAIL       (shard-hsw) fdo#100368 +2
Test kms_frontbuffer_tracking:
        Subgroup fbc-suspend:
                pass       -> FAIL       (shard-apl) fdo#101623
Test kms_rotation_crc:
        Subgroup primary-rotation-180:
                fail       -> PASS       (shard-snb) fdo#103925
Test kms_setmode:
        Subgroup basic:
                fail       -> PASS       (shard-apl) fdo#99912
Test perf:
        Subgroup polling:
                fail       -> PASS       (shard-hsw) fdo#102252 +1

fdo#105341 https://bugs.freedesktop.org/show_bug.cgi?id=105341
fdo#105185 https://bugs.freedesktop.org/show_bug.cgi?id=105185
fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252

shard-apl        total:3295 pass:1735 dwarn:1   dfail:0   fail:6   skip:1550 time:11368s
shard-hsw        total:3394 pass:1736 dwarn:1   dfail:0   fail:3   skip:1652 time:11380s
shard-snb        total:3467 pass:1363 dwarn:2   dfail:0   fail:1   skip:2101 time:7046s
Blacklisted hosts:
shard-kbl        total:3381 pass:1883 dwarn:14  dfail:1   fail:9   skip:1473 time:8857s
$ dim sparse origin/drm-tip
Commit: drm/i915: Handle pipe CRC around enabling/disabling pipe.
Okay!

Patches download mbox

Tests

Series 39508v3 drm/i915: Handle pipe CRC around enabling/disabling pipe.
https://patchwork.freedesktop.org/api/1.0/series/39508/revisions/3/mbox/

---- Known issues:

Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-c:
                incomplete -> PASS       (fi-bxt-dsi) fdo#103927

fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:421s
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:423s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:369s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:498s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:277s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:492s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:492s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:478s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:467s
fi-cfl-8700k     total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:405s
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:582s
fi-cfl-u         total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:505s
fi-elk-e7500     total:288  pass:229  dwarn:0   dfail:0   fail:0   skip:59  time:415s
fi-gdg-551       total:288  pass:179  dwarn:0   dfail:0   fail:1   skip:108 time:289s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:516s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:397s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:417s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:458s
fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:418s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:471s
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:460s
fi-kbl-r         total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:509s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:587s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:428s
fi-skl-6600u     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:519s
fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:535s
fi-skl-6700k2    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:494s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:488s
fi-skl-guc       total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:430s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:425s
fi-snb-2520m     total:245  pass:211  dwarn:0   dfail:0   fail:0   skip:33 
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:389s

36e67bf18117a31df69df314e9e7f3709c37c9c8 drm-tip: 2018y-03m-07d-13h-36m-57s UTC integration manifest
6bf990dda548 drm/i915: Handle pipe CRC around enabling/disabling pipe.
$ dim checkpatch origin/drm-tip
6bf990dda548 drm/i915: Handle pipe CRC around enabling/disabling pipe.
-:56: WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#56: 
- Don't try to apply CRC workaround when enabling pipe, it should already be enabled.

-:88: WARNING: line over 80 characters
#88: FILE: drivers/gpu/drm/i915/intel_display.c:12335:
+			 * We need to disable pipe CRC before disabling the pipe,

-:127: CHECK: Prefer kernel type 'u32' over 'uint32_t'
#127: FILE: drivers/gpu/drm/i915/intel_pipe_crc.c:572:
+				uint32_t *val,

-:138: CHECK: Alignment should match open parenthesis
#138: FILE: drivers/gpu/drm/i915/intel_pipe_crc.c:587:
+		if (set_wa && (IS_HASWELL(dev_priv) ||
 		     IS_BROADWELL(dev_priv)) && pipe == PIPE_A)

-:156: WARNING: line over 80 characters
#156: FILE: drivers/gpu/drm/i915/intel_pipe_crc.c:616:
+		return ivb_pipe_crc_ctl_reg(dev_priv, pipe, source, val, set_wa);

-:205: WARNING: line over 80 characters
#205: FILE: drivers/gpu/drm/i915/intel_pipe_crc.c:978:
+	if (get_new_crc_ctl_reg(dev_priv, crtc->index, &source, &val, false) < 0)

total: 0 errors, 4 warnings, 2 checks, 130 lines checked
---- Possible new issues:

Test kms_busy:
        Subgroup extended-pageflip-hang-oldfb-render-a:
                skip       -> PASS       (shard-snb)
Test kms_cursor_legacy:
        Subgroup cursorb-vs-flipa-varying-size:
                dmesg-warn -> PASS       (shard-hsw)
Test kms_vblank:
        Subgroup pipe-a-ts-continuation-modeset:
                skip       -> PASS       (shard-snb)
        Subgroup pipe-a-wait-busy-hang:
                skip       -> PASS       (shard-snb)
        Subgroup pipe-b-wait-idle:
                dmesg-warn -> PASS       (shard-hsw)

---- Known issues:

Test gem_eio:
        Subgroup in-flight-contexts:
                incomplete -> PASS       (shard-apl) fdo#105341 +1
Test gem_softpin:
        Subgroup noreloc-s3:
                skip       -> PASS       (shard-snb) fdo#103375
Test kms_chv_cursor_fail:
        Subgroup pipe-b-128x128-right-edge:
                pass       -> DMESG-WARN (shard-snb) fdo#105185 +2
Test kms_flip:
        Subgroup dpms-vs-vblank-race:
                pass       -> FAIL       (shard-hsw) fdo#103060 +1
        Subgroup plain-flip-fb-recreate-interruptible:
                fail       -> PASS       (shard-hsw) fdo#100368
Test kms_frontbuffer_tracking:
        Subgroup fbc-suspend:
                fail       -> PASS       (shard-apl) fdo#101623
Test pm_lpsp:
        Subgroup screens-disabled:
                fail       -> PASS       (shard-hsw) fdo#104941

fdo#105341 https://bugs.freedesktop.org/show_bug.cgi?id=105341
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#105185 https://bugs.freedesktop.org/show_bug.cgi?id=105185
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#104941 https://bugs.freedesktop.org/show_bug.cgi?id=104941

shard-apl        total:3381 pass:1780 dwarn:1   dfail:0   fail:7   skip:1591 time:11799s
shard-hsw        total:3467 pass:1771 dwarn:1   dfail:0   fail:3   skip:1691 time:11917s
shard-snb        total:3467 pass:1363 dwarn:2   dfail:0   fail:2   skip:2100 time:7055s
Blacklisted hosts:
shard-kbl        total:3308 pass:1857 dwarn:1   dfail:0   fail:8   skip:1440 time:8612s
$ dim sparse origin/drm-tip
Commit: drm/i915: Handle pipe CRC around enabling/disabling pipe.
Okay!

Patches download mbox

Tests

Series 39508v4 drm/i915: Handle pipe CRC around enabling/disabling pipe.
https://patchwork.freedesktop.org/api/1.0/series/39508/revisions/4/mbox/

---- Possible new issues:

Test debugfs_test:
        Subgroup read_all_entries:
                pass       -> FAIL       (fi-bdw-5557u)
                pass       -> FAIL       (fi-bdw-gvtdvm)
                pass       -> FAIL       (fi-blb-e6850)
                pass       -> FAIL       (fi-bsw-n3050)
                pass       -> FAIL       (fi-bwr-2160)
                pass       -> FAIL       (fi-bxt-dsi)
                pass       -> FAIL       (fi-bxt-j4205)
                pass       -> FAIL       (fi-byt-j1900)
                pass       -> FAIL       (fi-byt-n2820)
                pass       -> FAIL       (fi-cfl-8700k)
                pass       -> FAIL       (fi-cfl-s2)
                pass       -> FAIL       (fi-cfl-u)
                pass       -> FAIL       (fi-gdg-551)
                pass       -> FAIL       (fi-glk-1)
                pass       -> FAIL       (fi-hsw-4770)
                pass       -> FAIL       (fi-ilk-650)
                pass       -> FAIL       (fi-ivb-3520m)
                pass       -> FAIL       (fi-ivb-3770)
                pass       -> FAIL       (fi-kbl-7500u)
                pass       -> FAIL       (fi-kbl-7567u)
                pass       -> FAIL       (fi-kbl-r)
                pass       -> FAIL       (fi-pnv-d510)
                pass       -> FAIL       (fi-skl-6260u)
                pass       -> FAIL       (fi-skl-6600u)
                pass       -> FAIL       (fi-skl-6700hq)
                pass       -> FAIL       (fi-skl-6700k2)
                pass       -> FAIL       (fi-skl-6770hq)
                pass       -> FAIL       (fi-skl-guc)
                pass       -> FAIL       (fi-skl-gvtdvm)
                pass       -> FAIL       (fi-snb-2600)
Test kms_frontbuffer_tracking:
        Subgroup basic:
                pass       -> INCOMPLETE (fi-bdw-5557u)
                pass       -> INCOMPLETE (fi-bdw-gvtdvm)
                pass       -> INCOMPLETE (fi-bsw-n3050)
                pass       -> INCOMPLETE (fi-bxt-dsi)
                pass       -> INCOMPLETE (fi-bxt-j4205)
                pass       -> INCOMPLETE (fi-byt-j1900)
                pass       -> INCOMPLETE (fi-byt-n2820)
                pass       -> INCOMPLETE (fi-cfl-8700k)
                pass       -> INCOMPLETE (fi-cfl-s2)
                pass       -> INCOMPLETE (fi-cfl-u)
                pass       -> INCOMPLETE (fi-hsw-4770)
                skip       -> INCOMPLETE (fi-ilk-650)
                pass       -> INCOMPLETE (fi-ivb-3520m)
                pass       -> INCOMPLETE (fi-ivb-3770)
                pass       -> INCOMPLETE (fi-kbl-7500u)
                pass       -> INCOMPLETE (fi-kbl-7567u)
                pass       -> INCOMPLETE (fi-kbl-r)
                pass       -> INCOMPLETE (fi-skl-6260u)
                pass       -> INCOMPLETE (fi-skl-6600u)
                pass       -> INCOMPLETE (fi-skl-6700hq)
                pass       -> INCOMPLETE (fi-skl-6700k2)
                pass       -> INCOMPLETE (fi-skl-6770hq)
                pass       -> INCOMPLETE (fi-skl-guc)
                pass       -> INCOMPLETE (fi-skl-gvtdvm)
                pass       -> INCOMPLETE (fi-snb-2520m)
                pass       -> INCOMPLETE (fi-snb-2600)
Test kms_pipe_crc_basic:
        Subgroup hang-read-crc-pipe-a:
                pass       -> INCOMPLETE (fi-blb-e6850)
                pass       -> INCOMPLETE (fi-bwr-2160)
                pass       -> INCOMPLETE (fi-gdg-551)
                pass       -> INCOMPLETE (fi-pnv-d510)

---- Known issues:

Test debugfs_test:
        Subgroup read_all_entries:
                pass       -> FAIL       (fi-elk-e7500) fdo#103989 +1
                pass       -> FAIL       (fi-snb-2520m) fdo#103713
Test kms_frontbuffer_tracking:
        Subgroup basic:
                pass       -> INCOMPLETE (fi-glk-1) fdo#103167

fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167

fi-bdw-5557u     total:224  pass:205  dwarn:0   dfail:0   fail:1   skip:17 
fi-bdw-gvtdvm    total:224  pass:204  dwarn:0   dfail:0   fail:1   skip:18 
fi-blb-e6850     total:229  pass:175  dwarn:1   dfail:0   fail:1   skip:51 
fi-bsw-n3050     total:224  pass:193  dwarn:0   dfail:0   fail:1   skip:29 
fi-bwr-2160      total:229  pass:143  dwarn:0   dfail:0   fail:1   skip:84 
fi-bxt-dsi       total:224  pass:196  dwarn:0   dfail:0   fail:1   skip:26 
fi-bxt-j4205     total:224  pass:197  dwarn:0   dfail:0   fail:1   skip:25 
fi-byt-j1900     total:224  pass:197  dwarn:0   dfail:0   fail:1   skip:25 
fi-byt-n2820     total:224  pass:193  dwarn:0   dfail:0   fail:1   skip:29 
fi-cfl-8700k     total:224  pass:198  dwarn:0   dfail:0   fail:1   skip:24 
fi-cfl-s2        total:224  pass:198  dwarn:0   dfail:0   fail:1   skip:24 
fi-cfl-u         total:224  pass:198  dwarn:0   dfail:0   fail:1   skip:24 
fi-elk-e7500     total:224  pass:177  dwarn:0   dfail:0   fail:1   skip:45 
fi-gdg-551       total:229  pass:139  dwarn:0   dfail:0   fail:2   skip:87 
WARNING: Long output truncated

fc93d196b8e428bc5a186bde78f412aa30081f38 drm-tip: 2018y-03m-07d-23h-55m-21s UTC integration manifest
1c4f2d239e49 drm/i915: Handle pipe CRC around enabling/disabling pipe.
$ dim checkpatch origin/drm-tip
1c4f2d239e49 drm/i915: Handle pipe CRC around enabling/disabling pipe.
-:56: WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#56: 
- Don't try to apply CRC workaround when enabling pipe, it should already be enabled.

-:103: WARNING: line over 80 characters
#103: FILE: drivers/gpu/drm/i915/intel_display.c:12335:
+			 * We need to disable pipe CRC before disabling the pipe,

-:142: CHECK: Prefer kernel type 'u32' over 'uint32_t'
#142: FILE: drivers/gpu/drm/i915/intel_pipe_crc.c:572:
+				uint32_t *val,

-:153: CHECK: Alignment should match open parenthesis
#153: FILE: drivers/gpu/drm/i915/intel_pipe_crc.c:587:
+		if (set_wa && (IS_HASWELL(dev_priv) ||
 		     IS_BROADWELL(dev_priv)) && pipe == PIPE_A)

-:171: WARNING: line over 80 characters
#171: FILE: drivers/gpu/drm/i915/intel_pipe_crc.c:616:
+		return ivb_pipe_crc_ctl_reg(dev_priv, pipe, source, val, set_wa);

-:221: WARNING: line over 80 characters
#221: FILE: drivers/gpu/drm/i915/intel_pipe_crc.c:976:
+	if (get_new_crc_ctl_reg(dev_priv, crtc->index, &pipe_crc->source, &val, false) < 0)

total: 0 errors, 4 warnings, 2 checks, 148 lines checked
$ dim sparse origin/drm-tip
Commit: drm/i915: Handle pipe CRC around enabling/disabling pipe.
Okay!

Patches download mbox

Tests

Series 39508v5 drm/i915: Handle pipe CRC around enabling/disabling pipe.
https://patchwork.freedesktop.org/api/1.0/series/39508/revisions/5/mbox/

---- Possible new issues:

Test debugfs_test:
        Subgroup read_all_entries:
                pass       -> FAIL       (fi-bdw-5557u)
                pass       -> FAIL       (fi-bdw-gvtdvm)
                pass       -> FAIL       (fi-blb-e6850)
                pass       -> FAIL       (fi-bsw-n3050)
                pass       -> FAIL       (fi-bwr-2160)
                pass       -> FAIL       (fi-bxt-dsi)
                pass       -> FAIL       (fi-bxt-j4205)
                pass       -> FAIL       (fi-byt-j1900)
                pass       -> FAIL       (fi-byt-n2820)
                pass       -> FAIL       (fi-cfl-8700k)
                pass       -> FAIL       (fi-cfl-s2)
                pass       -> FAIL       (fi-cfl-u)
                pass       -> FAIL       (fi-gdg-551)
                pass       -> FAIL       (fi-glk-1)
                pass       -> FAIL       (fi-hsw-4770)
                pass       -> FAIL       (fi-ilk-650)
                pass       -> FAIL       (fi-ivb-3520m)
                pass       -> FAIL       (fi-ivb-3770)
                pass       -> FAIL       (fi-kbl-7500u)
                pass       -> FAIL       (fi-kbl-7567u)
                pass       -> FAIL       (fi-kbl-r)
                pass       -> FAIL       (fi-pnv-d510)
                pass       -> FAIL       (fi-skl-6260u)
                pass       -> FAIL       (fi-skl-6600u)
                pass       -> FAIL       (fi-skl-6700hq)
                pass       -> FAIL       (fi-skl-6700k2)
                pass       -> FAIL       (fi-skl-6770hq)
                pass       -> FAIL       (fi-skl-guc)
                pass       -> FAIL       (fi-skl-gvtdvm)
                pass       -> FAIL       (fi-snb-2600)
Test kms_frontbuffer_tracking:
        Subgroup basic:
                pass       -> INCOMPLETE (fi-bdw-5557u)
                pass       -> INCOMPLETE (fi-bdw-gvtdvm)
                pass       -> INCOMPLETE (fi-bsw-n3050)
                pass       -> INCOMPLETE (fi-bxt-dsi)
                pass       -> INCOMPLETE (fi-bxt-j4205)
                pass       -> INCOMPLETE (fi-byt-j1900)
                pass       -> INCOMPLETE (fi-byt-n2820)
                pass       -> INCOMPLETE (fi-cfl-8700k)
                pass       -> INCOMPLETE (fi-cfl-s2)
                pass       -> INCOMPLETE (fi-cfl-u)
                pass       -> INCOMPLETE (fi-hsw-4770)
                skip       -> INCOMPLETE (fi-ilk-650)
                pass       -> INCOMPLETE (fi-ivb-3520m)
                pass       -> INCOMPLETE (fi-ivb-3770)
                pass       -> INCOMPLETE (fi-kbl-7500u)
                pass       -> INCOMPLETE (fi-kbl-7567u)
                pass       -> INCOMPLETE (fi-kbl-r)
                pass       -> INCOMPLETE (fi-skl-6260u)
                pass       -> INCOMPLETE (fi-skl-6600u)
                pass       -> INCOMPLETE (fi-skl-6700hq)
                pass       -> INCOMPLETE (fi-skl-6700k2)
                pass       -> INCOMPLETE (fi-skl-6770hq)
                pass       -> INCOMPLETE (fi-skl-guc)
                pass       -> INCOMPLETE (fi-skl-gvtdvm)
                pass       -> INCOMPLETE (fi-snb-2520m)
                pass       -> INCOMPLETE (fi-snb-2600)
Test kms_pipe_crc_basic:
        Subgroup hang-read-crc-pipe-a:
                pass       -> INCOMPLETE (fi-blb-e6850)
                pass       -> INCOMPLETE (fi-bwr-2160)
                pass       -> INCOMPLETE (fi-gdg-551)
                pass       -> INCOMPLETE (fi-pnv-d510)

---- Known issues:

Test debugfs_test:
        Subgroup read_all_entries:
                pass       -> FAIL       (fi-elk-e7500) fdo#103989 +1
                pass       -> FAIL       (fi-snb-2520m) fdo#103713
Test kms_frontbuffer_tracking:
        Subgroup basic:
                pass       -> INCOMPLETE (fi-glk-1) fdo#103167

fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167

fi-bdw-5557u     total:224  pass:205  dwarn:0   dfail:0   fail:1   skip:17 
fi-bdw-gvtdvm    total:224  pass:204  dwarn:0   dfail:0   fail:1   skip:18 
fi-blb-e6850     total:229  pass:175  dwarn:1   dfail:0   fail:1   skip:51 
fi-bsw-n3050     total:224  pass:193  dwarn:0   dfail:0   fail:1   skip:29 
fi-bwr-2160      total:229  pass:143  dwarn:0   dfail:0   fail:1   skip:84 
fi-bxt-dsi       total:224  pass:196  dwarn:0   dfail:0   fail:1   skip:26 
fi-bxt-j4205     total:224  pass:197  dwarn:0   dfail:0   fail:1   skip:25 
fi-byt-j1900     total:224  pass:197  dwarn:0   dfail:0   fail:1   skip:25 
fi-byt-n2820     total:224  pass:193  dwarn:0   dfail:0   fail:1   skip:29 
fi-cfl-8700k     total:224  pass:198  dwarn:0   dfail:0   fail:1   skip:24 
fi-cfl-s2        total:224  pass:198  dwarn:0   dfail:0   fail:1   skip:24 
fi-cfl-u         total:224  pass:198  dwarn:0   dfail:0   fail:1   skip:24 
fi-elk-e7500     total:224  pass:177  dwarn:0   dfail:0   fail:1   skip:45 
fi-gdg-551       total:229  pass:139  dwarn:0   dfail:0   fail:2   skip:87 
WARNING: Long output truncated

fc93d196b8e428bc5a186bde78f412aa30081f38 drm-tip: 2018y-03m-07d-23h-55m-21s UTC integration manifest
2a02e9f194b9 drm/i915: Handle pipe CRC around enabling/disabling pipe.
$ dim checkpatch origin/drm-tip
2a02e9f194b9 drm/i915: Handle pipe CRC around enabling/disabling pipe.
-:56: WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#56: 
- Don't try to apply CRC workaround when enabling pipe, it should already be enabled.

-:103: WARNING: line over 80 characters
#103: FILE: drivers/gpu/drm/i915/intel_display.c:12335:
+			 * We need to disable pipe CRC before disabling the pipe,

-:142: CHECK: Prefer kernel type 'u32' over 'uint32_t'
#142: FILE: drivers/gpu/drm/i915/intel_pipe_crc.c:572:
+				uint32_t *val,

-:153: CHECK: Alignment should match open parenthesis
#153: FILE: drivers/gpu/drm/i915/intel_pipe_crc.c:587:
+		if (set_wa && (IS_HASWELL(dev_priv) ||
 		     IS_BROADWELL(dev_priv)) && pipe == PIPE_A)

-:171: WARNING: line over 80 characters
#171: FILE: drivers/gpu/drm/i915/intel_pipe_crc.c:616:
+		return ivb_pipe_crc_ctl_reg(dev_priv, pipe, source, val, set_wa);

-:221: WARNING: line over 80 characters
#221: FILE: drivers/gpu/drm/i915/intel_pipe_crc.c:976:
+	if (get_new_crc_ctl_reg(dev_priv, crtc->index, &pipe_crc->source, &val, false) < 0)

total: 0 errors, 4 warnings, 2 checks, 148 lines checked
$ dim sparse origin/drm-tip
Commit: drm/i915: Handle pipe CRC around enabling/disabling pipe.
Okay!

Patches download mbox

Tests

Series 39508v6 drm/i915: Handle pipe CRC around enabling/disabling pipe.
https://patchwork.freedesktop.org/api/1.0/series/39508/revisions/6/mbox/

---- Known issues:

Test prime_vgem:
        Subgroup basic-fence-flip:
                fail       -> PASS       (fi-ilk-650) fdo#104008

fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:424s
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:426s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:372s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:502s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:286s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:494s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:495s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:486s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:471s
fi-cfl-8700k     total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:403s
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:583s
fi-elk-e7500     total:288  pass:229  dwarn:0   dfail:0   fail:0   skip:59  time:416s
fi-gdg-551       total:288  pass:179  dwarn:0   dfail:0   fail:1   skip:108 time:294s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:520s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:399s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:412s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:462s
fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:418s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:469s
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:461s
fi-kbl-r         total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:510s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:591s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:427s
fi-skl-6600u     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:524s
fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:534s
fi-skl-6700k2    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:499s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:481s
fi-skl-guc       total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:423s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:428s
fi-snb-2520m     total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:524s
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:402s
Blacklisted hosts:
fi-cnl-drrs      total:288  pass:257  dwarn:3   dfail:0   fail:0   skip:19  time:516s
fi-cfl-u failed to connect after reboot

e4a2b905cbe1a129e1252b6f80a97add0dfbff40 drm-tip: 2018y-03m-08d-10h-27m-13s UTC integration manifest
fb8d3205c6d9 drm/i915: Handle pipe CRC around enabling/disabling pipe.
$ dim checkpatch origin/drm-tip
fb8d3205c6d9 drm/i915: Handle pipe CRC around enabling/disabling pipe.
-:56: WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#56: 
- Don't try to apply CRC workaround when enabling pipe, it should already be enabled.

-:114: WARNING: line over 80 characters
#114: FILE: drivers/gpu/drm/i915/intel_display.c:12335:
+			 * We need to disable pipe CRC before disabling the pipe,

-:153: CHECK: Prefer kernel type 'u32' over 'uint32_t'
#153: FILE: drivers/gpu/drm/i915/intel_pipe_crc.c:572:
+				uint32_t *val,

-:164: CHECK: Alignment should match open parenthesis
#164: FILE: drivers/gpu/drm/i915/intel_pipe_crc.c:587:
+		if (set_wa && (IS_HASWELL(dev_priv) ||
 		     IS_BROADWELL(dev_priv)) && pipe == PIPE_A)

-:182: WARNING: line over 80 characters
#182: FILE: drivers/gpu/drm/i915/intel_pipe_crc.c:616:
+		return ivb_pipe_crc_ctl_reg(dev_priv, pipe, source, val, set_wa);

-:232: WARNING: line over 80 characters
#232: FILE: drivers/gpu/drm/i915/intel_pipe_crc.c:976:
+	if (get_new_crc_ctl_reg(dev_priv, crtc->index, &pipe_crc->source, &val, false) < 0)

total: 0 errors, 4 warnings, 2 checks, 156 lines checked
---- Known issues:

Test gem_eio:
        Subgroup in-flight-contexts:
                incomplete -> PASS       (shard-apl) fdo#105341
Test gem_softpin:
        Subgroup noreloc-s3:
                skip       -> PASS       (shard-snb) fdo#103375
Test kms_chv_cursor_fail:
        Subgroup pipe-b-256x256-bottom-edge:
                dmesg-warn -> PASS       (shard-snb) fdo#105185
Test kms_flip:
        Subgroup flip-vs-expired-vblank:
                fail       -> PASS       (shard-hsw) fdo#102887
Test kms_frontbuffer_tracking:
        Subgroup fbc-suspend:
                fail       -> PASS       (shard-apl) fdo#101623

fdo#105341 https://bugs.freedesktop.org/show_bug.cgi?id=105341
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#105185 https://bugs.freedesktop.org/show_bug.cgi?id=105185
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623

shard-apl        total:3467 pass:1825 dwarn:1   dfail:0   fail:8   skip:1632 time:12544s
shard-hsw        total:3467 pass:1773 dwarn:1   dfail:0   fail:1   skip:1691 time:11906s
shard-snb        total:3467 pass:1364 dwarn:1   dfail:0   fail:2   skip:2100 time:7075s
Blacklisted hosts:
shard-kbl        total:3381 pass:1900 dwarn:1   dfail:0   fail:9   skip:1470 time:9172s
$ dim sparse origin/drm-tip
Commit: drm/i915: Handle pipe CRC around enabling/disabling pipe.
Okay!