drm/i915: Some plane init cleanups

Submitted by Ville Syrjälä on March 5, 2018, 4:50 p.m.

Details

Reviewer None
Submitted March 5, 2018, 4:50 p.m.
Last Updated March 29, 2018, 5:15 p.m.
Revision 2

Revisions

Patches download mbox

Tests

Series 39390v1 drm/i915: Some plane init cleanups
https://patchwork.freedesktop.org/api/1.0/series/39390/revisions/1/mbox/

---- Known issues:

Test gem_mmap_gtt:
        Subgroup basic-small-bo-tiledx:
                pass       -> FAIL       (fi-gdg-551) fdo#102575

fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575

fi-bdw-5557u     total:285  pass:264  dwarn:0   dfail:0   fail:0   skip:21  time:429s
fi-bdw-gvtdvm    total:285  pass:261  dwarn:0   dfail:0   fail:0   skip:24  time:443s
fi-blb-e6850     total:285  pass:220  dwarn:1   dfail:0   fail:0   skip:64  time:381s
fi-bsw-n3050     total:285  pass:239  dwarn:0   dfail:0   fail:0   skip:46  time:537s
fi-bwr-2160      total:285  pass:180  dwarn:0   dfail:0   fail:0   skip:105 time:297s
fi-bxt-dsi       total:285  pass:255  dwarn:0   dfail:0   fail:0   skip:30  time:511s
fi-bxt-j4205     total:285  pass:256  dwarn:0   dfail:0   fail:0   skip:29  time:508s
fi-byt-j1900     total:285  pass:250  dwarn:0   dfail:0   fail:0   skip:35  time:517s
fi-byt-n2820     total:285  pass:246  dwarn:0   dfail:0   fail:0   skip:39  time:502s
fi-cfl-8700k     total:285  pass:257  dwarn:0   dfail:0   fail:0   skip:28  time:412s
fi-cfl-s2        total:285  pass:259  dwarn:0   dfail:0   fail:0   skip:26  time:582s
fi-cfl-u         total:285  pass:259  dwarn:0   dfail:0   fail:0   skip:26  time:511s
fi-cnl-drrs      total:285  pass:254  dwarn:3   dfail:0   fail:0   skip:28  time:520s
fi-cnl-y3        total:285  pass:259  dwarn:0   dfail:0   fail:0   skip:26  time:588s
fi-elk-e7500     total:285  pass:225  dwarn:1   dfail:0   fail:0   skip:59  time:420s
fi-gdg-551       total:285  pass:176  dwarn:0   dfail:0   fail:1   skip:108 time:318s
fi-glk-1         total:285  pass:257  dwarn:0   dfail:0   fail:0   skip:28  time:539s
fi-hsw-4770      total:285  pass:258  dwarn:0   dfail:0   fail:0   skip:27  time:402s
fi-ilk-650       total:285  pass:225  dwarn:0   dfail:0   fail:0   skip:60  time:419s
fi-ivb-3520m     total:285  pass:256  dwarn:0   dfail:0   fail:0   skip:29  time:474s
fi-ivb-3770      total:285  pass:252  dwarn:0   dfail:0   fail:0   skip:33  time:428s
fi-kbl-7500u     total:285  pass:260  dwarn:1   dfail:0   fail:0   skip:24  time:476s
fi-kbl-7567u     total:285  pass:265  dwarn:0   dfail:0   fail:0   skip:20  time:468s
fi-kbl-r         total:285  pass:258  dwarn:0   dfail:0   fail:0   skip:27  time:514s
fi-pnv-d510      total:285  pass:219  dwarn:1   dfail:0   fail:0   skip:65  time:660s
fi-skl-6260u     total:285  pass:265  dwarn:0   dfail:0   fail:0   skip:20  time:441s
fi-skl-6600u     total:285  pass:258  dwarn:0   dfail:0   fail:0   skip:27  time:533s
fi-skl-6700hq    total:285  pass:259  dwarn:0   dfail:0   fail:0   skip:26  time:540s
fi-skl-6700k2    total:285  pass:261  dwarn:0   dfail:0   fail:0   skip:24  time:506s
fi-skl-6770hq    total:285  pass:265  dwarn:0   dfail:0   fail:0   skip:20  time:496s
fi-skl-guc       total:285  pass:257  dwarn:0   dfail:0   fail:0   skip:28  time:430s
fi-skl-gvtdvm    total:285  pass:262  dwarn:0   dfail:0   fail:0   skip:23  time:445s
fi-snb-2520m     total:285  pass:245  dwarn:0   dfail:0   fail:0   skip:40  time:585s
fi-snb-2600      total:285  pass:245  dwarn:0   dfail:0   fail:0   skip:40  time:403s

fa73baa35269b86a26e10f36bc35d3b657e2e932 drm-tip: 2018y-03m-16d-19h-43m-50s UTC integration manifest
c16c5119201d drm/i915: s/intel_plane/plane/ in sprite init
621e61d4d148 drm/i915: Extract skl_universal_plane_init()
07a529e748a6 drm/i915: Introduce intel_plane_alloc()
adb0d9a61540 drm/i915: Move plane_state->scaler_id initialization into intel_create_plane_state()
e4840616c794 drm/i915: Add missing pixel formats for skl+ "sprites"
09c5127f3012 drm/i915: Disallow plane scaling with specific pixel formats
a1bc8e641416 drm/i915: Allow horizontal mirroring for cnl+ "sprite" planes
5a5b624bd424 drm/i915: Don't populate plane->i9xx_plane for sprites
7abb2135b286 drm/i915: Populate possible_crtcs for primary/cursor planes
d99beb287193 drm/i915: Fix tabs vs. spaces
a7b37a2a81eb drm/i915: Constify intel_plane_funcs
$ dim checkpatch origin/drm-tip
a7b37a2a81eb drm/i915: Constify intel_plane_funcs
d99beb287193 drm/i915: Fix tabs vs. spaces
7abb2135b286 drm/i915: Populate possible_crtcs for primary/cursor planes
5a5b624bd424 drm/i915: Don't populate plane->i9xx_plane for sprites
a1bc8e641416 drm/i915: Allow horizontal mirroring for cnl+ "sprite" planes
09c5127f3012 drm/i915: Disallow plane scaling with specific pixel formats
e4840616c794 drm/i915: Add missing pixel formats for skl+ "sprites"
adb0d9a61540 drm/i915: Move plane_state->scaler_id initialization into intel_create_plane_state()
07a529e748a6 drm/i915: Introduce intel_plane_alloc()
621e61d4d148 drm/i915: Extract skl_universal_plane_init()
c16c5119201d drm/i915: s/intel_plane/plane/ in sprite init
---- Possible new issues:

Test kms_fbcon_fbt:
        Subgroup fbc:
                pass       -> FAIL       (shard-apl)
        Subgroup fbc-suspend:
                pass       -> FAIL       (shard-apl)
Test kms_frontbuffer_tracking:
        Subgroup fbc-1p-indfb-fliptrack:
                pass       -> FAIL       (shard-apl)
        Subgroup fbc-1p-offscren-pri-indfb-draw-blt:
                pass       -> FAIL       (shard-apl)
        Subgroup fbc-1p-offscren-pri-indfb-draw-mmap-cpu:
                pass       -> FAIL       (shard-apl)
        Subgroup fbc-1p-primscrn-cur-indfb-draw-render:
                pass       -> FAIL       (shard-apl)
        Subgroup fbc-1p-primscrn-cur-indfb-move:
                pass       -> FAIL       (shard-apl)
        Subgroup fbc-1p-primscrn-cur-indfb-onoff:
                pass       -> FAIL       (shard-apl)
        Subgroup fbc-1p-primscrn-indfb-pgflip-blt:
                pass       -> FAIL       (shard-apl)
        Subgroup fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
                pass       -> FAIL       (shard-apl)
        Subgroup fbc-1p-primscrn-spr-indfb-draw-pwrite:
                pass       -> FAIL       (shard-apl)
        Subgroup fbc-1p-primscrn-spr-indfb-move:
                pass       -> FAIL       (shard-apl)
        Subgroup fbc-1p-primscrn-spr-indfb-onoff:
                pass       -> FAIL       (shard-apl)
        Subgroup fbc-modesetfrombusy:
                pass       -> FAIL       (shard-apl)
        Subgroup fbc-rgb565-draw-mmap-gtt:
                pass       -> FAIL       (shard-apl)

---- Known issues:

Test kms_flip:
        Subgroup 2x-plain-flip-ts-check-interruptible:
                fail       -> PASS       (shard-hsw) fdo#100368
        Subgroup flip-vs-expired-vblank:
                pass       -> FAIL       (shard-hsw) fdo#102887 +1
Test kms_frontbuffer_tracking:
        Subgroup fbc-1p-offscren-pri-shrfb-draw-pwrite:
                pass       -> FAIL       (shard-apl) fdo#101623 +36
        Subgroup fbc-1p-primscrn-cur-indfb-draw-mmap-cpu:
                pass       -> FAIL       (shard-apl) fdo#105128
        Subgroup fbc-1p-primscrn-pri-indfb-draw-pwrite:
                pass       -> FAIL       (shard-apl) fdo#103167 +13
        Subgroup fbc-1p-primscrn-shrfb-msflip-blt:
                pass       -> FAIL       (shard-apl) fdo#104727
Test kms_pipe_crc_basic:
        Subgroup hang-read-crc-pipe-c:
                fail       -> PASS       (shard-apl) fdo#103191
Test kms_sysfs_edid_timing:
                warn       -> PASS       (shard-apl) fdo#100047

fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#105128 https://bugs.freedesktop.org/show_bug.cgi?id=105128
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#104727 https://bugs.freedesktop.org/show_bug.cgi?id=104727
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047

shard-apl        total:3442 pass:1749 dwarn:1   dfail:0   fail:74  skip:1618 time:13023s
shard-hsw        total:3442 pass:1766 dwarn:1   dfail:0   fail:3   skip:1671 time:11951s
shard-snb        total:3368 pass:1326 dwarn:1   dfail:0   fail:2   skip:2038 time:7095s
Blacklisted hosts:
shard-kbl        total:3442 pass:1875 dwarn:1   dfail:0   fail:74  skip:1492 time:9795s
$ dim sparse origin/drm-tip
Commit: drm/i915: Constify intel_plane_funcs
Okay!

Commit: drm/i915: Fix tabs vs. spaces
Okay!

Commit: drm/i915: Populate possible_crtcs for primary/cursor planes
Okay!

Commit: drm/i915: Don't populate plane->i9xx_plane for sprites
Okay!

Commit: drm/i915: Allow horizontal mirroring for cnl+ "sprite" planes
Okay!

Commit: drm/i915: Disallow plane scaling with specific pixel formats
Okay!

Commit: drm/i915: Add missing pixel formats for skl+ "sprites"
Okay!

Commit: drm/i915: Move plane_state->scaler_id initialization into intel_create_plane_state()
Okay!

Commit: drm/i915: Introduce intel_plane_alloc()
Okay!

Commit: drm/i915: Extract skl_universal_plane_init()
Okay!

Commit: drm/i915: s/intel_plane/plane/ in sprite init
Okay!

Patches download mbox

Tests

Series 39390v2 drm/i915: Some plane init cleanups
https://patchwork.freedesktop.org/api/1.0/series/39390/revisions/2/mbox/

---- Known issues:

Test kms_pipe_crc_basic:
        Subgroup read-crc-pipe-b-frame-sequence:
                fail       -> PASS       (fi-cfl-s3) fdo#103481

fdo#103481 https://bugs.freedesktop.org/show_bug.cgi?id=103481

fi-bdw-5557u     total:285  pass:264  dwarn:0   dfail:0   fail:0   skip:21  time:431s
fi-bdw-gvtdvm    total:285  pass:261  dwarn:0   dfail:0   fail:0   skip:24  time:440s
fi-blb-e6850     total:285  pass:220  dwarn:1   dfail:0   fail:0   skip:64  time:381s
fi-bsw-n3050     total:285  pass:239  dwarn:0   dfail:0   fail:0   skip:46  time:534s
fi-bwr-2160      total:285  pass:180  dwarn:0   dfail:0   fail:0   skip:105 time:295s
fi-bxt-dsi       total:285  pass:255  dwarn:0   dfail:0   fail:0   skip:30  time:515s
fi-bxt-j4205     total:285  pass:256  dwarn:0   dfail:0   fail:0   skip:29  time:511s
fi-byt-j1900     total:285  pass:250  dwarn:0   dfail:0   fail:0   skip:35  time:519s
fi-byt-n2820     total:285  pass:246  dwarn:0   dfail:0   fail:0   skip:39  time:505s
fi-cfl-8700k     total:285  pass:257  dwarn:0   dfail:0   fail:0   skip:28  time:410s
fi-cfl-s3        total:285  pass:259  dwarn:0   dfail:0   fail:0   skip:26  time:560s
fi-cfl-u         total:285  pass:259  dwarn:0   dfail:0   fail:0   skip:26  time:515s
fi-cnl-y3        total:285  pass:259  dwarn:0   dfail:0   fail:0   skip:26  time:585s
fi-elk-e7500     total:285  pass:225  dwarn:1   dfail:0   fail:0   skip:59  time:426s
fi-gdg-551       total:285  pass:176  dwarn:0   dfail:0   fail:1   skip:108 time:319s
fi-glk-1         total:285  pass:257  dwarn:0   dfail:0   fail:0   skip:28  time:535s
fi-hsw-4770      total:285  pass:258  dwarn:0   dfail:0   fail:0   skip:27  time:404s
fi-ilk-650       total:285  pass:225  dwarn:0   dfail:0   fail:0   skip:60  time:422s
fi-ivb-3520m     total:285  pass:256  dwarn:0   dfail:0   fail:0   skip:29  time:472s
fi-ivb-3770      total:285  pass:252  dwarn:0   dfail:0   fail:0   skip:33  time:432s
fi-kbl-7500u     total:285  pass:260  dwarn:1   dfail:0   fail:0   skip:24  time:470s
fi-kbl-7567u     total:285  pass:265  dwarn:0   dfail:0   fail:0   skip:20  time:460s
fi-kbl-r         total:285  pass:258  dwarn:0   dfail:0   fail:0   skip:27  time:509s
fi-pnv-d510      total:285  pass:219  dwarn:1   dfail:0   fail:0   skip:65  time:659s
fi-skl-6260u     total:285  pass:265  dwarn:0   dfail:0   fail:0   skip:20  time:438s
fi-skl-6600u     total:285  pass:258  dwarn:0   dfail:0   fail:0   skip:27  time:533s
fi-skl-6700k2    total:285  pass:261  dwarn:0   dfail:0   fail:0   skip:24  time:506s
fi-skl-6770hq    total:285  pass:265  dwarn:0   dfail:0   fail:0   skip:20  time:504s
fi-skl-guc       total:285  pass:257  dwarn:0   dfail:0   fail:0   skip:28  time:438s
fi-skl-gvtdvm    total:285  pass:262  dwarn:0   dfail:0   fail:0   skip:23  time:444s
fi-snb-2600      total:285  pass:245  dwarn:0   dfail:0   fail:0   skip:40  time:397s
Blacklisted hosts:
fi-cnl-psr       total:285  pass:256  dwarn:3   dfail:0   fail:0   skip:26  time:519s
fi-glk-j4005     total:285  pass:256  dwarn:0   dfail:0   fail:0   skip:29  time:484s

d6e43ca115e525e6d53539be28100d2ee0958655 drm-tip: 2018y-03m-29d-12h-46m-03s UTC integration manifest
ca6214e99d5b drm/i915: s/intel_plane/plane/ in sprite init
ddeff3237e98 drm/i915: Extract skl_universal_plane_init()
fd7566435480 drm/i915: Introduce intel_plane_alloc()
6176748cf0ba drm/i915: Move plane_state->scaler_id initialization into intel_create_plane_state()
2db8f3765e78 drm/i915: Add missing pixel formats for skl+ "sprites"
aec881e275b5 drm/i915: Disallow plane scaling with specific pixel formats
337d697f3b0d drm/i915: Allow horizontal mirroring for cnl+ "sprite" planes
257570f84e78 drm/i915: Don't populate plane->i9xx_plane for sprites
adcdb8e9684d drm/i915: Populate possible_crtcs for primary/cursor planes
ec13bb3a5a64 drm/i915: Fix tabs vs. spaces
dbb14497f77a drm/i915: Constify intel_plane_funcs
$ dim checkpatch origin/drm-tip
dbb14497f77a drm/i915: Constify intel_plane_funcs
ec13bb3a5a64 drm/i915: Fix tabs vs. spaces
adcdb8e9684d drm/i915: Populate possible_crtcs for primary/cursor planes
257570f84e78 drm/i915: Don't populate plane->i9xx_plane for sprites
337d697f3b0d drm/i915: Allow horizontal mirroring for cnl+ "sprite" planes
aec881e275b5 drm/i915: Disallow plane scaling with specific pixel formats
2db8f3765e78 drm/i915: Add missing pixel formats for skl+ "sprites"
6176748cf0ba drm/i915: Move plane_state->scaler_id initialization into intel_create_plane_state()
fd7566435480 drm/i915: Introduce intel_plane_alloc()
ddeff3237e98 drm/i915: Extract skl_universal_plane_init()
ca6214e99d5b drm/i915: s/intel_plane/plane/ in sprite init
---- Possible new issues:

Test kms_chv_cursor_fail:
        Subgroup pipe-b-64x64-top-edge:
                pass       -> FAIL       (shard-apl)

---- Known issues:

Test kms_flip:
        Subgroup blocking-wf_vblank:
                pass       -> FAIL       (shard-hsw) fdo#100368
Test kms_flip_tiling:
        Subgroup flip-to-x-tiled:
                pass       -> FAIL       (shard-apl) fdo#103822
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-a:
                incomplete -> PASS       (shard-hsw) fdo#103375
Test perf:
        Subgroup blocking:
                pass       -> FAIL       (shard-hsw) fdo#102252

fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252

shard-apl        total:3495 pass:1829 dwarn:1   dfail:0   fail:9   skip:1655 time:12960s
shard-hsw        total:3495 pass:1781 dwarn:1   dfail:0   fail:3   skip:1709 time:11624s
shard-snb        total:3495 pass:1374 dwarn:1   dfail:0   fail:3   skip:2117 time:7018s
Blacklisted hosts:
shard-kbl        total:3495 pass:1958 dwarn:1   dfail:0   fail:7   skip:1529 time:9279s
$ dim sparse origin/drm-tip
Commit: drm/i915: Constify intel_plane_funcs
Okay!

Commit: drm/i915: Fix tabs vs. spaces
Okay!

Commit: drm/i915: Populate possible_crtcs for primary/cursor planes
Okay!

Commit: drm/i915: Don't populate plane->i9xx_plane for sprites
Okay!

Commit: drm/i915: Allow horizontal mirroring for cnl+ "sprite" planes
Okay!

Commit: drm/i915: Disallow plane scaling with specific pixel formats
Okay!

Commit: drm/i915: Add missing pixel formats for skl+ "sprites"
Okay!

Commit: drm/i915: Move plane_state->scaler_id initialization into intel_create_plane_state()
Okay!

Commit: drm/i915: Introduce intel_plane_alloc()
Okay!

Commit: drm/i915: Extract skl_universal_plane_init()
Okay!

Commit: drm/i915: s/intel_plane/plane/ in sprite init
Okay!