LLVM fixes, round 999

Submitted by Emil Velikov on Feb. 7, 2017, 10:44 p.m.

Details

Reviewer None
Submitted Feb. 7, 2017, 10:44 p.m.
Last Updated Feb. 9, 2017, 9 p.m.
Revision 4

Cover Letter(s)

Revision 1
      Hi all,

Here is hopefully the final round of LLVM build fixes which should 
address both Jose and Dave's concerns to not touch any source code.

In return the configure.ac changes ended up be twice as large, but 
overall fine. Considering that most of those must land in stable.

In gist -> enable-gallium-llvm has been updated to mean enable-llvm [as 
per Dave] meaning that RADV now requires it. Additionally the 
defines/CFLAGS/LIBS are set only when the toggle is set.

The final two patches of the series address the actual deprecation of 
--enable-gallium-llvm in favour of --enable-llvm.

Do give the series a look and test on your end. I've fuzzed things 
quite a few times although I may have missed something.

Thanks
Emil


Emil Velikov (14):
  configure.ac: remove unused AC_SUBST([MESA_LLVM])
  configure.ac: move AC_ARG_ENABLE([gallium-llvm] hunk further up
  configure.ac: Rename the  gallium_require_llvm helper
  configure.ac: Mandate --enable-gallium-llvm when checking LLVM version
  configure.ac: Remove artificial --enable-gallium-llvm dependency
  configure.ac: remove unused LLVM variables
  configure.ac: don't use == with test
  Revert "configure.ac: Create correct LLVM_VERSION_INT with minor >=
    10"
  configure.ac: set LLVM_{C, CXX, LD}FLAGS only as needed
  configure.ac: disable enable_gallium_llvm in the !x86 case
  configure.ac: correctly manage llvm auto-detection
  configure.ac: remove dummy radeon_gallium_llvm_check()
  configure.ac: supersede --enable-gallium-llvm over --enable-llvm
  st/nine: update configure options in the README

Tobias Droste (3):
  configure.ac: Don't check LLVM version in require_llvm
  configure.ac: Rework MESA_LLVM and LLVM detection
  configure.ac: Only define HAVE_LLVM if LLVM is used

 Makefile.am                            |   2 +-
 configure.ac                           | 155 ++++++++++++++++-----------------
 docs/releasing.html                    |   2 +-
 src/gallium/state_trackers/nine/README |   3 +-
 4 files changed, 77 insertions(+), 85 deletions(-)
    

Revisions

Patches download mbox

# Name Submitter State A F R T
[Mesa-dev,01/17] configure.ac: remove unused AC_SUBST([MESA_LLVM]) Emil Velikov Accepted 1
[Mesa-dev,02/17] configure.ac: move AC_ARG_ENABLE([gallium-llvm] hunk further up Emil Velikov Accepted 1
[Mesa-dev,03/17] configure.ac: Don't check LLVM version in require_llvm Emil Velikov Accepted 1
[Mesa-dev,04/17] configure.ac: Rename the gallium_require_llvm helper Emil Velikov Accepted 1
[Mesa-dev,05/17] configure.ac: Mandate --enable-gallium-llvm when checking LLVM version Emil Velikov Accepted 1
[Mesa-dev,06/17] configure.ac: Remove artificial --enable-gallium-llvm dependency Emil Velikov Superseded
[Mesa-dev,07/17] configure.ac: Rework MESA_LLVM and LLVM detection Emil Velikov Superseded 2
[Mesa-dev,08/17] configure.ac: Only define HAVE_LLVM if LLVM is used Emil Velikov Accepted 1
[Mesa-dev,09/17] configure.ac: remove unused LLVM variables Emil Velikov Superseded 1
[Mesa-dev,10/17] configure.ac: don't use == with test Emil Velikov Superseded 1
[Mesa-dev,11/17] Revert "configure.ac: Create correct LLVM_VERSION_INT with minor >= 10" Emil Velikov Accepted 1
[Mesa-dev,12/17] configure.ac: set LLVM_{C, CXX, LD}FLAGS only as needed Emil Velikov Accepted 1
[Mesa-dev,13/17] configure.ac: disable enable_gallium_llvm in the !x86 case Emil Velikov Superseded 1
[Mesa-dev,14/17] configure.ac: correctly manage llvm auto-detection Emil Velikov Superseded 1
[Mesa-dev,15/17] configure.ac: remove dummy radeon_gallium_llvm_check() Emil Velikov Accepted 1
[Mesa-dev,16/17] configure.ac: supersede --enable-gallium-llvm over --enable-llvm Emil Velikov Superseded 1
[Mesa-dev,17/17] st/nine: update configure options in the README Emil Velikov Accepted

Patches download mbox

# Name Submitter State A F R T
[Mesa-dev,01/17] configure.ac: remove unused AC_SUBST([MESA_LLVM]) Emil Velikov Accepted 1
[Mesa-dev,02/17] configure.ac: move AC_ARG_ENABLE([gallium-llvm] hunk further up Emil Velikov Accepted 1
[Mesa-dev,03/17] configure.ac: Don't check LLVM version in require_llvm Emil Velikov Accepted 1
[Mesa-dev,04/17] configure.ac: Rename the gallium_require_llvm helper Emil Velikov Accepted 1
[Mesa-dev,05/17] configure.ac: Mandate --enable-gallium-llvm when checking LLVM version Emil Velikov Accepted 1
[Mesa-dev,v2,06/17] configure.ac: move enable-gallium-llvm dependency with-gallium-drivers Emil Velikov Accepted 1
[Mesa-dev,07/17] configure.ac: Rework MESA_LLVM and LLVM detection Emil Velikov Superseded 2
[Mesa-dev,08/17] configure.ac: Only define HAVE_LLVM if LLVM is used Emil Velikov Accepted 1
[Mesa-dev,09/17] configure.ac: remove unused LLVM variables Emil Velikov Superseded 1
[Mesa-dev,10/17] configure.ac: don't use == with test Emil Velikov Superseded 1
[Mesa-dev,11/17] Revert "configure.ac: Create correct LLVM_VERSION_INT with minor >= 10" Emil Velikov Accepted 1
[Mesa-dev,12/17] configure.ac: set LLVM_{C, CXX, LD}FLAGS only as needed Emil Velikov Accepted 1
[Mesa-dev,13/17] configure.ac: disable enable_gallium_llvm in the !x86 case Emil Velikov Superseded 1
[Mesa-dev,14/17] configure.ac: correctly manage llvm auto-detection Emil Velikov Superseded 1
[Mesa-dev,15/17] configure.ac: remove dummy radeon_gallium_llvm_check() Emil Velikov Accepted 1
[Mesa-dev,16/17] configure.ac: supersede --enable-gallium-llvm over --enable-llvm Emil Velikov Superseded 1
[Mesa-dev,17/17] st/nine: update configure options in the README Emil Velikov Accepted

Patches download mbox

# Name Submitter State A F R T
[Mesa-dev,01/17] configure.ac: remove unused AC_SUBST([MESA_LLVM]) Emil Velikov Accepted 1
[Mesa-dev,02/17] configure.ac: move AC_ARG_ENABLE([gallium-llvm] hunk further up Emil Velikov Accepted 1
[Mesa-dev,03/17] configure.ac: Don't check LLVM version in require_llvm Emil Velikov Accepted 1
[Mesa-dev,04/17] configure.ac: Rename the gallium_require_llvm helper Emil Velikov Accepted 1
[Mesa-dev,05/17] configure.ac: Mandate --enable-gallium-llvm when checking LLVM version Emil Velikov Accepted 1
[Mesa-dev,v2,06/17] configure.ac: move enable-gallium-llvm dependency with-gallium-drivers Emil Velikov Accepted 1
[Mesa-dev,v2,07/17] configure.ac: Rework MESA_LLVM and LLVM detection Emil Velikov Accepted 2
[Mesa-dev,08/17] configure.ac: Only define HAVE_LLVM if LLVM is used Emil Velikov Accepted 1
[Mesa-dev,09/17] configure.ac: remove unused LLVM variables Emil Velikov Superseded 1
[Mesa-dev,10/17] configure.ac: don't use == with test Emil Velikov Superseded 1
[Mesa-dev,11/17] Revert "configure.ac: Create correct LLVM_VERSION_INT with minor >= 10" Emil Velikov Accepted 1
[Mesa-dev,12/17] configure.ac: set LLVM_{C, CXX, LD}FLAGS only as needed Emil Velikov Accepted 1
[Mesa-dev,13/17] configure.ac: disable enable_gallium_llvm in the !x86 case Emil Velikov Superseded 1
[Mesa-dev,14/17] configure.ac: correctly manage llvm auto-detection Emil Velikov Superseded 1
[Mesa-dev,15/17] configure.ac: remove dummy radeon_gallium_llvm_check() Emil Velikov Accepted 1
[Mesa-dev,16/17] configure.ac: supersede --enable-gallium-llvm over --enable-llvm Emil Velikov Superseded 1
[Mesa-dev,17/17] st/nine: update configure options in the README Emil Velikov Accepted

Patches download mbox

# Name Submitter State A F R T
[Mesa-dev,01/17] configure.ac: remove unused AC_SUBST([MESA_LLVM]) Emil Velikov Accepted 1
[Mesa-dev,02/17] configure.ac: move AC_ARG_ENABLE([gallium-llvm] hunk further up Emil Velikov Accepted 1
[Mesa-dev,03/17] configure.ac: Don't check LLVM version in require_llvm Emil Velikov Accepted 1
[Mesa-dev,04/17] configure.ac: Rename the gallium_require_llvm helper Emil Velikov Accepted 1
[Mesa-dev,05/17] configure.ac: Mandate --enable-gallium-llvm when checking LLVM version Emil Velikov Accepted 1
[Mesa-dev,v2,06/17] configure.ac: move enable-gallium-llvm dependency with-gallium-drivers Emil Velikov Accepted 1
[Mesa-dev,v2,07/17] configure.ac: Rework MESA_LLVM and LLVM detection Emil Velikov Accepted 2
[Mesa-dev,08/17] configure.ac: Only define HAVE_LLVM if LLVM is used Emil Velikov Accepted 1
[Mesa-dev,09/17] configure.ac: remove unused LLVM variables Emil Velikov Superseded 1
[Mesa-dev,10/17] configure.ac: don't use == with test Emil Velikov Superseded 1
[Mesa-dev,11/17] Revert "configure.ac: Create correct LLVM_VERSION_INT with minor >= 10" Emil Velikov Accepted 1
[Mesa-dev,12/17] configure.ac: set LLVM_{C, CXX, LD}FLAGS only as needed Emil Velikov Accepted 1
[Mesa-dev,13/17] configure.ac: disable enable_gallium_llvm in the !x86 case Emil Velikov Superseded 1
[Mesa-dev,v2,14/17] configure.ac: correctly manage llvm auto-detection Emil Velikov Accepted 2
[Mesa-dev,15/17] configure.ac: remove dummy radeon_gallium_llvm_check() Emil Velikov Accepted 1
[Mesa-dev,16/17] configure.ac: supersede --enable-gallium-llvm over --enable-llvm Emil Velikov Superseded 1
[Mesa-dev,17/17] st/nine: update configure options in the README Emil Velikov Accepted