Remove DummyChannel* objects

Submitted by Christophe Fergeau on Nov. 23, 2016, 6:07 p.m.

Details

Reviewer None
Submitted Nov. 23, 2016, 6:07 p.m.
Last Updated Nov. 30, 2016, 2:58 p.m.
Revision 6

Cover Letter(s)

Revision 1
      These objects were used by the sound channel as
this channel read/write to/from client directly.
This make the code of this channel quite different
from the other ones.
Also this reduce code duplication from RedChannelClient
and increase encapsulation.
First set of patches attempt to rename fields/structures
to prepare for the conversion to RedChannel/RedChannelClient
and GObject.
Than other patches basically do the conversion and
some cleanup.

Frediano Ziglio (18):
  Remove unused fields
  sound: Unify commands
  sound: Use worker directly
  sound: Rename some objects
  sound: Rename workers to snd_channels
  sound: Rename {Record,Playback}Channel to *ChannelClient
  sound: Rename channel to client if variable used for clients
  sound: Rename worker to channel
  sound: Convert SndChannel to GObject
  sound: Implements config_socket RedChannel callback
  sound: Convert SndChannelClient to GObject
  sound: Implement on_disconnect RedChannel callback
  Remove DummyChannel* objects
  sound: Reduce message buffer
  Make RedChannelClient::incoming private
  sound: Free more on SndChannel finalize
  sound: Use default disconnect for client channels
  sound: Reuse code for snd_set_{playback,record}_peer

 server/Makefile.am                  |    4 -
 server/dummy-channel-client.c       |  138 ---
 server/dummy-channel-client.h       |   64 --
 server/dummy-channel.c              |   94 --
 server/dummy-channel.h              |   60 --
 server/red-channel-client-private.h |   11 +
 server/red-channel-client.c         |   12 +-
 server/red-channel-client.h         |   13 -
 server/sound.c                      | 1731 +++++++++++++++++------------------
 9 files changed, 866 insertions(+), 1261 deletions(-)
 delete mode 100644 server/dummy-channel-client.c
 delete mode 100644 server/dummy-channel-client.h
 delete mode 100644 server/dummy-channel.c
 delete mode 100644 server/dummy-channel.h
    
Revision 4
      These objects were used by the sound channel as
this channel read/write to/from client directly.
This make the code of this channel quite different
from the other ones.
Also this reduce code duplication from RedChannelClient
and increase encapsulation.
First set of patches attempt to rename fields/structures
to prepare for the conversion to RedChannel/RedChannelClient
and GObject.
Than other patches basically do the conversion and
some cleanup.

Changes since v2:
- send playback data as soon as possible;
- split renames putting client renames first then worker ones;
- some commit message changes.

Changes since v1:
- split some long lines;
- do not attempt to free in progress frame before is full sent.
  This could cause raw frames to be overridden.

Frediano Ziglio (17):
  sound: Use worker directly
  sound: Rename SndChannel to SndChannelClient
  sound: Rename {Record,Playback}Channel to *ChannelClient
  sound: Rename channel to client if variable used for clients
  sound: Rename SndWorker to SndChannel
  sound: Rename workers to snd_channels
  sound: Rename worker to channel
  sound: Convert SndChannel to GObject
  sound: Implements config_socket RedChannel callback
  sound: Convert SndChannelClient to GObject
  sound: Implement on_disconnect RedChannel callback
  Remove DummyChannel* objects
  sound: Reduce message buffer
  Make RedChannelClient::incoming private
  sound: Free more on SndChannel finalize
  sound: Use default disconnect for client channels
  sound: Reuse code for snd_set_{playback,record}_peer

 server/Makefile.am                  |    4 +-
 server/dummy-channel-client.c       |  138 +--
 server/dummy-channel-client.h       |   64 +-
 server/dummy-channel.c              |   94 +--
 server/dummy-channel.h              |   60 +-
 server/red-channel-client-private.h |   11 +-
 server/red-channel-client.c         |   12 +-
 server/red-channel-client.h         |   13 +-
 server/sound.c                      | 1699 +++++++++++++---------------
 9 files changed, 857 insertions(+), 1238 deletions(-)
 delete mode 100644 server/dummy-channel-client.c
 delete mode 100644 server/dummy-channel-client.h
 delete mode 100644 server/dummy-channel.c
 delete mode 100644 server/dummy-channel.h

base-commit: 29d6642430a21eba53a11f5120590d13a857edf4
    
Revision 5
      These objects were used by the sound channel as
this channel read/write to/from client directly.
This make the code of this channel quite different
from the other ones.
Also this reduce code duplication from RedChannelClient
and increase encapsulation.
First set of patches attempt to rename fields/structures
to prepare for the conversion to RedChannel/RedChannelClient
and GObject.
Than other patches basically do the conversion and
some cleanup.

Changes since v3:
- updated some commit message;
- rename structures and related fields in the same commit.
- reverted wrong field rename (RedChannel *client).

Changes since v2:
- send playback data as soon as possible;
- split renames putting client renames first then worker ones;
- some commit message changes.

Changes since v1:
- split some long lines;
- do not attempt to free in progress frame before is full sent.
  This could cause raw frames to be overridden.

Frediano Ziglio (14):
  sound: Use worker directly
  sound: Rename SndChannel to SndChannelClient
  sound: Rename {Record,Playback}Channel to *ChannelClient
  sound: Rename SndWorker to SndChannel
  sound: Convert SndChannel to GObject
  sound: Implements config_socket RedChannel callback
  sound: Convert SndChannelClient to GObject
  sound: Implement on_disconnect RedChannel callback
  Remove DummyChannel* objects
  sound: Reduce message buffer
  Make RedChannelClient::incoming private
  sound: Free more on SndChannel finalize
  sound: Use default disconnect for client channels
  sound: Reuse code for snd_set_{playback,record}_peer

 server/Makefile.am                  |    4 +-
 server/dummy-channel-client.c       |  138 +--
 server/dummy-channel-client.h       |   64 +-
 server/dummy-channel.c              |   94 +--
 server/dummy-channel.h              |   60 +-
 server/red-channel-client-private.h |   11 +-
 server/red-channel-client.c         |   12 +-
 server/red-channel-client.h         |   13 +-
 server/sound.c                      | 1701 +++++++++++++---------------
 9 files changed, 858 insertions(+), 1239 deletions(-)
 delete mode 100644 server/dummy-channel-client.c
 delete mode 100644 server/dummy-channel-client.h
 delete mode 100644 server/dummy-channel.c
 delete mode 100644 server/dummy-channel.h

base-commit: 29d6642430a21eba53a11f5120590d13a857edf4
    

Revisions

Patches download mbox

# Name Submitter State A F R T
[Spice-devel,spice-server,01/18] Remove unused fields Frediano Ziglio Accepted 1
[Spice-devel,spice-server,02/18] sound: Unify commands Frediano Ziglio Accepted
[Spice-devel,spice-server,03/18] sound: Use worker directly Frediano Ziglio Superseded
[Spice-devel,spice-server,04/18] sound: Rename some objects Frediano Ziglio Superseded
[Spice-devel,spice-server,05/18] sound: Rename workers to snd_channels Frediano Ziglio Superseded
[Spice-devel,spice-server,06/18] sound: Rename {Record, Playback}Channel to *ChannelClient Frediano Ziglio Superseded
[Spice-devel,spice-server,07/18] sound: Rename channel to client if variable used for clients Frediano Ziglio Superseded
[Spice-devel,spice-server,08/18] sound: Rename worker to channel Frediano Ziglio Superseded
[Spice-devel,spice-server,09/18] sound: Convert SndChannel to GObject Frediano Ziglio Superseded
[Spice-devel,spice-server,10/18] sound: Implements config_socket RedChannel callback Frediano Ziglio Superseded
[Spice-devel,spice-server,11/18] sound: Convert SndChannelClient to GObject Frediano Ziglio Superseded
[Spice-devel,spice-server,12/18] sound: Implement on_disconnect RedChannel callback Frediano Ziglio Superseded
[Spice-devel,spice-server,13/18] Remove DummyChannel* objects Frediano Ziglio Superseded
[Spice-devel,spice-server,14/18] sound: Reduce message buffer Frediano Ziglio Superseded
[Spice-devel,spice-server,15/18] Make RedChannelClient::incoming private Frediano Ziglio Accepted
[Spice-devel,spice-server,16/18] sound: Free more on SndChannel finalize Frediano Ziglio Superseded
[Spice-devel,spice-server,17/18] sound: Use default disconnect for client channels Frediano Ziglio Superseded
[Spice-devel,spice-server,18/18] sound: Reuse code for snd_set_{playback, record}_peer Frediano Ziglio Superseded
SERIES REVISION LOOKS STRANGE. Please double-check patch list and the ordering before proceeding.

Patches download mbox

# Name Submitter State A F R T
[Spice-devel,spice-server,01/18] Remove unused fields Frediano Ziglio Accepted 1
[Spice-devel,spice-server,02/18] sound: Unify commands Frediano Ziglio Accepted
[Spice-devel,spice-server,v2] sound: Use worker directly Frediano Ziglio Accepted
[Spice-devel,spice-server,04/18] sound: Rename some objects Frediano Ziglio Superseded
[Spice-devel,spice-server,05/18] sound: Rename workers to snd_channels Frediano Ziglio Superseded
[Spice-devel,spice-server,06/18] sound: Rename {Record, Playback}Channel to *ChannelClient Frediano Ziglio Superseded
[Spice-devel,spice-server,07/18] sound: Rename channel to client if variable used for clients Frediano Ziglio Superseded
[Spice-devel,spice-server,08/18] sound: Rename worker to channel Frediano Ziglio Superseded
[Spice-devel,spice-server,09/18] sound: Convert SndChannel to GObject Frediano Ziglio Superseded
[Spice-devel,spice-server,10/18] sound: Implements config_socket RedChannel callback Frediano Ziglio Superseded
[Spice-devel,spice-server,11/18] sound: Convert SndChannelClient to GObject Frediano Ziglio Superseded
[Spice-devel,spice-server,12/18] sound: Implement on_disconnect RedChannel callback Frediano Ziglio Superseded
[Spice-devel,spice-server,13/18] Remove DummyChannel* objects Frediano Ziglio Superseded
[Spice-devel,spice-server,14/18] sound: Reduce message buffer Frediano Ziglio Superseded
[Spice-devel,spice-server,15/18] Make RedChannelClient::incoming private Frediano Ziglio Accepted
[Spice-devel,spice-server,16/18] sound: Free more on SndChannel finalize Frediano Ziglio Superseded
[Spice-devel,spice-server,17/18] sound: Use default disconnect for client channels Frediano Ziglio Superseded
[Spice-devel,spice-server,18/18] sound: Reuse code for snd_set_{playback, record}_peer Frediano Ziglio Superseded
SERIES REVISION LOOKS STRANGE. Please double-check patch list and the ordering before proceeding.

Patches download mbox

# Name Submitter State A F R T
[Spice-devel,spice-server,01/18] Remove unused fields Frediano Ziglio Accepted 1
[Spice-devel,spice-server,v2] sound: Unify commands Frediano Ziglio Accepted 1
[Spice-devel,spice-server,v2] sound: Use worker directly Frediano Ziglio Accepted
[Spice-devel,spice-server,04/18] sound: Rename some objects Frediano Ziglio Superseded
[Spice-devel,spice-server,05/18] sound: Rename workers to snd_channels Frediano Ziglio Superseded
[Spice-devel,spice-server,06/18] sound: Rename {Record, Playback}Channel to *ChannelClient Frediano Ziglio Superseded
[Spice-devel,spice-server,07/18] sound: Rename channel to client if variable used for clients Frediano Ziglio Superseded
[Spice-devel,spice-server,08/18] sound: Rename worker to channel Frediano Ziglio Superseded
[Spice-devel,spice-server,09/18] sound: Convert SndChannel to GObject Frediano Ziglio Superseded
[Spice-devel,spice-server,10/18] sound: Implements config_socket RedChannel callback Frediano Ziglio Superseded
[Spice-devel,spice-server,11/18] sound: Convert SndChannelClient to GObject Frediano Ziglio Superseded
[Spice-devel,spice-server,12/18] sound: Implement on_disconnect RedChannel callback Frediano Ziglio Superseded
[Spice-devel,spice-server,13/18] Remove DummyChannel* objects Frediano Ziglio Superseded
[Spice-devel,spice-server,14/18] sound: Reduce message buffer Frediano Ziglio Superseded
[Spice-devel,spice-server,15/18] Make RedChannelClient::incoming private Frediano Ziglio Accepted
[Spice-devel,spice-server,16/18] sound: Free more on SndChannel finalize Frediano Ziglio Superseded
[Spice-devel,spice-server,17/18] sound: Use default disconnect for client channels Frediano Ziglio Superseded
[Spice-devel,spice-server,18/18] sound: Reuse code for snd_set_{playback, record}_peer Frediano Ziglio Superseded

Patches download mbox

# Name Submitter State A F R T
[Spice-devel,v3,01/17] sound: Use worker directly Frediano Ziglio Accepted
[Spice-devel,v3,02/17] sound: Rename SndChannel to SndChannelClient Frediano Ziglio Accepted
[Spice-devel,v3,03/17] sound: Rename {Record, Playback}Channel to *ChannelClient Frediano Ziglio Accepted
[Spice-devel,v3,04/17] sound: Rename channel to client if variable used for clients Frediano Ziglio Accepted
[Spice-devel,v3,05/17] sound: Rename SndWorker to SndChannel Frediano Ziglio Accepted
[Spice-devel,v3,06/17] sound: Rename workers to snd_channels Frediano Ziglio Accepted
[Spice-devel,v3,07/17] sound: Rename worker to channel Frediano Ziglio Accepted
[Spice-devel,v3,08/17] sound: Convert SndChannel to GObject Frediano Ziglio Accepted
[Spice-devel,v3,09/17] sound: Implements config_socket RedChannel callback Frediano Ziglio Accepted
[Spice-devel,v3,10/17] sound: Convert SndChannelClient to GObject Frediano Ziglio Superseded
[Spice-devel,v3,11/17] sound: Implement on_disconnect RedChannel callback Frediano Ziglio Accepted
[Spice-devel,v3,12/17] Remove DummyChannel* objects Frediano Ziglio Superseded
[Spice-devel,v3,13/17] sound: Reduce message buffer Frediano Ziglio Accepted
[Spice-devel,v3,14/17] Make RedChannelClient::incoming private Frediano Ziglio Superseded
[Spice-devel,v3,15/17] sound: Free more on SndChannel finalize Frediano Ziglio Superseded
[Spice-devel,v3,16/17] sound: Use default disconnect for client channels Frediano Ziglio Accepted
[Spice-devel,v3,17/17] sound: Reuse code for snd_set_{playback, record}_peer Frediano Ziglio Superseded