More coverity fixes

Submitted by Frediano Ziglio on Oct. 16, 2016, 11:44 a.m.

Details

Reviewer None
Submitted Oct. 16, 2016, 11:44 a.m.
Last Updated Dec. 6, 2016, 4:06 p.m.
Revision 3

Cover Letter(s)

Revision 1
      This patch-set contains mostly patches that fix/related-to
coverity issues.

Uri Lublin (8):
  current_remove: rename internal variable 'container'
  image_encoders: check shared_dict before accessing it
  input-channel: add a comment to mark fallthrough in switch
  main-channel: getpeername/getsockname return early if no sockfd
  mjpeg_encoder_new: allocate memory after sanity check
  red_get_image_data_flat: allocate mem after sanity check
  red-record-qxl: replace continue with empty block
  red-record-qxl: child_output_setup: check fcntl return value

 server/display-channel.c |  6 +++---
 server/image-encoders.c  |  6 ++++--
 server/inputs-channel.c  |  1 +
 server/main-channel.c    | 16 ++++++++++++++--
 server/mjpeg-encoder.c   |  3 ++-
 server/red-parse-qxl.c   | 11 +++++++----
 server/red-record-qxl.c  | 11 ++++++++---
 7 files changed, 39 insertions(+), 15 deletions(-)
    
Revision 3
      changes since v1:
   Patch 1/6 better variable names (Frediano)
   Patch 2/6 return only after lock was released (Frediano)
   Patch 3/6 unchanged (same as Patch 6/8 of v1)
   Patch 4/6 kept both curly braces and continue (7/8) (Frediano)
   Patch 5/6 removed fcntl altogether (8/8) (Frediano)
   Patch 6/6 a new patch

   Patch 2/8 of v1 has already been pushed
   Patch 3/8 of v1 has already been pushed
   Patch 4/8 a similar patch by Frediano exists.


Uri Lublin (6):
  display-channel: current_remove: rename inner variable 'container'
  image_encoders: check shared_dict before accessing it
  red_get_image_data_flat: allocate mem after sanity check
  red-record-qxl: add curly braces to empty while loop
  red-record-qxl: child_output_setup: remove fcntl call
  dispatcher: write_safe: move EINTR debug message

 server/dispatcher.c      |  2 +-
 server/display-channel.c | 12 ++++++------
 server/image-encoders.c  |  8 ++++++--
 server/red-parse-qxl.c   | 11 +++++++----
 server/red-record-qxl.c  | 10 ++++------
 5 files changed, 24 insertions(+), 19 deletions(-)
    

Revisions