HSW/BDW PCH modeset fixes and stuff

Submitted by Ville Syrjälä on Dec. 1, 2015, 1:08 p.m.

Details

Reviewer None
Submitted Dec. 1, 2015, 1:08 p.m.
Last Updated Dec. 8, 2015, 2:07 p.m.
Revision 13

Cover Letter(s)

Revision 1
      From: Ville Syrjälä <ville.syrjala@linux.intel.com>

I was trying to get to the bottom of the FDI fails on Brix Pro, and
thus eneded up going through the entire PCH modeset stuff for HSW.
While I did find a bunch of stuff missing/wrong, sadly I wasn't able
to make FDI training succeed on that machine. So in the end I simply
had to resort to getting rid of the CRT connector. And to add insult
to injury, the only way I could do that is to look at the VBT :(

Anwyay, here are the fruits of my labor. The whole thing is available
here:
git://github.com/vsyrjala/linux.git hsw_pch_fixes

Ville Syrjälä (10):
  drm/i915: Don't register the CRT connector when it's fused off
  drm/i915: Don't register CRT connectro when DDI E can't be used
  drm/i915: Check VBT for CRT port presence on HSW/BDW
  drm/i915: Add "missing" break to haswell_get_ddi_pll()
  drm/i915: Disable CLKOUT_DP bending on LPT/WPT as needed
  drm/i915: Round to closest when computing the VGA dotclock for LPT-H
  drm/i915: Disable FDI after the CRT port on LPT-H
  drm/i915: Refactor LPT-H VGA dotclock disabling
  drm/i915: Disable LPT-H VGA dotclock during crtc disable
  drm/i915: Leave FDI running after failed link training on LPT-H

 drivers/gpu/drm/i915/i915_reg.h      |   4 +-
 drivers/gpu/drm/i915/intel_ddi.c     |  24 ++++---
 drivers/gpu/drm/i915/intel_display.c | 123 ++++++++++++++++++++++++++++-------
 3 files changed, 117 insertions(+), 34 deletions(-)
    

Revisions

SERIES REVISION LOOKS STRANGE. Please double-check patch list and the ordering before proceeding.

Patches download mbox

Tests

Built on 0403da2e5c377bbd61c7803b955b41edf00bd501 drm-intel-nightly: 2015y-12m-01d-09h-05m-32s UTC integration manifest

Test igt@kms_flip@basic-flip-vs-wf_vblank on hsw-brixbox dmesg-fail -> dmesg-warn
Test igt@kms_pipe_crc_basic@read-crc-pipe-c-frame-sequence on hsw-brixbox dmesg-fail -> dmesg-warn
Test igt@kms_pipe_crc_basic@hang-read-crc-pipe-c on hsw-brixbox dmesg-fail -> dmesg-warn
Test igt@kms_pipe_crc_basic@hang-read-crc-pipe-b on hsw-brixbox dmesg-fail -> dmesg-warn
Test igt@kms_pipe_crc_basic@hang-read-crc-pipe-a on hsw-brixbox dmesg-fail -> dmesg-warn
Test igt@kms_flip@basic-flip-vs-dpms on hsw-brixbox dmesg-fail -> dmesg-warn
Test igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b on hsw-brixbox dmesg-fail -> dmesg-warn
Test igt@kms_flip@basic-plain-flip on hsw-brixbox dmesg-fail -> dmesg-warn
Test igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence on hsw-brixbox dmesg-fail -> dmesg-warn
Test igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c on hsw-brixbox dmesg-fail -> dmesg-warn
Test igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a on hsw-brixbox dmesg-fail -> dmesg-warn
Test igt@kms_pipe_crc_basic@read-crc-pipe-a on hsw-brixbox dmesg-fail -> dmesg-warn
Test igt@kms_pipe_crc_basic@read-crc-pipe-c on hsw-brixbox dmesg-fail -> dmesg-warn
Test igt@kms_pipe_crc_basic@read-crc-pipe-b on hsw-brixbox dmesg-fail -> dmesg-warn
Test igt@kms_flip@basic-flip-vs-modeset on hsw-brixbox dmesg-fail -> dmesg-warn
Test igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence on hsw-brixbox dmesg-fail -> dmesg-warn

bdw-nuci7        total:131  pass:107  dwarn:19  dfail:0   fail:0   skip:5  
bsw-nuc-2        total:131  pass:115  dwarn:0   dfail:0   fail:0   skip:16 
hsw-brixbox      total:131  pass:109  dwarn:19  dfail:0   fail:0   skip:3  
hsw-gt2          total:131  pass:109  dwarn:19  dfail:0   fail:0   skip:3  
ilk-hp8440p      total:131  pass:97   dwarn:0   dfail:0   fail:0   skip:34 
ivb-t430s        total:131  pass:126  dwarn:0   dfail:0   fail:0   skip:5  
skl-i5k-2        total:131  pass:117  dwarn:10  dfail:0   fail:0   skip:4  
snb-dellxps      total:131  pass:118  dwarn:1   dfail:0   fail:0   skip:12 
snb-x220t        total:131  pass:120  dwarn:0   dfail:0   fail:1   skip:10 

HANGED byt-nuc in igt@kms_pipe_crc_basic@hang-read-crc-pipe-a
SERIES REVISION LOOKS STRANGE. Please double-check patch list and the ordering before proceeding.

Patches download mbox

Tests

Built on 5fe690319ebb4ae901136dcb3eb198f8ac8598bf drm-intel-nightly: 2015y-12m-01d-14h-08m-48s UTC integration manifest

Test igt@kms_flip@basic-flip-vs-wf_vblank on hsw-brixbox dmesg-fail -> dmesg-warn
Test igt@kms_pipe_crc_basic@read-crc-pipe-c-frame-sequence on hsw-brixbox dmesg-fail -> dmesg-warn
Test igt@kms_pipe_crc_basic@hang-read-crc-pipe-c on hsw-brixbox dmesg-fail -> dmesg-warn
Test igt@kms_pipe_crc_basic@hang-read-crc-pipe-b on hsw-brixbox dmesg-fail -> dmesg-warn
Test igt@kms_pipe_crc_basic@hang-read-crc-pipe-a on hsw-brixbox dmesg-fail -> dmesg-warn
Test igt@kms_flip@basic-flip-vs-dpms on hsw-brixbox dmesg-fail -> dmesg-warn
Test igt@kms_flip@basic-plain-flip on hsw-brixbox dmesg-fail -> dmesg-warn
Test igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b on hsw-brixbox dmesg-fail -> dmesg-warn
Test igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence on hsw-brixbox dmesg-fail -> dmesg-warn
Test igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c on hsw-brixbox dmesg-fail -> dmesg-warn
Test igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a on hsw-brixbox dmesg-fail -> dmesg-warn
Test igt@kms_pipe_crc_basic@read-crc-pipe-a on hsw-brixbox dmesg-fail -> dmesg-warn
Test igt@kms_pipe_crc_basic@read-crc-pipe-c on hsw-brixbox dmesg-fail -> dmesg-warn
Test igt@kms_pipe_crc_basic@read-crc-pipe-b on hsw-brixbox dmesg-fail -> dmesg-warn
Test igt@kms_flip@basic-flip-vs-modeset on hsw-brixbox dmesg-fail -> dmesg-warn
Test igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence on hsw-brixbox dmesg-fail -> dmesg-warn

bdw-nuci7        total:131  pass:107  dwarn:19  dfail:0   fail:0   skip:5  
hsw-brixbox      total:131  pass:109  dwarn:19  dfail:0   fail:0   skip:3  
hsw-gt2          total:131  pass:109  dwarn:19  dfail:0   fail:0   skip:3  
ilk-hp8440p      total:131  pass:97   dwarn:0   dfail:0   fail:0   skip:34 
ivb-t430s        total:131  pass:126  dwarn:0   dfail:0   fail:0   skip:5  
skl-i5k-2        total:131  pass:117  dwarn:10  dfail:0   fail:0   skip:4  
snb-dellxps      total:131  pass:118  dwarn:1   dfail:0   fail:0   skip:12 
snb-x220t        total:131  pass:120  dwarn:0   dfail:0   fail:1   skip:10 
SERIES REVISION LOOKS STRANGE. Please double-check patch list and the ordering before proceeding.

Patches download mbox

Tests

HEAD is now at 6a328cd drm-intel-nightly: 2015y-12m-04d-20h-56m-42s UTC integration manifest
Applying: drm/i915: Don't register the CRT connector when it's fused off on LPT-H
Using index info to reconstruct a base tree...
M	drivers/gpu/drm/i915/i915_reg.h
M	drivers/gpu/drm/i915/intel_display.c
Falling back to patching base and 3-way merge...
Auto-merging drivers/gpu/drm/i915/intel_display.c
CONFLICT (content): Merge conflict in drivers/gpu/drm/i915/intel_display.c
Patch failed at 0001 drm/i915: Don't register the CRT connector when it's fused off on LPT-H