[Mesa-dev,1/2] i965: Make inline function static

Submitted by Iago Toral Quiroga on July 5, 2016, 9:21 a.m.

Details

Message ID 1467710482-4679-1-git-send-email-itoral@igalia.com
State New
Headers show
Series "Series without cover letter" ( rev: 1 ) in Mesa

Not browsing as part of any series.

Commit Message

Iago Toral Quiroga July 5, 2016, 9:21 a.m.
Without this the i965 driver fails to load.
---
 src/mesa/drivers/dri/i965/brw_blorp.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/src/mesa/drivers/dri/i965/brw_blorp.h b/src/mesa/drivers/dri/i965/brw_blorp.h
index 751e082..cf1ba63 100644
--- a/src/mesa/drivers/dri/i965/brw_blorp.h
+++ b/src/mesa/drivers/dri/i965/brw_blorp.h
@@ -240,7 +240,7 @@  struct brw_blorp_prog_data
    uint8_t param[BRW_BLORP_NUM_PUSH_CONSTANT_DWORDS];
 };
 
-inline unsigned
+static inline unsigned
 brw_blorp_get_urb_length(const struct brw_blorp_prog_data *prog_data)
 {
    if (prog_data == NULL)

Comments

On Tue, Jul 05, 2016 at 11:21:21AM +0200, Iago Toral Quiroga wrote:
> Without this the i965 driver fails to load.
> ---
>  src/mesa/drivers/dri/i965/brw_blorp.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_blorp.h b/src/mesa/drivers/dri/i965/brw_blorp.h
> index 751e082..cf1ba63 100644
> --- a/src/mesa/drivers/dri/i965/brw_blorp.h
> +++ b/src/mesa/drivers/dri/i965/brw_blorp.h
> @@ -240,7 +240,7 @@ struct brw_blorp_prog_data
>     uint8_t param[BRW_BLORP_NUM_PUSH_CONSTANT_DWORDS];
>  };
>  
> -inline unsigned
> +static inline unsigned

Thanks a lot for fixing this! I'm pretty certain I had that fixed quite some
time a go (I believe it was Ken that noticed the failure that time).

Reviewed-by: Topi Pohjolainen <topi.pohjolainen@intel.com>

>  brw_blorp_get_urb_length(const struct brw_blorp_prog_data *prog_data)
>  {
>     if (prog_data == NULL)
> -- 
> 2.7.4
>