[Mesa-dev,Mesa-stable] radeon uvd add uvd fw version for amdgpu

Submitted by Jiang, Sonny on July 4, 2016, 9:33 p.m.

Details

Message ID BY2PR12MB0679575DE5858A46B4A24D85FD380@BY2PR12MB0679.namprd12.prod.outlook.com
State New
Headers show
Series "radeon uvd add uvd fw version for amdgpu" ( rev: 2 ) in Mesa

Not browsing as part of any series.

Commit Message

Jiang, Sonny July 4, 2016, 9:33 p.m.
Hi Emil,


I have added comments for each patch, and applied for branch 12.0.

Please find attached patches.


Thanks,

Sonny

Patch hide | download patch | download mbox

From c57e350c209a462a541c36ab52b5a4b2233679be Mon Sep 17 00:00:00 2001
From: sonjiang <sonny.jiang@amd.com>
Date: Tue, 28 Jun 2016 11:23:41 -0400
Subject: [PATCH 3/3] radeon/uvd: fix a h265 context size bug
Fixes a h265 video corruption bug which caused by uvd fw interface changes.

Signed-off-by: sonjiang <sonny.jiang@amd.com>
Cc: "12.0" <mesa-stable@lists.freedesktop.org>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
---
 src/gallium/drivers/radeon/radeon_uvd.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/gallium/drivers/radeon/radeon_uvd.c b/src/gallium/drivers/radeon/radeon_uvd.c
index 1f28b01..7d0d2fd 100644
--- a/src/gallium/drivers/radeon/radeon_uvd.c
+++ b/src/gallium/drivers/radeon/radeon_uvd.c
@@ -1096,6 +1096,9 @@  static void ruvd_end_frame(struct pipe_video_codec *decoder,
 			}
 			rvid_clear_buffer(decoder->context, &dec->ctx);
 		}
+
+		if (dec->ctx.res)
+			dec->msg->body.decode.dpb_reserved = dec->ctx.res->buf->size;
 		break;
 
 	case PIPE_VIDEO_FORMAT_VC1:
-- 
2.7.4


Comments

Hi Emil,


Are you Okay with these?


Thanks,

Sonny
On Wed, Jul 6, 2016 at 11:09 AM, Jiang, Sonny <Sonny.Jiang@amd.com> wrote:
> Hi Emil,
>
>
> Are you Okay with these?

Without these patches UVD won't work on Polaris.

Alex

>
>
> Thanks,
>
> Sonny
>
> ________________________________
> From: Jiang, Sonny
> Sent: Monday, July 4, 2016 5:33:29 PM
> To: Christian König; Emil Velikov
> Cc: 12.0; mesa-dev@lists.freedesktop.org
>
> Subject: Re: [Mesa-dev] [Mesa-stable] [PATCH] radeon uvd add uvd fw version
> for amdgpu
>
>
> Hi Emil,
>
>
> I have added comments for each patch, and applied for branch 12.0.
>
> Please find attached patches.
>
>
> Thanks,
>
> Sonny
>
> ________________________________
> From: mesa-dev <mesa-dev-bounces@lists.freedesktop.org> on behalf of
> Christian König <deathsimple@vodafone.de>
> Sent: Friday, July 1, 2016 8:07:51 AM
> To: Emil Velikov
> Cc: Jiang, Sonny; 12.0; mesa-dev@lists.freedesktop.org
> Subject: Re: [Mesa-dev] [Mesa-stable] [PATCH] radeon uvd add uvd fw version
> for amdgpu
>
> Am 01.07.2016 um 13:14 schrieb Emil Velikov:
>> Hi all,
>>
>> On 29 June 2016 at 20:20, Christian König <deathsimple@vodafone.de> wrote:
>>> Am 29.06.2016 um 18:35 schrieb Alex Deucher:
>>>> On Wed, Jun 29, 2016 at 11:38 AM, Leo Liu <leo.liu@amd.com> wrote:
>>>>> From: sonjiang <sonny.jiang@amd.com>
>>>>>
>>>>> Signed-off-by: sonjiang <sonny.jiang@amd.com>
>>>>> Cc: "12.0" <mesa-stable@lists.freedesktop.org>
>>>> For the series:
>>>> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
>>>
>>> Reviewed-by: Christian König <christian.koenig@amd.com> as well.
>>>
>> Here we have three patches, suggesting a bug with absolutely no
>> information what the issue is and/or why this approach is correct.
>>
>> I'm sorry to say this, but as is, this series is not landing in
>> stable. Sonjiang, being the author of these please reply with a brief
>> justification why we want those. Before doing so I would strongly
>> recommend reading this [1] blog post.
>
> Well to put a carrot on the front of your stick: I asked what the
> firmware version patch is all about internally as well when I've seen
> those patches. So it would have even made our internal review much
> easier if Sonny added a commit message in the first place.
>
> My fault to not requesting that his answer is put as a commit message on
> the patches.
>
> On the other hand this is for Polaris, we had time pressure to get it
> out of the door and today is a public holiday in Canada. So you probably
> won't get updated message before Monday.
>
> Is that soon enough? Otherwise UVD will be broken on Polaris in the
> stable branch.
>
> Regards,
> Christian.
>
>>
>> Thanks
>> Emil
>>
>> [1] http://who-t.blogspot.co.uk/2009/12/on-commit-messages.html
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
On 6 July 2016 at 16:09, Jiang, Sonny <Sonny.Jiang@amd.com> wrote:
> Hi Emil,
>
>
> Are you Okay with these?
>
It'll do for now.

General suggestion - do not try to justifying the patch on the grounds
that it fixes a bug. Mention what was wrong and/or why it was resolved
in a particular way.

A style example/suggestion, which I believe your colleagues will be
quite pleased to see.

"[PATCH 2/2] radeon: sepArate uvd context buffer from DPB

Older Polaris FW does not handle XXX leading to bug in YYY. Newer one
resolves that by exposing/requiring the user to separate uvd context
buffer from DPB, and provide the AAA data via BBB."

Thanks
Emil
P.S. HTML emails and attached patches is a bad idea for mesa-dev@ (and
many other MLs).