ext_transform_feedback - unmap readback buffer

Submitted by Sebastian Olender on July 29, 2095, 9:21 p.m.

Details

Message ID 3962812866-4567-1-git-send-email-sebastian.d.olender@intel.com
State New
Headers show
Series "ext_transform_feedback - unmap readback buffer" ( rev: 1 ) in Piglit

Not browsing as part of any series.

Commit Message

Sebastian Olender July 29, 2095, 9:21 p.m.
use glUnmapBuffer to release the mapping of a buffer object after use
---
 tests/spec/ext_transform_feedback/overflow-edge-cases.c | 2 ++
 1 file changed, 2 insertions(+)

Patch hide | download patch | download mbox

diff --git a/tests/spec/ext_transform_feedback/overflow-edge-cases.c b/tests/spec/ext_transform_feedback/overflow-edge-cases.c
index 344d0ff..5c0fa70 100644
--- a/tests/spec/ext_transform_feedback/overflow-edge-cases.c
+++ b/tests/spec/ext_transform_feedback/overflow-edge-cases.c
@@ -289,6 +289,8 @@  test(int bind_size, int num_varyings, int num_primitives, int mode_index)
 			pass = GL_FALSE;
 		}
 	}
+	glUnmapBuffer(GL_TRANSFORM_FEEDBACK_BUFFER); /* unmap readback */
+
 
 	if (pass)
 		printf("PASS\n");

Comments

On 07/29/2095 02:21 PM, Sebastian Olender wrote:
> use glUnmapBuffer to release the mapping of a buffer object after use
> ---
>   tests/spec/ext_transform_feedback/overflow-edge-cases.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/tests/spec/ext_transform_feedback/overflow-edge-cases.c b/tests/spec/ext_transform_feedback/overflow-edge-cases.c
> index 344d0ff..5c0fa70 100644
> --- a/tests/spec/ext_transform_feedback/overflow-edge-cases.c
> +++ b/tests/spec/ext_transform_feedback/overflow-edge-cases.c
> @@ -289,6 +289,8 @@ test(int bind_size, int num_varyings, int num_primitives, int mode_index)
>   			pass = GL_FALSE;
>   		}
>   	}
> +	glUnmapBuffer(GL_TRANSFORM_FEEDBACK_BUFFER); /* unmap readback */
> +
>
>   	if (pass)
>   		printf("PASS\n");
>

Reviewed-by: Brian Paul <brianp@vmware.com>

Need me to push this for you?

-Brian
Yes, please

-----Original Message-----
From: Brian Paul [mailto:brianp@vmware.com] 

Sent: Thursday, June 16, 2016 6:30 PM
To: Olender, Sebastian D <sebastian.d.olender@intel.com>; piglit@lists.freedesktop.org
Subject: Re: [Piglit] [piglit][PATCH] ext_transform_feedback - unmap readback buffer

On 07/29/2095 02:21 PM, Sebastian Olender wrote:
> use glUnmapBuffer to release the mapping of a buffer object after use

> ---

>   tests/spec/ext_transform_feedback/overflow-edge-cases.c | 2 ++

>   1 file changed, 2 insertions(+)

>

> diff --git a/tests/spec/ext_transform_feedback/overflow-edge-cases.c b/tests/spec/ext_transform_feedback/overflow-edge-cases.c

> index 344d0ff..5c0fa70 100644

> --- a/tests/spec/ext_transform_feedback/overflow-edge-cases.c

> +++ b/tests/spec/ext_transform_feedback/overflow-edge-cases.c

> @@ -289,6 +289,8 @@ test(int bind_size, int num_varyings, int num_primitives, int mode_index)

>   			pass = GL_FALSE;

>   		}

>   	}

> +	glUnmapBuffer(GL_TRANSFORM_FEEDBACK_BUFFER); /* unmap readback */

> +

>

>   	if (pass)

>   		printf("PASS\n");

>


Reviewed-by: Brian Paul <brianp@vmware.com>


Need me to push this for you?

-Brian