[Spice-devel,v2,spice-gtk] Use correct variable to print if LZ4 support is to be built.

Submitted by Eduardo Lima (Etrunko) on June 16, 2016, 2:33 p.m.

Details

Message ID 1466087590-7764-1-git-send-email-etrunko@redhat.com
State New
Headers show
Series "Make LZ4 dependency check more robust" ( rev: 5 ) in Spice

Not browsing as part of any series.

Commit Message

Eduardo Lima (Etrunko) June 16, 2016, 2:33 p.m.
Signed-off-by: Eduardo Lima (Etrunko) <etrunko@redhat.com>
---
 configure.ac | 2 +-
 spice-common | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Patch hide | download patch | download mbox

diff --git a/configure.ac b/configure.ac
index 6e65188..0ca333f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -640,7 +640,7 @@  AC_MSG_NOTICE([
         USB redirection support:  ${have_usbredir} ${with_usbredir_hotplug}
         DBus:                     ${have_dbus}
         WebDAV support:           ${have_phodav}
-        LZ4 support:              ${enable_lz4}
+        LZ4 support:              ${have_lz4}
 
         Now type 'make' to build $PACKAGE
 
diff --git a/spice-common b/spice-common
index 1c97fea..5359304 160000
--- a/spice-common
+++ b/spice-common
@@ -1 +1 @@ 
-Subproject commit 1c97fea95616686f359451b3889d60ddd3ea0f3b
+Subproject commit 535930471320fb370c3027c158a1944a9729ce93

Comments

Hi Eduardo,

please postpone the patch after the spice-gtk release. Imo would be nice to have
a release not depending on unreleased spice-protocol - after that we can add
these fixes and Snir's work.

Pavel

On Thu, 2016-06-16 at 11:33 -0300, Eduardo Lima (Etrunko) wrote:
> Signed-off-by: Eduardo Lima (Etrunko) <etrunko@redhat.com>
> ---
>  configure.ac | 2 +-
>  spice-common | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 6e65188..0ca333f 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -640,7 +640,7 @@ AC_MSG_NOTICE([
>          USB redirection support:  ${have_usbredir} ${with_usbredir_hotplug}
>          DBus:                     ${have_dbus}
>          WebDAV support:           ${have_phodav}
> -        LZ4 support:              ${enable_lz4}
> +        LZ4 support:              ${have_lz4}
>  
>          Now type 'make' to build $PACKAGE
>  
> diff --git a/spice-common b/spice-common
> index 1c97fea..5359304 160000
> --- a/spice-common
> +++ b/spice-common
> @@ -1 +1 @@
> -Subproject commit 1c97fea95616686f359451b3889d60ddd3ea0f3b
> +Subproject commit 535930471320fb370c3027c158a1944a9729ce93
On Thu, Jun 16, 2016 at 04:39:32PM +0200, Pavel Grunt wrote:
> Hi Eduardo,
> 
> please postpone the patch after the spice-gtk release. Imo would be nice to have
> a release not depending on unreleased spice-protocol - after that we can add
> these fixes and Snir's work.

For what it's worth, nothing prevents us from making a spice-protocol
release at the same time as a spice-gtk release (do not read this as
"let's push this patch now", this is just a general comment).

Christophe
On 06/16/2016 11:39 AM, Pavel Grunt wrote:
> Hi Eduardo,
> 
> please postpone the patch after the spice-gtk release. Imo would be nice to have
> a release not depending on unreleased spice-protocol - after that we can add
> these fixes and Snir's work.
> 

Sure, I sent this one as an update as we already had the commit id from
spice-common.
On 06/16/2016 11:52 AM, Eduardo Lima (Etrunko) wrote:
> On 06/16/2016 11:39 AM, Pavel Grunt wrote:
>> Hi Eduardo,
>>
>> please postpone the patch after the spice-gtk release. Imo would be nice to have
>> a release not depending on unreleased spice-protocol - after that we can add
>> these fixes and Snir's work.
>>
> 
> Sure, I sent this one as an update as we already had the commit id from
> spice-common.
> 

I just noticed that spice-common has been updated for spice-gtk, so this
patch has been pushed.

Regards, Eduardo.