[weston,v2,5/5] gl-renderer: Accept non-NULL empty <visual_id> arrays

Submitted by Miguel Angel Vico on May 18, 2016, 3:48 p.m.

Details

Message ID 1463586527-28653-1-git-send-email-mvicomoya@nvidia.com
State Accepted
Delegated to: Pekka Paalanen
Headers show
Series "Series without cover letter" ( rev: 15 14 13 12 11 ) in Wayland (DEPRECATED)

Not browsing as part of any series.

Commit Message

Miguel Angel Vico May 18, 2016, 3:48 p.m.
This change modifies egl_choose_config() to accept a non-NULL but empty
<visual_id> array (i.e. n_ids == 0)

Signed-off-by: Miguel A Vico Moya <mvicomoya@nvidia.com>
Reviewed-by: Andy Ritger <aritger@nvidia.com>
Reviewed-by: James Jones <jajones@nvidia.com>
---
 src/gl-renderer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/src/gl-renderer.c b/src/gl-renderer.c
index 2e24271..3de14e2 100644
--- a/src/gl-renderer.c
+++ b/src/gl-renderer.c
@@ -2493,7 +2493,7 @@  egl_choose_config(struct gl_renderer *gr, const EGLint *attribs,
 		goto out;
 	}
 
-	if (!visual_id)
+	if (!visual_id || n_ids == 0)
 		config_index = 0;
 
 	for (i = 0; config_index == -1 && i < n_ids; i++)

Comments

On Wed, 18 May 2016 17:48:47 +0200
"Miguel A. Vico" <mvicomoya@nvidia.com> wrote:

> This change modifies egl_choose_config() to accept a non-NULL but empty
> <visual_id> array (i.e. n_ids == 0)
> 
> Signed-off-by: Miguel A Vico Moya <mvicomoya@nvidia.com>
> Reviewed-by: Andy Ritger <aritger@nvidia.com>
> Reviewed-by: James Jones <jajones@nvidia.com>
> ---
>  src/gl-renderer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/gl-renderer.c b/src/gl-renderer.c
> index 2e24271..3de14e2 100644
> --- a/src/gl-renderer.c
> +++ b/src/gl-renderer.c
> @@ -2493,7 +2493,7 @@ egl_choose_config(struct gl_renderer *gr, const EGLint *attribs,
>  		goto out;
>  	}
>  
> -	if (!visual_id)
> +	if (!visual_id || n_ids == 0)
>  		config_index = 0;
>  
>  	for (i = 0; config_index == -1 && i < n_ids; i++)

Hi

All 5 patches pushed:
   9c526e0..967b6bc  master -> master

I did a bit of rebasing and removed commit message notes about
EGLDevice/EGLOutput.


Thanks,
pq