[4/4] arb_vertex_attrib_64bit: add overlapping locations test

Submitted by Andres Gomez on May 17, 2016, 11:31 p.m.

Details

Message ID 1463527917-13321-5-git-send-email-agomez@igalia.com
State Accepted
Commit b7eb469f550df4c813e2486d87199c9be1e8cfed
Headers show
Series "Additional tests for ARB_vertex_attrib_64bit extension" ( rev: 2 1 ) in Piglit

Not browsing as part of any series.

Commit Message

Andres Gomez May 17, 2016, 11:31 p.m.
From: Antia Puentes <apuentes@igalia.com>

Verifies that aliasing can be used successfully for vertex attributes
with 64-bit floating-point components, being aliasing the act to bind
more than one attribute name to the same location.

Contributed by Andres Gomez.
---
 tests/all.py                                       |   3 +
 .../execution/CMakeLists.gl.txt                    |   1 +
 .../execution/overlapping-locations.c              | 226 +++++++++++++++++++++
 3 files changed, 230 insertions(+)
 create mode 100644 tests/spec/arb_vertex_attrib_64bit/execution/overlapping-locations.c

Patch hide | download patch | download mbox

diff --git a/tests/all.py b/tests/all.py
index aa88b1b..16b774f 100644
--- a/tests/all.py
+++ b/tests/all.py
@@ -4676,6 +4676,9 @@  with profile.group_manager(
     g(['arb_vertex_attrib_64bit-check-explicit-location'], 'check-explicit-location')
     g(['arb_vertex_attrib_64bit-getactiveattrib'], 'getactiveattrib')
     g(['arb_vertex_attrib_64bit-max-vertex-attrib'], 'max-vertex-attrib')
+    for test_type in ('shader', 'api'):
+        g(['arb_vertex_attrib_64bit-overlapping-locations', test_type],
+          run_concurrent=False)
 
 with profile.group_manager(
         PiglitGLTest,
diff --git a/tests/spec/arb_vertex_attrib_64bit/execution/CMakeLists.gl.txt b/tests/spec/arb_vertex_attrib_64bit/execution/CMakeLists.gl.txt
index 114ee3c..fecc769 100644
--- a/tests/spec/arb_vertex_attrib_64bit/execution/CMakeLists.gl.txt
+++ b/tests/spec/arb_vertex_attrib_64bit/execution/CMakeLists.gl.txt
@@ -12,3 +12,4 @@  piglit_add_executable (arb_vertex_attrib_64bit-double_attribs double_attribs.c)
 piglit_add_executable (arb_vertex_attrib_64bit-check-explicit-location check-explicit-location.c)
 piglit_add_executable (arb_vertex_attrib_64bit-getactiveattrib  getactiveattrib.c)
 piglit_add_executable (arb_vertex_attrib_64bit-max-vertex-attrib max-vertex-attrib.c)
+piglit_add_executable (arb_vertex_attrib_64bit-overlapping-locations overlapping-locations.c)
diff --git a/tests/spec/arb_vertex_attrib_64bit/execution/overlapping-locations.c b/tests/spec/arb_vertex_attrib_64bit/execution/overlapping-locations.c
new file mode 100644
index 0000000..13ee171
--- /dev/null
+++ b/tests/spec/arb_vertex_attrib_64bit/execution/overlapping-locations.c
@@ -0,0 +1,226 @@ 
+/*
+ * Copyright © 2016 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ */
+
+/** @file overlapping-locations.c
+ *
+ * From OpenGL 3.2 spec ("Compatibility profile"), page 89:
+ *
+ *     "It is possible for an application to bind more than one
+ *      attribute name to the same location. This is referred to as
+ *      aliasing. This will only work if only one of the aliased
+ *      attributes is active in the executable program, or if no path
+ *      through the shader consumes more than one attribute of a set
+ *      of attributes aliased to the same location. A link error can
+ *      occur if the linker determines that every path through the
+ *      shader consumes multiple aliased attributes, but
+ *      implementations are not required to generate an error in this
+ *      case."
+ *
+ * This test verifies that aliasing can be used successfully for vertex
+ * attributes with 64-bit floating-point components.
+ *
+ * Based on GL_ARB_explicit_attrib_location's
+ * overlapping-locations-input-attribs.c
+ */
+
+#include "piglit-util-gl.h"
+
+PIGLIT_GL_TEST_CONFIG_BEGIN
+	config.supports_gl_compat_version = 32;
+	config.supports_gl_core_version = 32;
+
+	config.window_width = 128;
+	config.window_height = 128;
+	config.window_visual = PIGLIT_GL_VISUAL_DOUBLE | PIGLIT_GL_VISUAL_RGBA;
+PIGLIT_GL_TEST_CONFIG_END
+
+static bool locations_in_shader;
+static unsigned prog, vao, vertex_buf;
+
+void
+compile_shader(void)
+{
+	GLuint element_buf;
+	unsigned int indices[6] = { 0, 1, 2, 0, 2, 3 };
+	double vertex_data[4][11] = {
+		/* vertex     color0:green    color1:blue     color2:yellow */
+		{-1.0, -1.0,  0.0, 1.0, 0.0,  0.0, 0.0, 1.0,  1.0, 1.0, 0.0},
+		{-1.0,  1.0,  0.0, 1.0, 0.0,  0.0, 0.0, 1.0,  1.0, 1.0, 0.0},
+		{ 1.0,  1.0,  0.0, 1.0, 0.0,  0.0, 0.0, 1.0,  1.0, 1.0, 0.0},
+		{ 1.0, -1.0,  0.0, 1.0, 0.0,  0.0, 0.0, 1.0,  1.0, 1.0, 0.0}};
+
+	static const char *vert_template =
+		"#version 150\n"
+		"%s\n"
+		"out vec4 color;\n"
+		"\n"
+		"uniform int x;\n"
+		"\n"
+		"void main()\n"
+		"{\n"
+		"	gl_Position = vec4(vertex, 0, 1);\n"
+		"	switch(x) {\n"
+		"	case 0:\n"
+		"		color = vec4(color0, 1.0);\n"
+		"		break;\n"
+		"	case 1:\n"
+		"		color = vec4(color1, 1.0);\n"
+		"		break;\n"
+		"	case 2:\n"
+		"		color = vec4(color2, 1.0);\n"
+		"		break;\n"
+		"	default:\n"
+		"		color = vec4(1.0);\n"
+		"	}\n"
+		"}\n";
+
+	static const char *frag =
+		"#version 130\n"
+		"\n"
+		"in vec4 color;\n"
+		"out vec4 out_color;\n"
+		"\n"
+		"void main()\n"
+		"{\n"
+		"	out_color = color;\n"
+		"}\n";
+
+	char *vert;
+	asprintf(&vert, vert_template, locations_in_shader ?
+		 "#extension GL_ARB_explicit_attrib_location : require\n"
+		 "#extension GL_ARB_gpu_shader_fp64 : require\n"
+		 "#extension GL_ARB_vertex_attrib_64bit : require\n"
+		 "\n"
+		 "layout (location = 0) in dvec2 vertex;\n"
+		 "layout (location = 1) in dvec3 color0;\n"
+		 "layout (location = 1) in dvec3 color1;\n"
+		 "layout (location = 1) in dvec3 color2;\n" :
+		 "#extension GL_ARB_gpu_shader_fp64 : require\n"
+		 "#extension GL_ARB_vertex_attrib_64bit : require\n"
+		 "\n"
+		 "in dvec2 vertex;\n"
+		 "in dvec3 color0;\n"
+		 "in dvec3 color1;\n"
+		 "in dvec3 color2;\n");
+
+	prog = piglit_build_simple_program_unlinked(vert, frag);
+	if (!locations_in_shader) {
+		glBindAttribLocation(prog, 0, "vertex");
+		glBindAttribLocation(prog, 1, "color0");
+		glBindAttribLocation(prog, 1, "color1");
+		glBindAttribLocation(prog, 1, "color2");
+	}
+	glLinkProgram(prog);
+
+	if (!piglit_link_check_status(prog))
+		piglit_report_result(PIGLIT_FAIL);
+
+	/* Set up vertex array object */
+	glGenVertexArrays(1, &vao);
+	glBindVertexArray(vao);
+
+	/* Set up vertex input buffer */
+	glGenBuffers(1, &vertex_buf);
+	glBindBuffer(GL_ARRAY_BUFFER, vertex_buf);
+	glBufferData(GL_ARRAY_BUFFER, sizeof(vertex_data), vertex_data,
+		     GL_STREAM_DRAW);
+
+	glEnableVertexAttribArray(0);
+	glVertexAttribLPointer(0, 2, GL_DOUBLE, 11*sizeof(double),
+			       (void *) 0);
+	glEnableVertexAttribArray(1);
+
+	/* Set up element input buffer to tessellate a quad into
+	 * triangles
+	 */
+	glGenBuffers(1, &element_buf);
+	glBindBuffer(GL_ELEMENT_ARRAY_BUFFER, element_buf);
+	glBufferData(GL_ELEMENT_ARRAY_BUFFER, sizeof(indices), indices,
+		     GL_STATIC_DRAW);
+}
+
+static void
+print_usage_and_exit(char *prog_name)
+{
+	printf("Usage: %s <set_location>\n"
+	       "  where <set_location> is one of:\n"
+	       "    shader: set locations of input variables in shader program\n"
+	       "    api: set locations of input variables using api\n",
+	       prog_name);
+
+	piglit_report_result(PIGLIT_FAIL);
+}
+
+void
+piglit_init(int argc, char **argv)
+{
+	if (argc != 2)
+		print_usage_and_exit(argv[0]);
+
+	/* 1st arg: location */
+	if(strcmp(argv[1], "shader") != 0 &&
+	   strcmp(argv[1], "api") != 0)
+		print_usage_and_exit(argv[0]);
+
+	locations_in_shader = strcmp(argv[1], "shader") == 0;
+
+	if (locations_in_shader)
+		piglit_require_extension("GL_ARB_explicit_attrib_location");
+
+	piglit_require_extension("GL_ARB_vertex_attrib_64bit");
+	piglit_require_extension("GL_ARB_gpu_shader_fp64");
+	piglit_require_GLSL_version(150);
+	compile_shader();
+	if (!piglit_check_gl_error(GL_NO_ERROR))
+		piglit_report_result(PIGLIT_FAIL);
+}
+
+enum piglit_result
+piglit_display()
+{
+	int i;
+	bool pass = true;
+	float expected[3][4] = {
+		{0.0, 1.0, 0.0, 1.0}, /* green */
+		{0.0, 0.0, 1.0, 1.0}, /* blue */
+		{1.0, 1.0, 0.0, 1.0}}; /* yellow */
+
+	glUseProgram(prog);
+
+	for(i = 0; i < 3; i++) {
+		glUniform1i(glGetUniformLocation(prog, "x"), i);
+
+		/* Setup VertexAttribPointer for location=1. There should be
+		 * only one active attribute pointer set to the shared location
+		 * '1' at a time.
+		 */
+		glVertexAttribLPointer(1, 3, GL_DOUBLE, 11 * sizeof(double),
+				       (void *) ((2 + 3*i) * sizeof(double)));
+
+		glDrawElements(GL_TRIANGLES, 6, GL_UNSIGNED_INT, (void *) 0);
+		pass = piglit_probe_rect_rgba(0, 0, piglit_width, piglit_height,
+					      expected[i]) && pass;
+		piglit_present_results();
+	}
+	return pass ? PIGLIT_PASS : PIGLIT_FAIL;
+}