| Message ID | 1325086654-11444-1-git-send-email-mgorny@gentoo.org |
|---|---|
| State | New |
| Headers | show |
diff --git a/xdm.service.in b/xdm.service.in index e782dd9..cf703c6 100644 --- a/xdm.service.in +++ b/xdm.service.in @@ -4,6 +4,7 @@ After=systemd-user-sessions.service [Service] ExecStart=BINDIR/xdm -nodaemon +ExecReload=/bin/kill -HUP $MAINPID Type=notify NotifyAccess=all
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 11-12-28 10:37 AM, Michał Górny wrote: > Signed-off-by: Michał Górny <mgorny@gentoo.org> > --- > xdm.service.in | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/xdm.service.in b/xdm.service.in > index e782dd9..cf703c6 100644 > --- a/xdm.service.in > +++ b/xdm.service.in > @@ -4,6 +4,7 @@ After=systemd-user-sessions.service > > [Service] > ExecStart=BINDIR/xdm -nodaemon > +ExecReload=/bin/kill -HUP $MAINPID /bin/kill works on all platforms? There are 50,000 hits on google about /usr/bin/kill. One of them for Oracle: http://docs.oracle.com/cd/E19082-01/819-2239/kill-1/index.html > > Type=notify > NotifyAccess=all > -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk7+CPsACgkQubv1WfueyfygAgCg1jObA1iBrKnGoA7X4Zx06WVF 3P0AmwQwcWkxWjL0mPsR9jby5uEzrytc =ai5p -----END PGP SIGNATURE-----
Hi, On 30 December 2011 18:54, Gaetan Nadon <memsize@videotron.ca> wrote: > /bin/kill works on all platforms? There are 50,000 hits on google about > /usr/bin/kill. > One of them for Oracle: No matter, systemd is (very) Linux-only. Cheers, Daniel
On Wed, Dec 28, 2011 at 16:37:34 +0100, Michał Górny wrote: > Signed-off-by: Michał Górny <mgorny@gentoo.org> > --- > xdm.service.in | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/xdm.service.in b/xdm.service.in > index e782dd9..cf703c6 100644 > --- a/xdm.service.in > +++ b/xdm.service.in > @@ -4,6 +4,7 @@ After=systemd-user-sessions.service > > [Service] > ExecStart=BINDIR/xdm -nodaemon > +ExecReload=/bin/kill -HUP $MAINPID > Type=notify > NotifyAccess=all > So systemd goes out of its way to not run shell scripts if possible, but it has no way to just use kill(2) to signal a daemon instead of fork+exec /bin/kill? Cheers, Julien
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 11-12-30 02:09 PM, Daniel Stone wrote: > Hi, > > On 30 December 2011 18:54, Gaetan Nadon <memsize@videotron.ca> wrote: >> /bin/kill works on all platforms? There are 50,000 hits on google about >> /usr/bin/kill. >> One of them for Oracle: > > No matter, systemd is (very) Linux-only. Thanks, I failed to look at the context. > > > Cheers, > Daniel > -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk7+Eu4ACgkQubv1Wfueyfw6bACgiRdmsBVBO8TAUFU5mR1EtNGN e6UAn3XTTiYBGsE/Lhjo3U+quRVqarnD =KhGv -----END PGP SIGNATURE-----
On Fri, 30 Dec 2011 19:09:26 +0000 Daniel Stone <daniel@fooishbar.org> wrote: > On 30 December 2011 18:54, Gaetan Nadon <memsize@videotron.ca> wrote: > > /bin/kill works on all platforms? There are 50,000 hits on google > > about /usr/bin/kill. > > One of them for Oracle: > > No matter, systemd is (very) Linux-only. On the other hand, Fedora is supposedly going to move all the executables into /usr any time soon. So that's quite a fair point I'm going to hand over to them. In the meantime, currently the officially supported way of doing this is through calling /bin/kill. Maybe it will become some kind of virtual alias at some point.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 11-12-30 02:52 PM, Michał Górny wrote: > On Fri, 30 Dec 2011 19:09:26 +0000 > Daniel Stone <daniel@fooishbar.org> wrote: > >> On 30 December 2011 18:54, Gaetan Nadon <memsize@videotron.ca> wrote: >>> /bin/kill works on all platforms? There are 50,000 hits on google >>> about /usr/bin/kill. >>> One of them for Oracle: >> >> No matter, systemd is (very) Linux-only. > > On the other hand, Fedora is supposedly going to move all > the executables into /usr any time soon. So that's quite a fair point > I'm going to hand over to them. I recall seeing RPM packages with /usr/bin/kill now that you mention it. > > > In the meantime, currently the officially supported way of doing this > is through calling /bin/kill. Maybe it will become some kind of virtual > alias at some point. Otherwise a lot of things will break. Keep an eye on it. If need be, we can add the usual config piece in configure.ac. > > -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk7+HQkACgkQubv1WfueyfyRzQCgo08AHrrpe9DGSFWBwP2IJdkI 9D0AoMIpkQC6vsIiLlW7kjN1hmfRU/NL =drEX -----END PGP SIGNATURE-----
On 12/30/11 10:54, Gaetan Nadon wrote: >> +ExecReload=/bin/kill -HUP $MAINPID > /bin/kill works on all platforms? There are 50,000 hits on google about > /usr/bin/kill. > One of them for Oracle: > > http://docs.oracle.com/cd/E19082-01/819-2239/kill-1/index.html /bin has been a symlink to /usr/bin on Solaris since Solaris 2.0 in 1992, so even though we deliver all the binaries as /usr/bin/sh, /usr/bin/rm, /usr/bin/kill, etc. the /bin paths work too. Though of course, Daniel's also right, the whole question is moot in the context of what systemd should run, since systemd is only found on a subset of Linux systems, not other platforms.
On Fri, 30 Dec 2011 15:20:25 -0500 Gaetan Nadon <memsize@videotron.ca> wrote: > > In the meantime, currently the officially supported way of doing > > this is through calling /bin/kill. Maybe it will become some kind > > of virtual alias at some point. > Otherwise a lot of things will break. Keep an eye on it. If need be, > we can add the usual config piece in configure.ac. Late ping about the patch. Is it likely to get in?
On 04/10/12 12:16 AM, Michał Górny wrote: > On Fri, 30 Dec 2011 15:20:25 -0500 > Gaetan Nadon <memsize@videotron.ca> wrote: > >>> In the meantime, currently the officially supported way of doing >>> this is through calling /bin/kill. Maybe it will become some kind >>> of virtual alias at some point. >> Otherwise a lot of things will break. Keep an eye on it. If need be, >> we can add the usual config piece in configure.ac. > > Late ping about the patch. Is it likely to get in? Unless I missed it in my e-mail, and patchwork [1] missed it as well, no one yet gave a Reviewed-by: tag for it, and since I work on a system explictly unsupported by systemd, I'm not going to be able to really do much with it myself, so rely on those who use systemd to care about it. I suspect the main problem is the very very very small overlap between those who want both an ultra-modern systemd-based distro and the ancient, unloved xdm display manager instead of something similarly modern such as gdm, kdm, lightdm, etc. [1] http://patchwork.freedesktop.org/patch/8508/
Signed-off-by: Michał Górny <mgorny@gentoo.org> --- xdm.service.in | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)