| Message ID | 1460910293-6888-1-git-send-email-emil.l.velikov@gmail.com |
|---|---|
| State | Accepted |
| Commit | 17e488570067cdf499c7ad17ab198508c6f1531d |
| Headers | show |
| Series |
"Series without cover letter"
( rev:
1
)
in
X.org (DEPRECATED - USE GITLAB) |
diff --git a/hw/xwayland/xwayland-glamor-xv.c b/hw/xwayland/xwayland-glamor-xv.c index 65f93c6..8e0f8da 100644 --- a/hw/xwayland/xwayland-glamor-xv.c +++ b/hw/xwayland/xwayland-glamor-xv.c @@ -213,7 +213,7 @@ xwl_glamor_xv_add_formats(XvAdaptorPtr pa) void *moreSpace; totFormat *= 2; - moreSpace = XNFreallocarray(pFormat, totFormat, + moreSpace = xnfreallocarray(pFormat, totFormat, sizeof(XvFormatRec)); pFormat = moreSpace; pf = pFormat + numFormat;
Humble ping ? On 17 April 2016 at 17:24, Emil Velikov <emil.l.velikov@gmail.com> wrote: > Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> > --- > hw/xwayland/xwayland-glamor-xv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/xwayland/xwayland-glamor-xv.c b/hw/xwayland/xwayland-glamor-xv.c > index 65f93c6..8e0f8da 100644 > --- a/hw/xwayland/xwayland-glamor-xv.c > +++ b/hw/xwayland/xwayland-glamor-xv.c > @@ -213,7 +213,7 @@ xwl_glamor_xv_add_formats(XvAdaptorPtr pa) > void *moreSpace; > > totFormat *= 2; > - moreSpace = XNFreallocarray(pFormat, totFormat, > + moreSpace = xnfreallocarray(pFormat, totFormat, > sizeof(XvFormatRec)); > pFormat = moreSpace; > pf = pFormat + numFormat; > -- > 2.8.0 >
Can anyone ack/nack this and patch 2/2 ? On 1 May 2016 at 18:33, Emil Velikov <emil.l.velikov@gmail.com> wrote: > Humble ping ? > > On 17 April 2016 at 17:24, Emil Velikov <emil.l.velikov@gmail.com> wrote: >> Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> >> --- >> hw/xwayland/xwayland-glamor-xv.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/hw/xwayland/xwayland-glamor-xv.c b/hw/xwayland/xwayland-glamor-xv.c >> index 65f93c6..8e0f8da 100644 >> --- a/hw/xwayland/xwayland-glamor-xv.c >> +++ b/hw/xwayland/xwayland-glamor-xv.c >> @@ -213,7 +213,7 @@ xwl_glamor_xv_add_formats(XvAdaptorPtr pa) >> void *moreSpace; >> >> totFormat *= 2; >> - moreSpace = XNFreallocarray(pFormat, totFormat, >> + moreSpace = xnfreallocarray(pFormat, totFormat, >> sizeof(XvFormatRec)); >> pFormat = moreSpace; >> pf = pFormat + numFormat; >> -- >> 2.8.0 >>
Hi Emil, On 29 May 2016 at 12:16, Emil Velikov <emil.l.velikov@gmail.com> wrote: > Can anyone ack/nack this and patch 2/2 ? While at it, could you please also add the XNFreallocarray() I added in the meantime in xwayland-glamor-xv.c to your patch for xwayland? Meanwhile for 1/2 and 2/2 in https://patchwork.freedesktop.org/series/5835/ Reviewed-by: Olivier Fourdan <ofourdan@redhat.com> Cheers, Olivier ----- Original Message ----- > Can anyone ack/nack this and patch 2/2 ? > > On 1 May 2016 at 18:33, Emil Velikov <emil.l.velikov@gmail.com> wrote: > > Humble ping ? > > > > On 17 April 2016 at 17:24, Emil Velikov <emil.l.velikov@gmail.com> wrote: > >> Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> > >> --- > >> hw/xwayland/xwayland-glamor-xv.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/hw/xwayland/xwayland-glamor-xv.c > >> b/hw/xwayland/xwayland-glamor-xv.c > >> index 65f93c6..8e0f8da 100644 > >> --- a/hw/xwayland/xwayland-glamor-xv.c > >> +++ b/hw/xwayland/xwayland-glamor-xv.c > >> @@ -213,7 +213,7 @@ xwl_glamor_xv_add_formats(XvAdaptorPtr pa) > >> void *moreSpace; > >> > >> totFormat *= 2; > >> - moreSpace = XNFreallocarray(pFormat, totFormat, > >> + moreSpace = xnfreallocarray(pFormat, totFormat, > >> sizeof(XvFormatRec)); > >> pFormat = moreSpace; > >> pf = pFormat + numFormat; > >> -- > >> 2.8.0 > >> > _______________________________________________ > xorg-devel@lists.x.org: X.Org development > Archives: http://lists.x.org/archives/xorg-devel > Info: https://lists.x.org/mailman/listinfo/xorg-devel
Hi Olivier, On 30 May 2016 at 08:50, Olivier Fourdan <ofourdan@redhat.com> wrote: > Hi Emil, > > On 29 May 2016 at 12:16, Emil Velikov <emil.l.velikov@gmail.com> wrote: >> Can anyone ack/nack this and patch 2/2 ? > > While at it, could you please also add the XNFreallocarray() I added in the meantime in xwayland-glamor-xv.c to your patch for xwayland? > I believe the patch addresses the exact case you've mentioned - for reference [1]. That or I've completely failed at git grep :-\ > Meanwhile for 1/2 and 2/2 in https://patchwork.freedesktop.org/series/5835/ > > Reviewed-by: Olivier Fourdan <ofourdan@redhat.com> > Thank you. Can anyone push this patch? -Emil [1] https://patchwork.freedesktop.org/patch/81538/
On Mon, Sep 04, 2017 at 03:47:18PM +0100, Emil Velikov wrote: > Hi Olivier, > > On 30 May 2016 at 08:50, Olivier Fourdan <ofourdan@redhat.com> wrote: > > Hi Emil, > > > > On 29 May 2016 at 12:16, Emil Velikov <emil.l.velikov@gmail.com> wrote: > >> Can anyone ack/nack this and patch 2/2 ? > > > > While at it, could you please also add the XNFreallocarray() I added in the meantime in xwayland-glamor-xv.c to your patch for xwayland? > > > I believe the patch addresses the exact case you've mentioned - for > reference [1]. That or I've completely failed at git grep :-\ > > > Meanwhile for 1/2 and 2/2 in https://patchwork.freedesktop.org/series/5835/ > > > > Reviewed-by: Olivier Fourdan <ofourdan@redhat.com> > > > Thank you. Can anyone push this patch? done remote: I: 2 patch(es) updated to state Accepted. To git+ssh://git.freedesktop.org/git/xorg/xserver cdd0352ba..ea82ececb master -> master Cheers, Peter > > -Emil > > [1] https://patchwork.freedesktop.org/patch/81538/ > _______________________________________________ > xorg-devel@lists.x.org: X.Org development > Archives: http://lists.x.org/archives/xorg-devel > Info: https://lists.x.org/mailman/listinfo/xorg-devel >
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> --- hw/xwayland/xwayland-glamor-xv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)