[09/10] drm/qxl: Don't set a gamma table size

Submitted by Daniel Vetter on March 30, 2016, 9:51 a.m.

Details

Message ID 1459331485-28376-10-git-send-email-daniel.vetter@ffwll.ch
State Accepted
Commit 0eef29d75034367350a123e7e41d3c95776ddfc2
Headers show
Series "legacy gamma code cleanup" ( rev: 1 ) in Intel GFX

Not browsing as part of any series.

Commit Message

Daniel Vetter March 30, 2016, 9:51 a.m. 
qxl doesn't have any functions for setting the gamma table, so this is
completely defunct.

Not nice to lie to userspace, so let's stop!

Cc: Dave Airlie <airlied@redhat.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 drivers/gpu/drm/qxl/qxl_display.c | 1 -
 1 file changed, 1 deletion(-)

Patch hide | download patch | download mbox 

diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c
index 030409a3ee4e..21c70952402d 100644
--- a/drivers/gpu/drm/qxl/qxl_display.c
+++ b/drivers/gpu/drm/qxl/qxl_display.c
@@ -729,7 +729,6 @@  static int qdev_crtc_init(struct drm_device *dev, int crtc_id)
 
 	drm_crtc_init(dev, &qxl_crtc->base, &qxl_crtc_funcs);
 	qxl_crtc->index = crtc_id;
-	drm_mode_crtc_set_gamma_size(&qxl_crtc->base, 256);
 	drm_crtc_helper_add(&qxl_crtc->base, &qxl_crtc_helper_funcs);
 	return 0;
 }

Comments

Maarten Lankhorst May 31, 2016, 1:17 p.m. 
Op 30-03-16 om 11:51 schreef Daniel Vetter:
> qxl doesn't have any functions for setting the gamma table, so this is
> completely defunct.
>
> Not nice to lie to userspace, so let's stop!
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Daniel Vetter May 31, 2016, 1:27 p.m. 
On Tue, May 31, 2016 at 03:17:57PM +0200, Maarten Lankhorst wrote:
> Op 30-03-16 om 11:51 schreef Daniel Vetter:
> > qxl doesn't have any functions for setting the gamma table, so this is
> > completely defunct.
> >
> > Not nice to lie to userspace, so let's stop!
> Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>

Applied the other patches you've reviewed, too. Thanks for the reviews.
-Daniel