[pulseaudio-discuss,2/6] log: Fix compilation error when HAVE_SYSLOG_H is undefined

Submitted by Ahmed S. Darwish on March 13, 2016, 9:57 p.m.

Details

Message ID 1457906277-18340-1-git-send-email-darwish.07@gmail.com
State New
Delegated to: Tanu Kaskinen
Headers show
Series "Bugfixes for PA 9.0" ( rev: 2 1 ) in PulseAudio

Not browsing as part of any series.

Commit Message

Ahmed S. Darwish March 13, 2016, 9:57 p.m.
Signed-off-by: Ahmed S. Darwish <darwish.07@gmail.com>
---
 src/pulsecore/log.c | 1 -
 1 file changed, 1 deletion(-)


Regards,

--
Darwish
http://darwish.chasingpointers.com

Patch hide | download patch | download mbox

diff --git a/src/pulsecore/log.c b/src/pulsecore/log.c
index b5db818..0c561e8 100644
--- a/src/pulsecore/log.c
+++ b/src/pulsecore/log.c
@@ -525,7 +525,6 @@  void pa_log_levelv_meta(
 
                     saved_errno = errno;
                     fprintf(stderr, "%s\n", "Error writing logs to the journal. Redirect log messages to console.");
-                    fprintf(stderr, "%s %s\n", metadata, t);
 #endif
                     pa_log_set_target(&new_target);
                 }

Comments

On Sun, 2016-03-13 at 23:57 +0200, Ahmed S. Darwish wrote:
> Signed-off-by: Ahmed S. Darwish <darwish.07@gmail.com>
> ---
>  src/pulsecore/log.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/pulsecore/log.c b/src/pulsecore/log.c
> index b5db818..0c561e8 100644
> --- a/src/pulsecore/log.c
> +++ b/src/pulsecore/log.c
> @@ -525,7 +525,6 @@ void pa_log_levelv_meta(
>  
>                      saved_errno = errno;
>                      fprintf(stderr, "%s\n", "Error writing logs to the journal. Redirect log messages to console.");
> -                    fprintf(stderr, "%s %s\n", metadata, t);
>  #endif
>                      pa_log_set_target(&new_target);
>                  }

The commit message is a bit short on information. What's the
compilation error? And why is it a good idea to drop the log message
altogether?

-- 
Tanu