[Spice-devel,01/10] Simplify spice_usb_device_equal_libdev()

Submitted by Dmitry Fleytman on Feb. 11, 2016, 3:59 p.m.

Details

Message ID 1455206394-13205-2-git-send-email-dmitry@daynix.com
State New
Headers show
Series "Add support for UsbDk backend" ( rev: 1 ) in Spice

Not browsing as part of any series.

Commit Message

Dmitry Fleytman Feb. 11, 2016, 3:59 p.m.
From: Christophe Fergeau <cfergeau@redhat.com>

The Windows-specific version duplicates some code from
spice_usb_device_manager_libdev_match(), this commit
switches to using that helper instead.
---
 src/usb-device-manager.c | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

Patch hide | download patch | download mbox

diff --git a/src/usb-device-manager.c b/src/usb-device-manager.c
index 647edd0..344b4bf 100644
--- a/src/usb-device-manager.c
+++ b/src/usb-device-manager.c
@@ -1907,19 +1907,14 @@  static gboolean
 spice_usb_device_equal_libdev(SpiceUsbDevice *device,
                               libusb_device  *libdev)
 {
-    int vid1, vid2, pid1, pid2;
+    int vid, pid;
 
     if ((device == NULL) || (libdev == NULL))
         return FALSE;
 
-    vid1 = spice_usb_device_get_vid(device);
-    pid1 = spice_usb_device_get_pid(device);
-
-    if (!spice_usb_device_manager_get_libdev_vid_pid(libdev, &vid2, &pid2)) {
-        return FALSE;
-    }
-
-    return ((vid1 == vid2) && (pid1 == pid2));
+    vid = spice_usb_device_get_vid(device);
+    pid = spice_usb_device_get_pid(device);
+    return spice_usb_device_manager_libdev_match(libdev, vid, pid);
 }
 #endif