[Spice-devel,spice-gtk,v2,07/17] log: nitpick at channel name in CHANNEL_DEBUG

Submitted by Victor Toso on Jan. 8, 2016, 8:51 a.m.

Details

Message ID 1452243107-20483-8-git-send-email-victortoso@redhat.com
State New
Headers show
Series "subdomain filtering with glib logging" ( rev: 2 ) in Spice

Not browsing as part of any series.

Commit Message

Victor Toso Jan. 8, 2016, 8:51 a.m.
After moving to spice_debug, all logs are always prefixed with file
name, function and line where CHANNEL_DEBUG was called.
The channel-name now does not stand out as much as it should because
name + colon is a common pattern. Enclosing the name between parentheses
does help
---
 src/spice-channel-priv.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/src/spice-channel-priv.h b/src/spice-channel-priv.h
index 76a160e..4d443d8 100644
--- a/src/spice-channel-priv.h
+++ b/src/spice-channel-priv.h
@@ -41,7 +41,7 @@  G_BEGIN_DECLS
 #define MAX_SPICE_DATA_HEADER_SIZE sizeof(SpiceDataHeader)
 
 #define CHANNEL_DEBUG(channel, fmt, ...) \
-    spice_debug("%s: " fmt, SPICE_CHANNEL(channel)->priv->name, ## __VA_ARGS__)
+    spice_debug("(%s) " fmt, SPICE_CHANNEL(channel)->priv->name, ## __VA_ARGS__)
 
 struct _SpiceMsgOut {
     int                   refcount;