[5/5] drm/i915: Use CSB helper in debugfs

Submitted by Ben Widawsky on Jan. 5, 2016, 6:30 p.m.

Details

Message ID 1452018609-10142-6-git-send-email-benjamin.widawsky@intel.com
State New
Headers show
Series "Some minor CSB/execlist stuff" ( rev: 1 ) in Intel GFX

Not browsing as part of any series.

Commit Message

Ben Widawsky Jan. 5, 2016, 6:30 p.m.
Since we extracted it for use in error state, we may as well use it in debugfs
too.

Signed-off-by: Ben Widawsky <benjamin.widawsky@intel.com>
---
 drivers/gpu/drm/i915/i915_debugfs.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index 3b05bd1..0b829fa 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -2099,8 +2099,7 @@  static int i915_execlists(struct seq_file *m, void *data)
 			   read_pointer, write_pointer);
 
 		for (i = 0; i < GEN8_CSB_ENTRIES; i++) {
-			status = I915_READ(RING_CONTEXT_STATUS_BUF_LO(ring, i));
-			ctx_id = I915_READ(RING_CONTEXT_STATUS_BUF_HI(ring, i));
+			intel_lrc_get_context_status(ring, i, &status, &ctx_id);
 
 			seq_printf(m, "\tStatus buffer %d: 0x%08X, context: %u\n",
 				   i, status, ctx_id);

Comments

On 1/5/2016 6:30 PM, Ben Widawsky wrote:
> Since we extracted it for use in error state, we may as well use it in debugfs
> too.
>
> Signed-off-by: Ben Widawsky <benjamin.widawsky@intel.com>

Reviewed-by: Michel Thierry <michel.thierry@intel.com>

(depends on patch 4/5, where I have a small request)

> ---
>   drivers/gpu/drm/i915/i915_debugfs.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 3b05bd1..0b829fa 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -2099,8 +2099,7 @@ static int i915_execlists(struct seq_file *m, void *data)
>                             read_pointer, write_pointer);
>
>                  for (i = 0; i < GEN8_CSB_ENTRIES; i++) {
> -                       status = I915_READ(RING_CONTEXT_STATUS_BUF_LO(ring, i));
> -                       ctx_id = I915_READ(RING_CONTEXT_STATUS_BUF_HI(ring, i));
> +                       intel_lrc_get_context_status(ring, i, &status, &ctx_id);
>
>                          seq_printf(m, "\tStatus buffer %d: 0x%08X, context: %u\n",
>                                     i, status, ctx_id);
> --
> 2.6.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>