[Spice-devel,client,3/3] build-sys: Warn about missing GStreamer 1.0 audio runtime elements

Submitted by Francois Gouget on Dec. 2, 2015, 1:56 p.m.

Details

Message ID alpine.DEB.2.20.1512021452560.9264@amboise
State New
Headers show
Series "Series without cover letter" ( rev: 1 ) in Spice

Not browsing as part of any series.

Commit Message

Francois Gouget Dec. 2, 2015, 1:56 p.m.
Their absence should not be reported as an error since they are not
needed for the build, but the developer will need them to test the code
so it's appropriate to warn him.

Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
---
 configure.ac | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/configure.ac b/configure.ac
index 86a895f..d290aaa 100644
--- a/configure.ac
+++ b/configure.ac
@@ -324,7 +324,11 @@  AC_ARG_ENABLE([gstaudio],
   [enable_gstaudio="auto"])
 AS_IF([test "x$enable_gstaudio" != "xno"],
       [SPICE_CHECK_GSTREAMER(GSTAUDIO, 1.0, [gstreamer-1.0 gstreamer-base-1.0 gstreamer-app-1.0 gstreamer-audio-1.0],
-         [],
+         [SPICE_CHECK_GSTREAMER_ELEMENTS($GST_INSPECT_1_0, [gst-plugins-base 1.0], [audioconvert audioresample appsink])
+          SPICE_CHECK_GSTREAMER_ELEMENTS($GST_INSPECT_1_0, [gst-plugins-good 1.0], [autoaudiosrc])
+          AS_IF([test x"$missing_gstreamer_elements" = "xyes"],
+                SPICE_WARNING([The GStreamer 1.0 audio backend can be built but may not work.]))
+         ],
          [AS_IF([test "x$enable_gstaudio" = "xyes"],
                 AC_MSG_ERROR([GStreamer 1.0 audio requested but not found]))
          ])

Comments

ACK.

On Wed, Dec 02, 2015 at 02:56:04PM +0100, Francois Gouget wrote:
> Their absence should not be reported as an error since they are not
> needed for the build, but the developer will need them to test the code
> so it's appropriate to warn him.
> 
> Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
> ---
>  configure.ac | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 86a895f..d290aaa 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -324,7 +324,11 @@ AC_ARG_ENABLE([gstaudio],
>    [enable_gstaudio="auto"])
>  AS_IF([test "x$enable_gstaudio" != "xno"],
>        [SPICE_CHECK_GSTREAMER(GSTAUDIO, 1.0, [gstreamer-1.0 gstreamer-base-1.0 gstreamer-app-1.0 gstreamer-audio-1.0],
> -         [],
> +         [SPICE_CHECK_GSTREAMER_ELEMENTS($GST_INSPECT_1_0, [gst-plugins-base 1.0], [audioconvert audioresample appsink])
> +          SPICE_CHECK_GSTREAMER_ELEMENTS($GST_INSPECT_1_0, [gst-plugins-good 1.0], [autoaudiosrc])
> +          AS_IF([test x"$missing_gstreamer_elements" = "xyes"],
> +                SPICE_WARNING([The GStreamer 1.0 audio backend can be built but may not work.]))
> +         ],
>           [AS_IF([test "x$enable_gstaudio" = "xyes"],
>                  AC_MSG_ERROR([GStreamer 1.0 audio requested but not found]))
>           ])
> -- 
> 2.6.2
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel