Recognise ISO_Level5-keysyms as modifiers in xcb_is_modifier_key #39177

Submitted by Andreas Wettstein on Aug. 7, 2011, 7:33 p.m.

Details

Message ID 87zkjll7u6.fsf@solnet.ch
State Deferred, archived
Headers show

Not browsing as part of any series.

Commit Message

Andreas Wettstein Aug. 7, 2011, 7:33 p.m. 
xcb_is_modifier_key did not regecognise ISO_Level5_Shift,
ISO_Level5_Latch, and ISO_Level5_Lock as modifiers.  See bug
39177, https://bugs.freedesktop.org/show_bug.cgi?id=39177

Signed-off-by: Andreas Wettstein <wettstein509@solnet.ch>
---
 keysyms/keysyms.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Patch hide | download patch | download mbox 

diff --git a/keysyms/keysyms.c b/keysyms/keysyms.c
index 3ea0e13..7584ccc 100644
--- a/keysyms/keysyms.c
+++ b/keysyms/keysyms.c
@@ -363,7 +363,7 @@  int
 xcb_is_modifier_key (xcb_keysym_t keysym)
 {
   return  (((keysym >= XK_Shift_L)  && (keysym <= XK_Hyper_R)) ||
-	   ((keysym >= XK_ISO_Lock) && (keysym <= XK_ISO_Last_Group_Lock)) ||
+	   ((keysym >= XK_ISO_Lock) && (keysym <= XK_ISO_Level5_Lock)) ||
 	   (keysym == XK_Mode_switch) ||
 	   (keysym == XK_Num_Lock));
 }

Comments

James Cloos Aug. 8, 2011, 3:16 a.m. 
>>>>> "AW" == Andreas Wettstein <wettstein509@solnet.ch> writes:

AW> xcb_is_modifier_key did not regecognise ISO_Level5_Shift,
AW> ISO_Level5_Latch, and ISO_Level5_Lock as modifiers.  See bug
AW> 39177, https://bugs.freedesktop.org/show_bug.cgi?id=39177

AW> Signed-off-by: Andreas Wettstein <wettstein509@solnet.ch>
AW> ---
AW>  keysyms/keysyms.c |    2 +-
AW>  1 files changed, 1 insertions(+), 1 deletions(-)

AW> diff --git a/keysyms/keysyms.c b/keysyms/keysyms.c
AW> index 3ea0e13..7584ccc 100644
AW> --- a/keysyms/keysyms.c
AW> +++ b/keysyms/keysyms.c
AW> @@ -363,7 +363,7 @@ int
AW>  xcb_is_modifier_key (xcb_keysym_t keysym)
AW>  {
AW>    return  (((keysym >= XK_Shift_L)  && (keysym <= XK_Hyper_R)) ||
AW> -	   ((keysym >= XK_ISO_Lock) && (keysym <= XK_ISO_Last_Group_Lock)) ||
AW> +	   ((keysym >= XK_ISO_Lock) && (keysym <= XK_ISO_Level5_Lock)) ||
AW>  	   (keysym == XK_Mode_switch) ||
AW>  	   (keysym == XK_Num_Lock));
AW>  }
AW> -- 
AW> 1.7.6

Reviewed-by: James Cloos <cloos@jhcloos.com>

-JimC
Daniel Stone Aug. 8, 2011, 4:04 p.m. 
On Sun, Aug 07, 2011 at 02:33:21PM +0200, Andreas Wettstein wrote:
> xcb_is_modifier_key did not regecognise ISO_Level5_Shift,
> ISO_Level5_Latch, and ISO_Level5_Lock as modifiers.  See bug
> 39177, https://bugs.freedesktop.org/show_bug.cgi?id=39177
> 
> Signed-off-by: Andreas Wettstein <wettstein509@solnet.ch>

Reviewed-by: Daniel Stone <daniel@fooishbar.org>

Cheers,
Daniel