drm/i915/skl: re-enable power well support

Submitted by Imre Deak on Nov. 18, 2015, 5:53 p.m.

Details

Message ID 1447869230-21416-1-git-send-email-imre.deak@intel.com
State Accepted
Commit a7de5506004415527035d7858b5993c906e2544e
Headers show
Series "drm/i915/skl: re-enable power well support" ( rev: 1 ) in Intel GFX

Not browsing as part of any series.

Commit Message

Imre Deak Nov. 18, 2015, 5:53 p.m.
Now that the known DMC/DC issues are fixed, let's try again and
re-enable the power well support.

Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 drivers/gpu/drm/i915/intel_runtime_pm.c | 5 -----
 1 file changed, 5 deletions(-)

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
index a1dc815..10154a7 100644
--- a/drivers/gpu/drm/i915/intel_runtime_pm.c
+++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
@@ -1841,11 +1841,6 @@  sanitize_disable_power_well_option(const struct drm_i915_private *dev_priv,
 	if (disable_power_well >= 0)
 		return !!disable_power_well;
 
-	if (IS_SKYLAKE(dev_priv)) {
-		DRM_DEBUG_KMS("Disabling display power well support\n");
-		return 0;
-	}
-
 	return 1;
 }
 

Comments

On Wed, Nov 18, 2015 at 07:53:50PM +0200, Imre Deak wrote:
> Now that the known DMC/DC issues are fixed, let's try again and
> re-enable the power well support.
> 
> Signed-off-by: Imre Deak <imre.deak@intel.com>

Together with the PC9/10 fix this is:

Reviewed-by: Patrik Jakobsson <patrik.jakobsson@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/intel_runtime_pm.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
> index a1dc815..10154a7 100644
> --- a/drivers/gpu/drm/i915/intel_runtime_pm.c
> +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
> @@ -1841,11 +1841,6 @@ sanitize_disable_power_well_option(const struct drm_i915_private *dev_priv,
>  	if (disable_power_well >= 0)
>  		return !!disable_power_well;
>  
> -	if (IS_SKYLAKE(dev_priv)) {
> -		DRM_DEBUG_KMS("Disabling display power well support\n");
> -		return 0;
> -	}
> -
>  	return 1;
>  }
>  
> -- 
> 2.5.0
>
On to, 2015-11-19 at 19:06 +0100, Patrik Jakobsson wrote:
> On Wed, Nov 18, 2015 at 07:53:50PM +0200, Imre Deak wrote:
> > Now that the known DMC/DC issues are fixed, let's try again and
> > re-enable the power well support.
> > 
> > Signed-off-by: Imre Deak <imre.deak@intel.com>
> 
> Together with the PC9/10 fix this is:
> 
> Reviewed-by: Patrik Jakobsson <patrik.jakobsson@linux.intel.com>

Pushed both patches to dinq, thanks for the review.

> > ---
> >  drivers/gpu/drm/i915/intel_runtime_pm.c | 5 -----
> >  1 file changed, 5 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c
> > b/drivers/gpu/drm/i915/intel_runtime_pm.c
> > index a1dc815..10154a7 100644
> > --- a/drivers/gpu/drm/i915/intel_runtime_pm.c
> > +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
> > @@ -1841,11 +1841,6 @@ sanitize_disable_power_well_option(const
> > struct drm_i915_private *dev_priv,
> >  	if (disable_power_well >= 0)
> >  		return !!disable_power_well;
> >  
> > -	if (IS_SKYLAKE(dev_priv)) {
> > -		DRM_DEBUG_KMS("Disabling display power well
> > support\n");
> > -		return 0;
> > -	}
> > -
> >  	return 1;
> >  }
> >