[Spice-devel] server: Remove the display_channel_attach_stream() prototype

Submitted by Francois Gouget on Nov. 13, 2015, 5:24 p.m.

Details

Message ID alpine.DEB.2.20.1511131822170.617@amboise
State New
Headers show
Series "server: Remove the display_channel_attach_stream() prototype" ( rev: 1 ) in Spice

Not browsing as part of any series.

Commit Message

Francois Gouget Nov. 13, 2015, 5:24 p.m.
It is unused.

Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
---
 server/display-channel.h | 3 ---
 1 file changed, 3 deletions(-)

It was added in this commit:

commit 4987df8e67f48cde13d39f4e81909f672ae33e29
Author: Marc-André Lureau <marcandre.lureau@gmail.com>
Date:   Tue Nov 10 13:21:28 2015 +0000

    worker: move stream to display channel
    
    Acked-by: Jonathon Jongsma <jjongsma@redhat.com>

So unless there was some ulterior motive it should not be there.

Patch hide | download patch | download mbox

diff --git a/server/display-channel.h b/server/display-channel.h
index c3dcc29..a9ae40a 100644
--- a/server/display-channel.h
+++ b/server/display-channel.h
@@ -358,9 +358,6 @@  typedef struct SurfaceCreateItem {
 
 void                       display_channel_set_stream_video          (DisplayChannel *display,
                                                                       int stream_video);
-void                       display_channel_attach_stream             (DisplayChannel *display,
-                                                                      Drawable *drawable,
-                                                                      Stream *stream);
 int                        display_channel_get_streams_timeout       (DisplayChannel *display);
 void                       display_channel_compress_stats_print      (const DisplayChannel *display);
 void                       display_channel_compress_stats_reset      (DisplayChannel *display);

Comments

> 
> It is unused.
> 

Yes, acked

Frediano


> Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
> ---
>  server/display-channel.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> It was added in this commit:
> 
> commit 4987df8e67f48cde13d39f4e81909f672ae33e29
> Author: Marc-André Lureau <marcandre.lureau@gmail.com>
> Date:   Tue Nov 10 13:21:28 2015 +0000
> 
>     worker: move stream to display channel
>     
>     Acked-by: Jonathon Jongsma <jjongsma@redhat.com>
> 
> So unless there was some ulterior motive it should not be there.
> 
> diff --git a/server/display-channel.h b/server/display-channel.h
> index c3dcc29..a9ae40a 100644
> --- a/server/display-channel.h
> +++ b/server/display-channel.h
> @@ -358,9 +358,6 @@ typedef struct SurfaceCreateItem {
>  
>  void                       display_channel_set_stream_video
>  (DisplayChannel *display,
>                                                                        int
>                                                                        stream_video);
> -void                       display_channel_attach_stream
> (DisplayChannel *display,
> -
> Drawable
> *drawable,
> -                                                                      Stream
> *stream);
>  int                        display_channel_get_streams_timeout
>  (DisplayChannel *display);
>  void                       display_channel_compress_stats_print      (const
>  DisplayChannel *display);
>  void                       display_channel_compress_stats_reset
>  (DisplayChannel *display);
> --
> 2.6.2
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>