[Spice-devel] build-sys: Use AC_MSG_NOTICE()

Submitted by Francois Gouget on Nov. 13, 2015, 3:10 p.m.

Details

Message ID alpine.DEB.2.20.1511131559250.3822@amboise
State New
Headers show
Series "build-sys: Use AC_MSG_NOTICE()" ( rev: 1 ) in Spice

Not browsing as part of any series.

Commit Message

Francois Gouget Nov. 13, 2015, 3:10 p.m.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
---
 configure.ac | 15 ++++-----------
 1 file changed, 4 insertions(+), 11 deletions(-)

I submitted this very simple patch twice before as part of patch series 
while noting it was independent of the rest of the series:
http://lists.freedesktop.org/archives/spice-devel/2015-October/022911.html
http://lists.freedesktop.org/archives/spice-devel/2015-November/023057.html

Asked if something was wrong with it there:
http://lists.freedesktop.org/archives/spice-devel/2015-November/023368.html

One of the series it was in sort of got acked there:
http://lists.freedesktop.org/archives/spice-devel/2015-November/023144.html

Let's see if it fares any better when presented all on its own.

Patch hide | download patch | download mbox

diff --git a/configure.ac b/configure.ac
index dfb967b..ad76467 100644
--- a/configure.ac
+++ b/configure.ac
@@ -289,7 +289,7 @@  docs/manual/Makefile
 ])
 
 dnl ==========================================================================
-echo "
+AC_MSG_NOTICE([
 
         Spice $VERSION
         ==============
@@ -300,23 +300,16 @@  echo "
         python:                   ${PYTHON}
 
         OpenGL:                   ${enable_opengl}
-
         LZ4 support:              ${enable_lz4}
-
         Smartcard:                ${have_smartcard}
-
         SASL support:             ${enable_sasl}
-
         Automated tests:          ${enable_automated_tests}
-
         Manual:                   ${have_asciidoc}
-"
+
+        Now type 'make' to build $PACKAGE
+])
 
 if test x"$arch_warn" != x; then
         AC_MSG_WARN([$arch_warn])
         echo ""
 fi
-
-echo \
-"        Now type 'make' to build $PACKAGE
-"

Comments

> 
> Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
> ---
>  configure.ac | 15 ++++-----------
>  1 file changed, 4 insertions(+), 11 deletions(-)
> 
> I submitted this very simple patch twice before as part of patch series
> while noting it was independent of the rest of the series:
> http://lists.freedesktop.org/archives/spice-devel/2015-October/022911.html
> http://lists.freedesktop.org/archives/spice-devel/2015-November/023057.html
> 
> Asked if something was wrong with it there:
> http://lists.freedesktop.org/archives/spice-devel/2015-November/023368.html
> 
> One of the series it was in sort of got acked there:
> http://lists.freedesktop.org/archives/spice-devel/2015-November/023144.html
> 
> Let's see if it fares any better when presented all on its own.
> 
> 

Acked

Frediano

> diff --git a/configure.ac b/configure.ac
> index dfb967b..ad76467 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -289,7 +289,7 @@ docs/manual/Makefile
>  ])
>  
>  dnl
>  ==========================================================================
> -echo "
> +AC_MSG_NOTICE([
>  
>          Spice $VERSION
>          ==============
> @@ -300,23 +300,16 @@ echo "
>          python:                   ${PYTHON}
>  
>          OpenGL:                   ${enable_opengl}
> -
>          LZ4 support:              ${enable_lz4}
> -
>          Smartcard:                ${have_smartcard}
> -
>          SASL support:             ${enable_sasl}
> -
>          Automated tests:          ${enable_automated_tests}
> -
>          Manual:                   ${have_asciidoc}
> -"
> +
> +        Now type 'make' to build $PACKAGE
> +])
>  
>  if test x"$arch_warn" != x; then
>          AC_MSG_WARN([$arch_warn])
>          echo ""
>  fi
> -
> -echo \
> -"        Now type 'make' to build $PACKAGE
> -"
> --
> 2.6.2
>