drm/i915: Log correct start and length in pte map trace

Submitted by Michel Thierry on Oct. 13, 2015, 10:24 a.m.

Details

Message ID 1444731879-3858-1-git-send-email-michel.thierry@intel.com
State New
Headers show

Not browsing as part of any series.

Commit Message

Michel Thierry Oct. 13, 2015, 10:24 a.m.
The PTE_map trace added in commit 4c06ec8d13d2 ("drm/i915/gen8: Add
dynamic page trace events") was using the full start and length values,
instead of the page directory ones.

Since this is just a trace, I don't think it requires cc'ing stable.

Cc: Akash Goel <akash.goel@intel.com>
Signed-off-by: Michel Thierry <michel.thierry@intel.com>
---
 drivers/gpu/drm/i915/i915_gem_gtt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
index e81990d..642fe87 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -1305,8 +1305,8 @@  static int gen8_alloc_va_range_3lvl(struct i915_address_space *vm,
 			page_directory[pde] = gen8_pde_encode(px_dma(pt),
 							      I915_CACHE_LLC);
 			trace_i915_page_table_entry_map(&ppgtt->base, pde, pt,
-							gen8_pte_index(start),
-							gen8_pte_count(start, length),
+							gen8_pte_index(pd_start),
+							gen8_pte_count(pd_start, pd_len),
 							GEN8_PTES);
 
 			/* NB: We haven't yet mapped ptes to pages. At this

Comments

On Tue, 13 Oct 2015, Michel Thierry <michel.thierry@intel.com> wrote:
> The PTE_map trace added in commit 4c06ec8d13d2 ("drm/i915/gen8: Add
> dynamic page trace events") was using the full start and length values,
> instead of the page directory ones.
>
> Since this is just a trace, I don't think it requires cc'ing stable.

Especially not since 4c06ec8d13d2 is not even in Linus' tree yet.

BR,
Jani.


>
> Cc: Akash Goel <akash.goel@intel.com>
> Signed-off-by: Michel Thierry <michel.thierry@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_gem_gtt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> index e81990d..642fe87 100644
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> @@ -1305,8 +1305,8 @@ static int gen8_alloc_va_range_3lvl(struct i915_address_space *vm,
>  			page_directory[pde] = gen8_pde_encode(px_dma(pt),
>  							      I915_CACHE_LLC);
>  			trace_i915_page_table_entry_map(&ppgtt->base, pde, pt,
> -							gen8_pte_index(start),
> -							gen8_pte_count(start, length),
> +							gen8_pte_index(pd_start),
> +							gen8_pte_count(pd_start, pd_len),
>  							GEN8_PTES);
>  
>  			/* NB: We haven't yet mapped ptes to pages. At this
> -- 
> 2.6.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx