[8/9] tests/all.py: add arb_robustness_draw-vbo-bounds

Submitted by Dylan Baker on Sept. 2, 2015, 7:51 p.m.

Details

Message ID 1441223484-8884-9-git-send-email-baker.dylan.c@gmail.com
State New, archived
Headers show

Not browsing as part of any series.

Commit Message

Dylan Baker Sept. 2, 2015, 7:51 p.m.
This was never added to all.py

cc: José Fonseca <jfonseca@vmware.com>
Signed-off-by: Dylan Baker <dylanx.c.baker@intel.com>
---

Does this actually need run_concurrent=False?

 tests/all.py | 1 +
 1 file changed, 1 insertion(+)

Patch hide | download patch | download mbox

diff --git a/tests/all.py b/tests/all.py
index 9c55dd7..ca72b65 100644
--- a/tests/all.py
+++ b/tests/all.py
@@ -2249,6 +2249,7 @@  with profile.group_manager(
         PiglitGLTest,
         grouptools.join('spec', 'ARB_robustness')) as g:
     g(['arb_robustness_client-mem-bounds'], run_concurrent=False)
+    g(['arb_robustness_draw-vbo-bounds'], run_concurrent=False)
 
 # Group ARB_shader_texture_lod
 with profile.group_manager(

Comments

On 02/09/15 20:51, Dylan Baker wrote:
> This was never added to all.py

Yes, that was because the test uses random numbers, hence might yield 
variable results (fail once, pass another).

Rather than all.py, it probably makes sense to move this sort of tests 
to a new stress.py test-list.

The other alternative is use reproduceable pseudo-random numbers, or a 
pre-generated set of data from a plaintext file.

Jose


>
> cc: José Fonseca <jfonseca@vmware.com>
> Signed-off-by: Dylan Baker <dylanx.c.baker@intel.com>
> ---
>
> Does this actually need run_concurrent=False?
>
>   tests/all.py | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/tests/all.py b/tests/all.py
> index 9c55dd7..ca72b65 100644
> --- a/tests/all.py
> +++ b/tests/all.py
> @@ -2249,6 +2249,7 @@ with profile.group_manager(
>           PiglitGLTest,
>           grouptools.join('spec', 'ARB_robustness')) as g:
>       g(['arb_robustness_client-mem-bounds'], run_concurrent=False)
> +    g(['arb_robustness_draw-vbo-bounds'], run_concurrent=False)
>
>   # Group ARB_shader_texture_lod
>   with profile.group_manager(
>
Ah, okay, that makes sense, I'll drop this patch

On Wed, Sep 02, 2015 at 09:27:16PM +0100, Jose Fonseca wrote:
> On 02/09/15 20:51, Dylan Baker wrote:
> > This was never added to all.py
> 
> Yes, that was because the test uses random numbers, hence might yield 
> variable results (fail once, pass another).
> 
> Rather than all.py, it probably makes sense to move this sort of tests 
> to a new stress.py test-list.
> 
> The other alternative is use reproduceable pseudo-random numbers, or a 
> pre-generated set of data from a plaintext file.
> 
> Jose
> 
> 
> >
> > cc: José Fonseca <jfonseca@vmware.com>
> > Signed-off-by: Dylan Baker <dylanx.c.baker@intel.com>
> > ---
> >
> > Does this actually need run_concurrent=False?
> >
> >   tests/all.py | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/all.py b/tests/all.py
> > index 9c55dd7..ca72b65 100644
> > --- a/tests/all.py
> > +++ b/tests/all.py
> > @@ -2249,6 +2249,7 @@ with profile.group_manager(
> >           PiglitGLTest,
> >           grouptools.join('spec', 'ARB_robustness')) as g:
> >       g(['arb_robustness_client-mem-bounds'], run_concurrent=False)
> > +    g(['arb_robustness_draw-vbo-bounds'], run_concurrent=False)
> >
> >   # Group ARB_shader_texture_lod
> >   with profile.group_manager(
> >
>
On 09/02/2015 01:27 PM, Jose Fonseca wrote:
> On 02/09/15 20:51, Dylan Baker wrote:
>> This was never added to all.py
> 
> Yes, that was because the test uses random numbers, hence might yield
> variable results (fail once, pass another).
> 
> Rather than all.py, it probably makes sense to move this sort of tests
> to a new stress.py test-list.
> 
> The other alternative is use reproduceable pseudo-random numbers, or a
> pre-generated set of data from a plaintext file.

There is such a random number generator in piglit, but it looks like
it's only available for C++ tests (tests/util/mersenne.hpp).  It should
be easy enough to make it available to C tests.

> Jose
> 
>> cc: José Fonseca <jfonseca@vmware.com>
>> Signed-off-by: Dylan Baker <dylanx.c.baker@intel.com>
>> ---
>>
>> Does this actually need run_concurrent=False?
>>
>>   tests/all.py | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/tests/all.py b/tests/all.py
>> index 9c55dd7..ca72b65 100644
>> --- a/tests/all.py
>> +++ b/tests/all.py
>> @@ -2249,6 +2249,7 @@ with profile.group_manager(
>>           PiglitGLTest,
>>           grouptools.join('spec', 'ARB_robustness')) as g:
>>       g(['arb_robustness_client-mem-bounds'], run_concurrent=False)
>> +    g(['arb_robustness_draw-vbo-bounds'], run_concurrent=False)
>>
>>   # Group ARB_shader_texture_lod
>>   with profile.group_manager(
> 
> _______________________________________________
> Piglit mailing list
> Piglit@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit