Is SendRequest missing some padding?

Submitted by Alessandro Arzilli on Aug. 31, 2015, 12:17 p.m.

Details

Message ID 55E445C5.8040301@gmail.com
State New
Headers show

Commit Message

Alessandro Arzilli Aug. 31, 2015, 12:17 p.m.
Patch attached.

Alessandro Arzilli.

On 08/15/2015 10:43 AM, Christian Linhart wrote:
> Hi Alessandro,
>
> You are welcome.
>
> Yes, the missing align-pads will be added because I have an upcoming patch that automatically checks
> for missing align-pads. Therefore, all missing align-pads will eventually get fixed.
>
> However, to be sure, you can post a patch to the xcb-mailinglist.
> (make sure that your patch applies cleanly with "git am".)
>
> Chris
>
>
> On 08/13/15 19:17, Alessandro Arzilli wrote:
>> Thanks! Are the <pad align="4"/> tags going to get added to SetupRequest as well?
>>
>> On 08/13/2015 06:24 PM, Christian Linhart wrote:
>>> Hi Alessandro,
>>>
>>> The patch for the problem which you have reported last September is now pushed to the official repo:
>>> http://cgit.freedesktop.org/xcb/libxcb/commit/?id=4033d39d4da21842bb1396a419dfc299591c3b1f
>>>
>>> Sorry for the long time between posting my patch and pushing it.
>>> (Back then I didn't have commit rights, yet. Later I forgot about that patch.)
>>>
>>> Thanks again for reporting that problem back then.
>>>
>>> Cheers,
>>>
>>> Chris
>>>
>>>
>>> On 09/19/14 10:45, Christian Linhart wrote:
>>>> Hi Alessandro,
>>>>
>>>> Thank you for checking that. Yes, you have checked out the correct branch.
>>>>
>>>> I'll look into this.
>>>> Maybe it's easy to fix.
>>>>
>>>> Chris
>>>>
>>>> On 09/19/14 08:57, Alessandro Arzilli wrote:
>>>>> On 09/18/2014 07:27 PM, chris@demorecorder.com wrote:
>>>>>> Hello Alessandro,
>>>>>>
>>>>>> I think we should fix the problem in the generator with <pad align="4" />.
>>>>>>
>>>>>> Can you please try if <pad align="4" /> works with my newest patches which are not yet merged into upstream?
>>>>>>
>>>>>> You can get them with
>>>>>> git clone http://infra-srv1.demorecorder.com/git/free-sw/xcb/libxcb/
>>>>>> git clone http://infra-srv1.demorecorder.com/git/free-sw/xcb/proto/
>>>>> I get the same error I got with libxcb-1.11.
>>>>>
>>>> [...]
>>>> _______________________________________________
>>>> Xcb mailing list
>>>> Xcb@lists.freedesktop.org
>>>> http://lists.freedesktop.org/mailman/listinfo/xcb
>>>>
>>>
>>
>

Patch hide | download patch | download mbox

From 7f110ce6005369639e1b114884262d5bedc02c5d Mon Sep 17 00:00:00 2001
From: aarzilli <alessandro.arzilli@gmail.com>
Date: Mon, 31 Aug 2015 14:11:13 +0200
Subject: [PATCH] Added missing alignment padding to SetupRequest struct.

---
 src/xproto.xml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/xproto.xml b/src/xproto.xml
index d50a428..41344e0 100644
--- a/src/xproto.xml
+++ b/src/xproto.xml
@@ -198,9 +198,11 @@  authorization from the authors.
     <list type="char" name="authorization_protocol_name">
       <fieldref>authorization_protocol_name_len</fieldref>
     </list>
+    <pad align="4" />
     <list type="char" name="authorization_protocol_data">
       <fieldref>authorization_protocol_data_len</fieldref>
     </list>
+    <pad align="4" />
   </struct>
 
   <struct name="SetupFailed">
-- 
1.9.1