[2/2] glx: Add IsEnabled request

Submitted by Robert Ancell on Aug. 27, 2015, 3:48 p.m.

Details

Message ID 1440690480-2841-1-git-send-email-robert.ancell@canonical.com
State New
Headers show

Commit Message

Robert Ancell Aug. 27, 2015, 3:48 p.m.
Signed-off-by: Robert Ancell <robert.ancell@canonical.com>
---
 src/glx.xml | 9 +++++++++
 1 file changed, 9 insertions(+)

Patch hide | download patch | download mbox

diff --git a/src/glx.xml b/src/glx.xml
index 2a36daa..e0870f4 100644
--- a/src/glx.xml
+++ b/src/glx.xml
@@ -1086,6 +1086,15 @@  The patch that fixed this server bug in X.org CVS is here:
 		</reply>
 	</request>
 
+	<request name="IsEnabled" opcode="140" >
+		<field type="CONTEXT_TAG" name="context_tag" />
+		<field type="CARD32" name="capability" />
+		<reply>
+			<pad bytes="1" />
+			<field type="BOOL32" name="ret_val" />
+		</reply>
+	</request>
+
 	<request name="IsList" opcode="141" >
 		<field type="CONTEXT_TAG" name="context_tag" />
 		<field type="CARD32" name="list" />

Comments

Robert Ancell Aug. 31, 2015, 6:10 a.m.
Hi Chris,

The XOrg server implements it in
http://cgit.freedesktop.org/xorg/xserver/tree/glx/indirect_dispatch.c#n2214.

--Robert

On Sun, Aug 30, 2015 at 1:31 PM Christian Linhart <chris@demorecorder.com>
wrote:

> Hi Robert,
>
> Can you please post a link to the spec of this request? (or to sourcecode
> in server or xlib which currently implements this request)
> I can confirm the opcode from
> http://cgit.freedesktop.org/xorg/proto/glproto/tree/glxproto.h
> but I cannot find the structure of this request anywhere (and I don't have
> time to do a longer research)
>
> Thank you,
>
> Chris
>
>
>
> On 08/27/15 17:48, Robert Ancell wrote:
> > Signed-off-by: Robert Ancell <robert.ancell@canonical.com>
> > ---
> >  src/glx.xml | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> >
> > diff --git a/src/glx.xml b/src/glx.xml
> > index 2a36daa..e0870f4 100644
> > --- a/src/glx.xml
> > +++ b/src/glx.xml
> > @@ -1086,6 +1086,15 @@ The patch that fixed this server bug in X.org CVS
> is here:
> >               </reply>
> >       </request>
> >
> > +     <request name="IsEnabled" opcode="140" >
> > +             <field type="CONTEXT_TAG" name="context_tag" />
> > +             <field type="CARD32" name="capability" />
> > +             <reply>
> > +                     <pad bytes="1" />
> > +                     <field type="BOOL32" name="ret_val" />
> > +             </reply>
> > +     </request>
> > +
> >       <request name="IsList" opcode="141" >
> >               <field type="CONTEXT_TAG" name="context_tag" />
> >               <field type="CARD32" name="list" />
>
>
Peter Harris Aug. 31, 2015, 2:29 p.m.
On 2015-08-30 08:30, Christian Linhart wrote:
> Hi Robert,
> 
> Can you please post a link to the spec of this request? (or to sourcecode in server or xlib which currently implements this request)

Server source code:
http://cgit.freedesktop.org/xorg/xserver/tree/glx/indirect_dispatch.c#n2215

Mesa's XML (which is a different format from XCB XML):
http://cgit.freedesktop.org/mesa/mesa/tree/src/mapi/glapi/gen/gl_API.xml#n2843

Both of these agree with the proposed patch. Therefore,

Reviewed-by: Peter Harris <pharris@opentext.com>

Peter Harris