[Mesa-dev,2/2] glxinfo: fix printing core profile extensions

Submitted by Marek Olšák on Aug. 3, 2015, 5:33 p.m.

Details

Message ID 1438623236-2290-3-git-send-email-maraeo@gmail.com
State New
Headers show

Not browsing as part of any series.

Commit Message

Marek Olšák Aug. 3, 2015, 5:33 p.m.
From: Marek Olšák <marek.olsak@amd.com>

Nobody supports GLX 3.x.

Broken by:

commit fca824431608101298ff0735db4c09954dcf64ab
Author: Julien Isorce <j.isorce@samsung.com>
Date:   Tue May 19 08:35:10 2015 +0100

    glxinfo: fix segfault when core profile is unavailable
---
 src/xdemos/glxinfo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/src/xdemos/glxinfo.c b/src/xdemos/glxinfo.c
index dc29bd9..f65451a 100644
--- a/src/xdemos/glxinfo.c
+++ b/src/xdemos/glxinfo.c
@@ -491,7 +491,7 @@  print_screen_info(Display *dpy, int scrnum,
       }
 
       /* Get list of GL extensions */
-      if (coreProfile && extfuncs.GetStringi && glxVersionMajor >= 3)
+      if (coreProfile && extfuncs.GetStringi)
          glExtensions = build_core_profile_extension_list(&extfuncs);
       if (!glExtensions) {
          coreProfile = False;

Comments

This patch is

Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>

On 08/03/2015 10:33 AM, Marek Olšák wrote:
> From: Marek Olšák <marek.olsak@amd.com>
> 
> Nobody supports GLX 3.x.
> 
> Broken by:
> 
> commit fca824431608101298ff0735db4c09954dcf64ab
> Author: Julien Isorce <j.isorce@samsung.com>
> Date:   Tue May 19 08:35:10 2015 +0100
> 
>     glxinfo: fix segfault when core profile is unavailable
> ---
>  src/xdemos/glxinfo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/xdemos/glxinfo.c b/src/xdemos/glxinfo.c
> index dc29bd9..f65451a 100644
> --- a/src/xdemos/glxinfo.c
> +++ b/src/xdemos/glxinfo.c
> @@ -491,7 +491,7 @@ print_screen_info(Display *dpy, int scrnum,
>        }
>  
>        /* Get list of GL extensions */
> -      if (coreProfile && extfuncs.GetStringi && glxVersionMajor >= 3)
> +      if (coreProfile && extfuncs.GetStringi)
>           glExtensions = build_core_profile_extension_list(&extfuncs);
>        if (!glExtensions) {
>           coreProfile = False;
>