drm: xlnx: add <linux/io.h> for readl/writel

Submitted by Randy Dunlap on July 6, 2022, 6:42 p.m.

Details

Message ID 20220706184224.29116-1-rdunlap@infradead.org
State New
Headers show
Series "drm: xlnx: add <linux/io.h> for readl/writel" ( rev: 1 ) in DRI devel

Not browsing as part of any series.

Commit Message

Randy Dunlap July 6, 2022, 6:42 p.m. 
Add a header file to prevent build errors:

../drivers/gpu/drm/xlnx/zynqmp_dp.c: In function ‘zynqmp_dp_write’:
../drivers/gpu/drm/xlnx/zynqmp_dp.c:335:9: error: implicit declaration of function ‘writel’ [-Werror=implicit-function-declaration]
  335 |         writel(val, dp->iomem + offset);
../drivers/gpu/drm/xlnx/zynqmp_dp.c: In function ‘zynqmp_dp_read’:
../drivers/gpu/drm/xlnx/zynqmp_dp.c:340:16: error: implicit declaration of function ‘readl’ [-Werror=implicit-function-declaration]
  340 |         return readl(dp->iomem + offset);

Fixes: d76271d22694 ("drm: xlnx: DRM/KMS driver for Xilinx ZynqMP DisplayPort Subsystem")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Hyun Kwon <hyun.kwon@xilinx.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Michal Simek <michal.simek@xilinx.com>
Cc: linux-arm-kernel@lists.infradead.org
---
 drivers/gpu/drm/xlnx/zynqmp_dp.c |    1 +
 1 file changed, 1 insertion(+)

Patch hide | download patch | download mbox 

--- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
@@ -25,6 +25,7 @@ 
 #include <linux/clk.h>
 #include <linux/delay.h>
 #include <linux/device.h>
+#include <linux/io.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
 #include <linux/pm_runtime.h>

Comments

Ville Syrjala July 6, 2022, 7:12 p.m. 
On Wed, Jul 06, 2022 at 11:42:24AM -0700, Randy Dunlap wrote:
> Add a header file to prevent build errors:
> 
> ../drivers/gpu/drm/xlnx/zynqmp_dp.c: In function ‘zynqmp_dp_write’:
> ../drivers/gpu/drm/xlnx/zynqmp_dp.c:335:9: error: implicit declaration of function ‘writel’ [-Werror=implicit-function-declaration]
>   335 |         writel(val, dp->iomem + offset);
> ../drivers/gpu/drm/xlnx/zynqmp_dp.c: In function ‘zynqmp_dp_read’:
> ../drivers/gpu/drm/xlnx/zynqmp_dp.c:340:16: error: implicit declaration of function ‘readl’ [-Werror=implicit-function-declaration]
>   340 |         return readl(dp->iomem + offset);
> 
> Fixes: d76271d22694 ("drm: xlnx: DRM/KMS driver for Xilinx ZynqMP DisplayPort Subsystem")

Should be
Fixes: a204f9743b68 ("drm: Remove linux/i2c.h from drm_crtc.h")
probably?

allmodconfig caught a few other drivers needing io.h but somehow
this one built for me without that header on both arm and x86.
Was this on some other architecture, or maybe there's some weird
config dependency that pulls in io.h for allmodconfig?

> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Hyun Kwon <hyun.kwon@xilinx.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: linux-arm-kernel@lists.infradead.org
> ---
>  drivers/gpu/drm/xlnx/zynqmp_dp.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> @@ -25,6 +25,7 @@
>  #include <linux/clk.h>
>  #include <linux/delay.h>
>  #include <linux/device.h>
> +#include <linux/io.h>
>  #include <linux/module.h>
>  #include <linux/platform_device.h>
>  #include <linux/pm_runtime.h>
Randy Dunlap July 6, 2022, 7:15 p.m. 
On 7/6/22 12:12, Ville Syrjälä wrote:
> On Wed, Jul 06, 2022 at 11:42:24AM -0700, Randy Dunlap wrote:
>> Add a header file to prevent build errors:
>>
>> ../drivers/gpu/drm/xlnx/zynqmp_dp.c: In function ‘zynqmp_dp_write’:
>> ../drivers/gpu/drm/xlnx/zynqmp_dp.c:335:9: error: implicit declaration of function ‘writel’ [-Werror=implicit-function-declaration]
>>   335 |         writel(val, dp->iomem + offset);
>> ../drivers/gpu/drm/xlnx/zynqmp_dp.c: In function ‘zynqmp_dp_read’:
>> ../drivers/gpu/drm/xlnx/zynqmp_dp.c:340:16: error: implicit declaration of function ‘readl’ [-Werror=implicit-function-declaration]
>>   340 |         return readl(dp->iomem + offset);
>>
>> Fixes: d76271d22694 ("drm: xlnx: DRM/KMS driver for Xilinx ZynqMP DisplayPort Subsystem")
> 
> Should be
> Fixes: a204f9743b68 ("drm: Remove linux/i2c.h from drm_crtc.h")
> probably?

Ack, thanks.

> 
> allmodconfig caught a few other drivers needing io.h but somehow
> this one built for me without that header on both arm and x86.
> Was this on some other architecture, or maybe there's some weird
> config dependency that pulls in io.h for allmodconfig?

x86_64 in linux-next 20220706. (some randconfig)

> 
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Hyun Kwon <hyun.kwon@xilinx.com>
>> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>> Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
>> Cc: David Airlie <airlied@linux.ie>
>> Cc: Daniel Vetter <daniel@ffwll.ch>
>> Cc: Michal Simek <michal.simek@xilinx.com>
>> Cc: linux-arm-kernel@lists.infradead.org
>> ---
>>  drivers/gpu/drm/xlnx/zynqmp_dp.c |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
>> +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
>> @@ -25,6 +25,7 @@
>>  #include <linux/clk.h>
>>  #include <linux/delay.h>
>>  #include <linux/device.h>
>> +#include <linux/io.h>
>>  #include <linux/module.h>
>>  #include <linux/platform_device.h>
>>  #include <linux/pm_runtime.h>
>
Ville Syrjala July 6, 2022, 7:59 p.m. 
On Wed, Jul 06, 2022 at 12:15:23PM -0700, Randy Dunlap wrote:
> 
> 
> On 7/6/22 12:12, Ville Syrjälä wrote:
> > On Wed, Jul 06, 2022 at 11:42:24AM -0700, Randy Dunlap wrote:
> >> Add a header file to prevent build errors:
> >>
> >> ../drivers/gpu/drm/xlnx/zynqmp_dp.c: In function ‘zynqmp_dp_write’:
> >> ../drivers/gpu/drm/xlnx/zynqmp_dp.c:335:9: error: implicit declaration of function ‘writel’ [-Werror=implicit-function-declaration]
> >>   335 |         writel(val, dp->iomem + offset);
> >> ../drivers/gpu/drm/xlnx/zynqmp_dp.c: In function ‘zynqmp_dp_read’:
> >> ../drivers/gpu/drm/xlnx/zynqmp_dp.c:340:16: error: implicit declaration of function ‘readl’ [-Werror=implicit-function-declaration]
> >>   340 |         return readl(dp->iomem + offset);
> >>
> >> Fixes: d76271d22694 ("drm: xlnx: DRM/KMS driver for Xilinx ZynqMP DisplayPort Subsystem")
> > 
> > Should be
> > Fixes: a204f9743b68 ("drm: Remove linux/i2c.h from drm_crtc.h")
> > probably?
> 
> Ack, thanks.
> 
> > 
> > allmodconfig caught a few other drivers needing io.h but somehow
> > this one built for me without that header on both arm and x86.
> > Was this on some other architecture, or maybe there's some weird
> > config dependency that pulls in io.h for allmodconfig?
> 
> x86_64 in linux-next 20220706. (some randconfig)

OK. Must be some oddball config option combo then.

Changed the Fixes tag and pushed to drm-misc-next. Thanks.

> 
> > 
> >> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> >> Cc: Hyun Kwon <hyun.kwon@xilinx.com>
> >> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >> Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
> >> Cc: David Airlie <airlied@linux.ie>
> >> Cc: Daniel Vetter <daniel@ffwll.ch>
> >> Cc: Michal Simek <michal.simek@xilinx.com>
> >> Cc: linux-arm-kernel@lists.infradead.org
> >> ---
> >>  drivers/gpu/drm/xlnx/zynqmp_dp.c |    1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
> >> +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> >> @@ -25,6 +25,7 @@
> >>  #include <linux/clk.h>
> >>  #include <linux/delay.h>
> >>  #include <linux/device.h>
> >> +#include <linux/io.h>
> >>  #include <linux/module.h>
> >>  #include <linux/platform_device.h>
> >>  #include <linux/pm_runtime.h>
> > 
> 
> -- 
> ~Randy