ivi-shell: set an initial value for ivi-surface.

Submitted by Nobuhiko Tanibata on April 27, 2015, 8:02 a.m.

Details

Message ID 1430121774-11731-1-git-send-email-nobuhiko_tanibata@xddp.denso.co.jp
State Accepted
Commit e259a7a7d243ba143ab53a56285c4cef2ba1ed68
Headers show

Not browsing as part of any series.

Commit Message

Nobuhiko Tanibata April 27, 2015, 8:02 a.m.
Especially, the size of destination rectagle is set to (1,1).
This is because the size will be used for caluculating scale and not to
be 0 to avoid 0 dividing.

I also remark this as FIXME. This shall be fixed at ivi-layout-tansition.c.
In new invoded application, its property is initilized by (0,0)
destination rectangle. So transition fucntion always calculates its scale
as inf at first frame of fade-in with new invoked application. To fix this,
restructing transition function is ideally needed.

Signed-off-by: Nobuhiko Tanibata <nobuhiko_tanibata@xddp.denso.co.jp>
Acked-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
---
 ivi-shell/ivi-layout.c | 5 +++++
 1 file changed, 5 insertions(+)

Patch hide | download patch | download mbox

diff --git a/ivi-shell/ivi-layout.c b/ivi-shell/ivi-layout.c
index 9c05713..3eed021 100644
--- a/ivi-shell/ivi-layout.c
+++ b/ivi-shell/ivi-layout.c
@@ -464,6 +464,11 @@  init_surface_properties(struct ivi_layout_surface_properties *prop)
 {
 	memset(prop, 0, sizeof *prop);
 	prop->opacity = wl_fixed_from_double(1.0);
+	/*
+	 * FIXME: this shall be finxed by ivi-layout-transition.
+	 */
+	prop->dest_width = 1;
+	prop->dest_height = 1;
 }
 
 /**

Comments

On Mon, 27 Apr 2015 17:02:54 +0900
Nobuhiko Tanibata <nobuhiko_tanibata@xddp.denso.co.jp> wrote:

> Especially, the size of destination rectagle is set to (1,1).
> This is because the size will be used for caluculating scale and not to
> be 0 to avoid 0 dividing.
> 
> I also remark this as FIXME. This shall be fixed at ivi-layout-tansition.c.
> In new invoded application, its property is initilized by (0,0)
> destination rectangle. So transition fucntion always calculates its scale
> as inf at first frame of fade-in with new invoked application. To fix this,
> restructing transition function is ideally needed.
> 
> Signed-off-by: Nobuhiko Tanibata <nobuhiko_tanibata@xddp.denso.co.jp>
> Acked-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
> ---
>  ivi-shell/ivi-layout.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/ivi-shell/ivi-layout.c b/ivi-shell/ivi-layout.c
> index 9c05713..3eed021 100644
> --- a/ivi-shell/ivi-layout.c
> +++ b/ivi-shell/ivi-layout.c
> @@ -464,6 +464,11 @@ init_surface_properties(struct ivi_layout_surface_properties *prop)
>  {
>  	memset(prop, 0, sizeof *prop);
>  	prop->opacity = wl_fixed_from_double(1.0);
> +	/*
> +	 * FIXME: this shall be finxed by ivi-layout-transition.
> +	 */
> +	prop->dest_width = 1;
> +	prop->dest_height = 1;
>  }
>  
>  /**

Hi,

all 5 patches pushed.
   c3fd624..e259a7a  master -> master


Thanks,
pq