[06/16] Fix memory leaks on _XimWriteCachedDefaultTree error paths.

Submitted by Ander Conselvan de Oliveira on March 30, 2011, 8:11 p.m.

Details

Message ID 1301490729-22084-7-git-send-email-ander.conselvan-de-oliveira@nokia.com
State Accepted, archived
Commit 0ace642a2d47265f01450bfa2b2fd48eb6956a83
Headers show

Not browsing as part of any series.

Commit Message

Ander Conselvan de Oliveira March 30, 2011, 8:11 p.m. 
Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>
---
 modules/im/ximcp/imLcIm.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

Patch hide | download patch | download mbox 

diff --git a/modules/im/ximcp/imLcIm.c b/modules/im/ximcp/imLcIm.c
index 83f216a..9041698 100644
--- a/modules/im/ximcp/imLcIm.c
+++ b/modules/im/ximcp/imLcIm.c
@@ -489,10 +489,13 @@  _XimWriteCachedDefaultTree(
 
     /* This STILL might be racy on NFS */
     if ( (fd = _XOpenFileMode (cachename, O_WRONLY | O_CREAT | O_EXCL,
-			       0600)) < 0)
+			       0600)) < 0) {
+       Xfree(m);
        return;
+    }
     if (! (fp = fdopen (fd, "wb")) ) {
        close (fd);
+       Xfree(m);
        return;
     }
     fwrite (m, msize, 1, fp);