[2/2] Documentation/drm: Update rotation property with 90/270 and description

Submitted by sonika.jindal@intel.com on April 15, 2015, 10:05 a.m.

Details

Message ID 1429092308-4739-2-git-send-email-sonika.jindal@intel.com
State New
Headers show

Not browsing as part of any series.

Commit Message

sonika.jindal@intel.com April 15, 2015, 10:05 a.m.
Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
---
 Documentation/DocBook/drm.tmpl |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Patch hide | download patch | download mbox

diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl
index f4976cd..266d50a 100644
--- a/Documentation/DocBook/drm.tmpl
+++ b/Documentation/DocBook/drm.tmpl
@@ -2853,9 +2853,12 @@  void intel_crt_init(struct drm_device *dev)
 	<td rowspan="1" valign="top" >Plane</td>
 	<td valign="top" >“rotation”</td>
 	<td valign="top" >BITMASK</td>
-	<td valign="top" >{ 0, "rotate-0" }, { 2, "rotate-180" }</td>
+	<td valign="top" >{ 0, "rotate-0" }, { 1, "rotate-90" },
+				{ 2, "rotate-180" }, { 3, "rotate-270" }</td>
 	<td valign="top" >Plane</td>
-	<td valign="top" >TBD</td>
+	<td valign="top" >To set plane HW rotation. This rotation property does
+		the plane rotation in counter clockwise direction which is
+		inline with the way XRandr works.</td>
 	</tr>
 	<tr>
 	<td rowspan="17" valign="top" >SDVO-TV</td>

Comments

On Wed, Apr 15, 2015 at 03:35:08PM +0530, Sonika Jindal wrote:
> Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
> ---
>  Documentation/DocBook/drm.tmpl |    7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl
> index f4976cd..266d50a 100644
> --- a/Documentation/DocBook/drm.tmpl
> +++ b/Documentation/DocBook/drm.tmpl
> @@ -2853,9 +2853,12 @@ void intel_crt_init(struct drm_device *dev)
>  	<td rowspan="1" valign="top" >Plane</td>
>  	<td valign="top" >“rotation”</td>
>  	<td valign="top" >BITMASK</td>
> -	<td valign="top" >{ 0, "rotate-0" }, { 2, "rotate-180" }</td>
> +	<td valign="top" >{ 0, "rotate-0" }, { 1, "rotate-90" },
> +				{ 2, "rotate-180" }, { 3, "rotate-270" }</td>
>  	<td valign="top" >Plane</td>
> -	<td valign="top" >TBD</td>
> +	<td valign="top" >To set plane HW rotation. This rotation property does
> +		the plane rotation in counter clockwise direction which is
> +		inline with the way XRandr works.</td>

Since this touches shared code can you please resend this patch with
dri-devel added to cc? BKM is to add a Cc: dri-devel ... line to the sob
section of the patch, then git send-email will automatically pick it up.
-Daniel

>  	</tr>
>  	<tr>
>  	<td rowspan="17" valign="top" >SDVO-TV</td>
> -- 
> 1.7.10.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
On 4/15/2015 3:57 PM, Daniel Vetter wrote:
> On Wed, Apr 15, 2015 at 03:35:08PM +0530, Sonika Jindal wrote:
>> Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
>> ---
>>   Documentation/DocBook/drm.tmpl |    7 +++++--
>>   1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl
>> index f4976cd..266d50a 100644
>> --- a/Documentation/DocBook/drm.tmpl
>> +++ b/Documentation/DocBook/drm.tmpl
>> @@ -2853,9 +2853,12 @@ void intel_crt_init(struct drm_device *dev)
>>   	<td rowspan="1" valign="top" >Plane</td>
>>   	<td valign="top" >“rotation”</td>
>>   	<td valign="top" >BITMASK</td>
>> -	<td valign="top" >{ 0, "rotate-0" }, { 2, "rotate-180" }</td>
>> +	<td valign="top" >{ 0, "rotate-0" }, { 1, "rotate-90" },
>> +				{ 2, "rotate-180" }, { 3, "rotate-270" }</td>
>>   	<td valign="top" >Plane</td>
>> -	<td valign="top" >TBD</td>
>> +	<td valign="top" >To set plane HW rotation. This rotation property does
>> +		the plane rotation in counter clockwise direction which is
>> +		inline with the way XRandr works.</td>
>
> Since this touches shared code can you please resend this patch with
> dri-devel added to cc? BKM is to add a Cc: dri-devel ... line to the sob
> section of the patch, then git send-email will automatically pick it up.
> -Daniel
>
But I am changing the description for only the rotation property for i915.
>>   	</tr>
>>   	<tr>
>>   	<td rowspan="17" valign="top" >SDVO-TV</td>
>> --
>> 1.7.10.4
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
On Wed, Apr 15, 2015 at 03:59:51PM +0530, Jindal, Sonika wrote:
> 
> 
> On 4/15/2015 3:57 PM, Daniel Vetter wrote:
> >On Wed, Apr 15, 2015 at 03:35:08PM +0530, Sonika Jindal wrote:
> >>Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
> >>---
> >>  Documentation/DocBook/drm.tmpl |    7 +++++--
> >>  1 file changed, 5 insertions(+), 2 deletions(-)
> >>
> >>diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl
> >>index f4976cd..266d50a 100644
> >>--- a/Documentation/DocBook/drm.tmpl
> >>+++ b/Documentation/DocBook/drm.tmpl
> >>@@ -2853,9 +2853,12 @@ void intel_crt_init(struct drm_device *dev)
> >>  	<td rowspan="1" valign="top" >Plane</td>
> >>  	<td valign="top" >“rotation”</td>
> >>  	<td valign="top" >BITMASK</td>
> >>-	<td valign="top" >{ 0, "rotate-0" }, { 2, "rotate-180" }</td>
> >>+	<td valign="top" >{ 0, "rotate-0" }, { 1, "rotate-90" },
> >>+				{ 2, "rotate-180" }, { 3, "rotate-270" }</td>
> >>  	<td valign="top" >Plane</td>
> >>-	<td valign="top" >TBD</td>
> >>+	<td valign="top" >To set plane HW rotation. This rotation property does
> >>+		the plane rotation in counter clockwise direction which is
> >>+		inline with the way XRandr works.</td>
> >
> >Since this touches shared code can you please resend this patch with
> >dri-devel added to cc? BKM is to add a Cc: dri-devel ... line to the sob
> >section of the patch, then git send-email will automatically pick it up.
> >-Daniel
> >
> But I am changing the description for only the rotation property for i915.

Property names are supposed to be somewhat standardized across all
drivers, and omapdrm already supports rotation. This is way we have this
shared table, so that other driver authors know what's going on. Please
resend.
-Daniel