[3/4] all.py: fix arb_geometry_shader4-program-parameter-vertices-out tests

Submitted by Dylan Baker on April 14, 2015, 8:52 p.m.

Details

Message ID 1429044766-11803-4-git-send-email-baker.dylan.c@gmail.com
State New, archived
Headers show

Not browsing as part of any series.

Commit Message

Dylan Baker April 14, 2015, 8:52 p.m.
These had a space in them.

Signed-off-by: Dylan Baker <dylanx.c.baker@intel.com>
---
 tests/all.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Patch hide | download patch | download mbox

diff --git a/tests/all.py b/tests/all.py
index a1d18d2..3612de8 100755
--- a/tests/all.py
+++ b/tests/all.py
@@ -4000,8 +4000,8 @@  with profile.group_manager(
                      'GL_TRIANGLES_ADJACENCY', 'GL_TRIANGLE_STRIP_ADJACENCY']:
             g(['arb_geometry_shader4-ignore-adjacent-vertices', draw, prim])
 
-    for mode in ['1', 'tf 1', 'max', 'tf max']:
-        g(['arb_geometry_shader4-program-parameter-vertices-out', mode])
+    for mode in [['1'], ['tf', '1'], ['max'], ['tf', 'max']]:
+        g(['arb_geometry_shader4-program-parameter-vertices-out'] + mode)
 
 with profile.group_manager(
         PiglitGLTest,

Comments

I checked the test, and it does indeed expect these as separate
arguments. However it's not illegal for an argument to have a space in
it (or a binary -- what happens when I stick my piglit checkout into
'/My Awesome Directory With Spaces/piglit').

Patches 1-3: Reviewed-by: Ilia Mirkin <imirkin@alum.mit.edu>
[haven't looked at 4 yet]

On Tue, Apr 14, 2015 at 4:52 PM, Dylan Baker <baker.dylan.c@gmail.com> wrote:
> These had a space in them.
>
> Signed-off-by: Dylan Baker <dylanx.c.baker@intel.com>
> ---
>  tests/all.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/all.py b/tests/all.py
> index a1d18d2..3612de8 100755
> --- a/tests/all.py
> +++ b/tests/all.py
> @@ -4000,8 +4000,8 @@ with profile.group_manager(
>                       'GL_TRIANGLES_ADJACENCY', 'GL_TRIANGLE_STRIP_ADJACENCY']:
>              g(['arb_geometry_shader4-ignore-adjacent-vertices', draw, prim])
>
> -    for mode in ['1', 'tf 1', 'max', 'tf max']:
> -        g(['arb_geometry_shader4-program-parameter-vertices-out', mode])
> +    for mode in [['1'], ['tf', '1'], ['max'], ['tf', 'max']]:
> +        g(['arb_geometry_shader4-program-parameter-vertices-out'] + mode)
>
>  with profile.group_manager(
>          PiglitGLTest,
> --
> 2.3.5
>
> _______________________________________________
> Piglit mailing list
> Piglit@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit