[Spice-devel] Running SPICE on PPC64

Submitted by Gerd Hoffmann on April 14, 2015, 6:49 a.m.

Details

Message ID 1428994155.3977.1.camel@nilsson.home.kraxel.org
State Accepted
Headers show

Not browsing as part of any series.

Commit Message

Gerd Hoffmann April 14, 2015, 6:49 a.m.
On Mo, 2015-04-13 at 16:43 +0300, Denis Kirjanov wrote:
> On 4/10/15, Christophe Fergeau <cfergeau@redhat.com> wrote:
> > On Fri, Apr 10, 2015 at 01:16:37PM +0300, Denis Kirjanov wrote:
> >> Are you going to apply the patch series, based on the work by Erlon R.
> >> Cruz?
> >>
> >> Since my patches based on that.
> >
> > Ah, I had forgotten about these and assumed they were pushed already ;)
> >
> > Christophe
> >
> 
> Thanks for applying this!
> 
> Now I'm debugging an issue with the "inverted colors" on client: looks
> like that the bitmaps get somehow inverted. Any hints would help :)

-vga std or -vga qxl?  For the former the fix probably is:

ssd->mirror,
                            rect->left, rect->top, 0, 0,


[ should apply and work fine for any qemu 2.3 release candidate ]

cheers,
  Gerd

Patch hide | download patch | download mbox

--- a/ui/spice-display.c
+++ b/ui/spice-display.c
@@ -178,7 +178,7 @@  static void
qemu_spice_create_one_update(SimpleSpiceDisplay *ssd,
     image->bitmap.palette = 0;
     image->bitmap.format = SPICE_BITMAP_FMT_32BIT;
 
-    dest = pixman_image_create_bits(PIXMAN_x8r8g8b8, bw, bh,
+    dest = pixman_image_create_bits(PIXMAN_LE_x8r8g8b8, bw, bh,
                                     (void *)update->bitmap, bw * 4);
     pixman_image_composite(PIXMAN_OP_SRC, ssd->surface, NULL,

Comments

On Di, 2015-04-14 at 08:49 +0200, Gerd Hoffmann wrote:
> On Mo, 2015-04-13 at 16:43 +0300, Denis Kirjanov wrote:
> > On 4/10/15, Christophe Fergeau <cfergeau@redhat.com> wrote:
> > > On Fri, Apr 10, 2015 at 01:16:37PM +0300, Denis Kirjanov wrote:
> > >> Are you going to apply the patch series, based on the work by Erlon R.
> > >> Cruz?
> > >>
> > >> Since my patches based on that.
> > >
> > > Ah, I had forgotten about these and assumed they were pushed already ;)
> > >
> > > Christophe
> > >
> > 
> > Thanks for applying this!
> > 
> > Now I'm debugging an issue with the "inverted colors" on client: looks
> > like that the bitmaps get somehow inverted. Any hints would help :)
> 
> -vga std or -vga qxl?  For the former the fix probably is:

Oh, and for qxl in vga mode (before loading qxl drivers) this should
help too.  

[ patch snipped ]

Patch is incomplete and doesn't build, corrected (and tested, at least
on little endian) version comes as separate mail.  Please test and
report back.

cheers,
  Gerd
On 4/14/15, Gerd Hoffmann <kraxel@redhat.com> wrote:
> On Di, 2015-04-14 at 08:49 +0200, Gerd Hoffmann wrote:
>> On Mo, 2015-04-13 at 16:43 +0300, Denis Kirjanov wrote:
>> > On 4/10/15, Christophe Fergeau <cfergeau@redhat.com> wrote:
>> > > On Fri, Apr 10, 2015 at 01:16:37PM +0300, Denis Kirjanov wrote:
>> > >> Are you going to apply the patch series, based on the work by Erlon
>> > >> R.
>> > >> Cruz?
>> > >>
>> > >> Since my patches based on that.
>> > >
>> > > Ah, I had forgotten about these and assumed they were pushed already
>> > > ;)
>> > >
>> > > Christophe
>> > >
>> >
>> > Thanks for applying this!
>> >
>> > Now I'm debugging an issue with the "inverted colors" on client: looks
>> > like that the bitmaps get somehow inverted. Any hints would help :)
>>
>> -vga std or -vga qxl?  For the former the fix probably is:
>
> Oh, and for qxl in vga mode (before loading qxl drivers) this should
> help too.
>
> [ patch snipped ]
>
> Patch is incomplete and doesn't build, corrected (and tested, at least
> on little endian) version comes as separate mail.  Please test and
> report back.
>
> cheers,
>   Gerd
>
>
>

Hey guys,

Looks like that the issue with the client crash is QUIC-related (when
the quic_encode is being called by the server) . I'm trying to
understand the reason for that. If someone has any hints that would be
great :)
On Tue, Apr 21, 2015 at 2:47 PM, Denis Kirjanov <kirjanov@gmail.com> wrote:
> On 4/14/15, Gerd Hoffmann <kraxel@redhat.com> wrote:
>> On Di, 2015-04-14 at 08:49 +0200, Gerd Hoffmann wrote:
>>> On Mo, 2015-04-13 at 16:43 +0300, Denis Kirjanov wrote:
>>> > On 4/10/15, Christophe Fergeau <cfergeau@redhat.com> wrote:
>>> > > On Fri, Apr 10, 2015 at 01:16:37PM +0300, Denis Kirjanov wrote:
>>> > >> Are you going to apply the patch series, based on the work by Erlon
>>> > >> R.
>>> > >> Cruz?
>>> > >>
>>> > >> Since my patches based on that.
>>> > >
>>> > > Ah, I had forgotten about these and assumed they were pushed already
>>> > > ;)
>>> > >
>>> > > Christophe
>>> > >
>>> >
>>> > Thanks for applying this!
>>> >
>>> > Now I'm debugging an issue with the "inverted colors" on client: looks
>>> > like that the bitmaps get somehow inverted. Any hints would help :)
>>>
>>> -vga std or -vga qxl?  For the former the fix probably is:
>>
>> Oh, and for qxl in vga mode (before loading qxl drivers) this should
>> help too.
>>
>> [ patch snipped ]
>>
>> Patch is incomplete and doesn't build, corrected (and tested, at least
>> on little endian) version comes as separate mail.  Please test and
>> report back.
>>
>> cheers,
>>   Gerd
>>
>>
>>
>
> Hey guys,
>
> Looks like that the issue with the client crash is QUIC-related (when
> the quic_encode is being called by the server) . I'm trying to
> understand the reason for that. If someone has any hints that would be
> great :)

I've been playing a bit with this and I have at least one small patch
for QUIC.Maybe it will help you. I'll clean up the things and submit
to the list (and come back here with a link to the patch).

>
> --
> Regards,
> Denis
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel


Best Regards,
On 5/15/15, Fabiano FidĂȘncio <fabiano@fidencio.org> wrote:
> On Tue, Apr 21, 2015 at 2:47 PM, Denis Kirjanov <kirjanov@gmail.com> wrote:
>> On 4/14/15, Gerd Hoffmann <kraxel@redhat.com> wrote:
>>> On Di, 2015-04-14 at 08:49 +0200, Gerd Hoffmann wrote:
>>>> On Mo, 2015-04-13 at 16:43 +0300, Denis Kirjanov wrote:
>>>> > On 4/10/15, Christophe Fergeau <cfergeau@redhat.com> wrote:
>>>> > > On Fri, Apr 10, 2015 at 01:16:37PM +0300, Denis Kirjanov wrote:
>>>> > >> Are you going to apply the patch series, based on the work by Erlon
>>>> > >> R.
>>>> > >> Cruz?
>>>> > >>
>>>> > >> Since my patches based on that.
>>>> > >
>>>> > > Ah, I had forgotten about these and assumed they were pushed already
>>>> > > ;)
>>>> > >
>>>> > > Christophe
>>>> > >
>>>> >
>>>> > Thanks for applying this!
>>>> >
>>>> > Now I'm debugging an issue with the "inverted colors" on client: looks
>>>> > like that the bitmaps get somehow inverted. Any hints would help :)
>>>>
>>>> -vga std or -vga qxl?  For the former the fix probably is:
>>>
>>> Oh, and for qxl in vga mode (before loading qxl drivers) this should
>>> help too.
>>>
>>> [ patch snipped ]
>>>
>>> Patch is incomplete and doesn't build, corrected (and tested, at least
>>> on little endian) version comes as separate mail.  Please test and
>>> report back.
>>>
>>> cheers,
>>>   Gerd
>>>
>>>
>>>
>>
>> Hey guys,
>>
>> Looks like that the issue with the client crash is QUIC-related (when
>> the quic_encode is being called by the server) . I'm trying to
>> understand the reason for that. If someone has any hints that would be
>> great :)
>
> I've been playing a bit with this and I have at least one small patch
> for QUIC.Maybe it will help you. I'll clean up the things and submit
> to the list (and come back here with a link to the patch).
>
That would be great.
Thanks!

>>
>> --
>> Regards,
>> Denis
>> _______________________________________________
>> Spice-devel mailing list
>> Spice-devel@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>
>
> Best Regards,
> --
> Fabiano FidĂȘncio
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>