[2/4] drm/i915/display/psr2: Mark as updated all planes that intersect with pipe_clip

Submitted by Souza, Jose on July 17, 2021, 1:12 a.m.

Details

Message ID 20210717011227.204494-2-jose.souza@intel.com
State Accepted
Commit 5cc92edb6ee8ac6f6d6d4fd8e7ecd00407a2489a
Headers show
Series "Series without cover letter" ( rev: 1 ) in Intel GFX

Not browsing as part of any series.

Commit Message

Souza, Jose July 17, 2021, 1:12 a.m.
Without this planes that were added by intel_psr2_sel_fetch_update()
that intersect with pipe damaged area will not
have skl_program_plane() and intel_psr2_program_plane_sel_fetch()
called, causing panel to not be properly updated.

Cc: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 drivers/gpu/drm/i915/display/intel_psr.c | 1 +
 1 file changed, 1 insertion(+)

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index d436490ab28c6..1c41042841fb1 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -1699,6 +1699,7 @@  int intel_psr2_sel_fetch_update(struct intel_atomic_state *state,
 		sel_fetch_area = &new_plane_state->psr2_sel_fetch_area;
 		sel_fetch_area->y1 = inter.y1 - new_plane_state->uapi.dst.y1;
 		sel_fetch_area->y2 = inter.y2 - new_plane_state->uapi.dst.y1;
+		crtc_state->update_planes |= BIT(plane->id);
 	}
 
 skip_sel_fetch_set_loop:

Comments

> -----Original Message-----

> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of José

> Roberto de Souza

> Sent: Friday, July 16, 2021 6:12 PM

> To: intel-gfx@lists.freedesktop.org

> Subject: [Intel-gfx] [PATCH 2/4] drm/i915/display/psr2: Mark as updated all

> planes that intersect with pipe_clip

> 

> Without this planes that were added by intel_psr2_sel_fetch_update() that

> intersect with pipe damaged area will not have skl_program_plane() and

> intel_psr2_program_plane_sel_fetch()

> called, causing panel to not be properly updated.

> 

> Cc: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>

> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>


Reviewed-by: Anusha Srivatsa <anusha.srivatsa@intel.com>


> ---

>  drivers/gpu/drm/i915/display/intel_psr.c | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c

> b/drivers/gpu/drm/i915/display/intel_psr.c

> index d436490ab28c6..1c41042841fb1 100644

> --- a/drivers/gpu/drm/i915/display/intel_psr.c

> +++ b/drivers/gpu/drm/i915/display/intel_psr.c

> @@ -1699,6 +1699,7 @@ int intel_psr2_sel_fetch_update(struct

> intel_atomic_state *state,

>  		sel_fetch_area = &new_plane_state->psr2_sel_fetch_area;

>  		sel_fetch_area->y1 = inter.y1 - new_plane_state-

> >uapi.dst.y1;

>  		sel_fetch_area->y2 = inter.y2 - new_plane_state-

> >uapi.dst.y1;

> +		crtc_state->update_planes |= BIT(plane->id);

>  	}

> 

>  skip_sel_fetch_set_loop:

> --

> 2.32.0

> 

> _______________________________________________

> Intel-gfx mailing list

> Intel-gfx@lists.freedesktop.org

> https://lists.freedesktop.org/mailman/listinfo/intel-gfx