[Mesa-dev] glext.h: Add missing include of stddef.h for ptrdiff_t

Submitted by Jeremy Huddleston on Feb. 11, 2015, 8:36 p.m.

Details

Message ID 9B1021CB-EBF1-43C1-93EC-595C96962F70@freedesktop.org
State New
Headers show

Not browsing as part of any series.

Commit Message

Jeremy Huddleston Feb. 11, 2015, 8:36 p.m.
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
---
 include/GL/glext.h | 1 +
 1 file changed, 1 insertion(+)

Patch hide | download patch | download mbox

diff --git a/include/GL/glext.h b/include/GL/glext.h
index 256ad35..0328cf6 100644
--- a/include/GL/glext.h
+++ b/include/GL/glext.h
@@ -4470,6 +4470,7 @@  GLAPI void APIENTRY glVertexBlendARB (GLint count);
 
 #ifndef GL_ARB_vertex_buffer_object
 #define GL_ARB_vertex_buffer_object 1
+#include <stddef.h>
 typedef ptrdiff_t GLsizeiptrARB;
 typedef ptrdiff_t GLintptrARB;
 #define GL_BUFFER_SIZE_ARB                0x8764

Comments

On Wed, Feb 11, 2015 at 12:36 PM, Jeremy Huddleston Sequoia
<jeremyhu@freedesktop.org> wrote:
>
> Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>

The file comes from Khronos. We can't update it.
Hi Jeremy,

On 11 February 2015 at 20:36, Jeremy Huddleston Sequoia
<jeremyhu@freedesktop.org> wrote:
>
> Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
> ---
>  include/GL/glext.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/include/GL/glext.h b/include/GL/glext.h
> index 256ad35..0328cf6 100644
> --- a/include/GL/glext.h
> +++ b/include/GL/glext.h
> @@ -4470,6 +4470,7 @@ GLAPI void APIENTRY glVertexBlendARB (GLint count);
>
>  #ifndef GL_ARB_vertex_buffer_object
>  #define GL_ARB_vertex_buffer_object 1
> +#include <stddef.h>
As Matt pointed out the headers are coming directly from Khronos and
we should not modify them. Did you had the change to report this issue
to them ?

-Emil
> On May 20, 2015, at 13:59, Emil Velikov <emil.l.velikov@gmail.com> wrote:
> 
> Hi Jeremy,
> 
> On 11 February 2015 at 20:36, Jeremy Huddleston Sequoia
> <jeremyhu@freedesktop.org> wrote:
>> 
>> Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
>> ---
>> include/GL/glext.h | 1 +
>> 1 file changed, 1 insertion(+)
>> 
>> diff --git a/include/GL/glext.h b/include/GL/glext.h
>> index 256ad35..0328cf6 100644
>> --- a/include/GL/glext.h
>> +++ b/include/GL/glext.h
>> @@ -4470,6 +4470,7 @@ GLAPI void APIENTRY glVertexBlendARB (GLint count);
>> 
>> #ifndef GL_ARB_vertex_buffer_object
>> #define GL_ARB_vertex_buffer_object 1
>> +#include <stddef.h>
> As Matt pointed out the headers are coming directly from Khronos and
> we should not modify them. Did you had the change to report this issue
> to them ?

I don't think I did.

I have now: https://www.khronos.org/bugzilla/show_bug.cgi?id=1345