[Mesa-dev,31/32] i965/vec4: Don't set any dependency control bits for F32TO16 on Gen8.

Submitted by Francisco Jerez on Feb. 6, 2015, 2:43 p.m.

Details

Message ID 1423233792-11767-31-git-send-email-currojerez@riseup.net
State New
Headers show

Not browsing as part of any series.

Commit Message

Francisco Jerez Feb. 6, 2015, 2:43 p.m.
It's expanded to several instructions.
---
 src/mesa/drivers/dri/i965/brw_vec4.cpp | 3 +++
 1 file changed, 3 insertions(+)

Patch hide | download patch | download mbox

diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp b/src/mesa/drivers/dri/i965/brw_vec4.cpp
index ed35c4b..85b9162f 100644
--- a/src/mesa/drivers/dri/i965/brw_vec4.cpp
+++ b/src/mesa/drivers/dri/i965/brw_vec4.cpp
@@ -865,6 +865,9 @@  vec4_visitor::is_dep_ctrl_unsafe(const vec4_instruction *inst)
          IS_DWORD(inst->src[0]) &&
          IS_DWORD(inst->src[1]))
          return true;
+
+      if (inst->opcode == BRW_OPCODE_F32TO16)
+         return true;
    }
 #undef IS_DWORD
 

Comments

On Fri, Feb 6, 2015 at 6:43 AM, Francisco Jerez <currojerez@riseup.net> wrote:
> It's expanded to several instructions.
> ---

I was going to say that I suspect this needs to go before some of the
previous patches to avoid assertions in debug builds, but even in
master we're emitting multiple instructions on Gen8. I guess I'd move
it before the other patches just because of that.

Reviewed-by: Matt Turner <mattst88@gmail.com>