ivi-shell: SEGV occurs when multi touch happens in transition

Submitted by Nobuhiko Tanibata on Feb. 6, 2015, 7:08 a.m.

Details

Message ID 1423206532-1546-1-git-send-email-NOBUHIKO_TANIBATA@xddp.denso.co.jp
State Accepted
Commit 82cc25b986669abf0a516eac0db936c5cd1e916b
Headers show

Not browsing as part of any series.

Commit Message

Nobuhiko Tanibata Feb. 6, 2015, 7:08 a.m.
of application launching. This is because cancel callback is mistakenly
set to weston_touch_grab_interface. To fix this issue, add a
callback, touch_move_workspace_grab_frame and set it to the
weston_touch_grab_interface like desktop-shell.

Signed-off-by: Nobuhiko Tanibata <NOBUHIKO_TANIBATA@xddp.denso.co.jp>
---
 ivi-shell/hmi-controller.c | 6 ++++++
 1 file changed, 6 insertions(+)

Patch hide | download patch | download mbox

diff --git a/ivi-shell/hmi-controller.c b/ivi-shell/hmi-controller.c
index 36a1b56..2d15e06 100644
--- a/ivi-shell/hmi-controller.c
+++ b/ivi-shell/hmi-controller.c
@@ -1389,6 +1389,11 @@  pointer_move_workspace_grab_cancel(struct weston_pointer_grab *grab)
 }
 
 static void
+touch_move_workspace_grab_frame(struct weston_touch_grab *grab)
+{
+}
+
+static void
 touch_move_workspace_grab_cancel(struct weston_touch_grab *grab)
 {
 	struct touch_grab *tg = (struct touch_grab *)grab;
@@ -1408,6 +1413,7 @@  static const struct weston_touch_grab_interface touch_move_grab_workspace_interf
 	touch_nope_grab_down,
 	touch_move_workspace_grab_up,
 	touch_move_grab_motion,
+	touch_move_workspace_grab_frame,
 	touch_move_workspace_grab_cancel
 };
 

Comments

On Friday, February 6, 2015, Nobuhiko Tanibata <
NOBUHIKO_TANIBATA@xddp.denso.co.jp> wrote:

> of application launching. This is because cancel callback is mistakenly
> set to weston_touch_grab_interface. To fix this issue, add a
> callback, touch_move_workspace_grab_frame and set it to the
> weston_touch_grab_interface like desktop-shell.
>
> Signed-off-by: Nobuhiko Tanibata <NOBUHIKO_TANIBATA@xddp.denso.co.jp
> <javascript:;>>


 Reviewed-by: Daniel Stone <daniels@collabora.com>
On Fri, Feb 06, 2015 at 08:34:32AM +0000, Daniel Stone wrote:
> On Friday, February 6, 2015, Nobuhiko Tanibata <
> NOBUHIKO_TANIBATA@xddp.denso.co.jp> wrote:
> 
> > of application launching. This is because cancel callback is mistakenly
> > set to weston_touch_grab_interface. To fix this issue, add a
> > callback, touch_move_workspace_grab_frame and set it to the
> > weston_touch_grab_interface like desktop-shell.
> >
> > Signed-off-by: Nobuhiko Tanibata <NOBUHIKO_TANIBATA@xddp.denso.co.jp
> > <javascript:;>>

Yes, you're right, the weston_touch_grab_interface has five function
pointers, for:  down, up, motion, frame, cancel.  The frame one was
missing.

(Hmm, seems like something ought to be checking for if a structure is
being initialized with fewer elements than it has members.  Maybe lint
or coverity would catch that.)

> 
>  Reviewed-by: Daniel Stone <daniels@collabora.com>

Reviewed-by: Bryce Harrington <bryce@osg.samsung.com>

Thanks, applied:

   7b9efcb..82cc25b  master -> master


> _______________________________________________
> wayland-devel mailing list
> wayland-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel