xfixes: cursor-name is after cursor-image in GetCursorImageAndName

Submitted by Peter Harris on Feb. 3, 2015, 11:31 p.m.

Details

Message ID 1423006298-5427-1-git-send-email-pharris@opentext.com
State New
Headers show

Commit Message

Peter Harris Feb. 3, 2015, 11:31 p.m.
The current version of fixesproto.txt has cursor-name before
cursor-image, but all known implementations put cursor-name after
cursor-image on the wire.

Signed-off-by: Peter Harris <pharris@opentext.com>
---
 src/xfixes.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/src/xfixes.xml b/src/xfixes.xml
index c5cba35..0a3d5ff 100644
--- a/src/xfixes.xml
+++ b/src/xfixes.xml
@@ -291,13 +291,13 @@  authorization from the authors.
       <field type="ATOM"   name="cursor_atom" altenum="Atom" />
       <field type="CARD16" name="nbytes" />
       <pad bytes="2" />
-      <list  type="char"   name="name"><fieldref>nbytes</fieldref></list>
       <list  type="CARD32" name="cursor_image">
         <op op="*">
           <fieldref>width</fieldref>
           <fieldref>height</fieldref>
         </op>
       </list>
+      <list  type="char"   name="name"><fieldref>nbytes</fieldref></list>
     </reply>
   </request>
 

Comments

Peter Harris Feb. 9, 2015, 3:46 p.m.
On 2015-02-08 04:02, Christian Linhart wrote:
> Hi Peter,
> 
> Thank you for finding and fixing that.
> I suggest that you post a patch for fixesproto.txt on xorg-devel,
> so that implementation and spec will be in sync.

http://lists.x.org/archives/xorg-devel/2015-February/045509.html

> I have looked at the implementation in libXFixes and Xserver
> and this confirms what you have found out.
> 
> Your patch looks good, therefore:
> 
> Reviewed-by: Christian Linhart <chris@demorecorder.com>

Thanks.

Peter Harris