[4/4] doc: Remove duplicated descriptions of wayland objects

Submitted by Bill Spitzak on Dec. 3, 2014, 2:29 a.m.

Details

Message ID 1417573776-4829-4-git-send-email-spitzak@gmail.com
State Accepted
Commit 9ca542db4efcc912a28ca88f27875cdf65429a66
Headers show

Not browsing as part of any series.

Commit Message

Bill Spitzak Dec. 3, 2014, 2:29 a.m.
This text is a duplicate of the text in the protocol documentation, but
the converter mangled it by removing the paragraph breaks and some other
errors. Instead replace it with a list of links to the protocol docs.
---
 doc/publican/protocol-interfaces-to-docbook.xsl |   16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)

Patch hide | download patch | download mbox

diff --git a/doc/publican/protocol-interfaces-to-docbook.xsl b/doc/publican/protocol-interfaces-to-docbook.xsl
index 9cf0695..fb1a816 100644
--- a/doc/publican/protocol-interfaces-to-docbook.xsl
+++ b/doc/publican/protocol-interfaces-to-docbook.xsl
@@ -34,21 +34,15 @@ 
 <!-- Interfaces summary -->
 <xsl:template match="interface" >
 <varlistentry>
-    <xsl:attribute name="id">protocol-summary-<xsl:value-of select="name()"/>-<xsl:value-of select="@name" />
-    </xsl:attribute>
-    <term>
+  <term>
+    <link linkend="protocol-spec-interface-{@name}">
       <xsl:value-of select="@name" />
       <xsl:if test="description/@summary">
         - <xsl:value-of select="description/@summary" />
       </xsl:if>
-    </term>
-    <listitem>
-    <para>
-      <xsl:value-of select="description"/>
-    </para>
-    </listitem>
-  </varlistentry>
-
+    </link>
+  </term>
+</varlistentry>
 </xsl:template>
 
 </xsl:stylesheet>

Comments

On Tue, Dec 02, 2014 at 06:29:36PM -0800, Bill Spitzak wrote:
> This text is a duplicate of the text in the protocol documentation, but
> the converter mangled it by removing the paragraph breaks and some other
> errors. Instead replace it with a list of links to the protocol docs.

Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>

Cheers,
   Peter


> ---
>  doc/publican/protocol-interfaces-to-docbook.xsl |   16 +++++-----------
>  1 file changed, 5 insertions(+), 11 deletions(-)
> 
> diff --git a/doc/publican/protocol-interfaces-to-docbook.xsl b/doc/publican/protocol-interfaces-to-docbook.xsl
> index 9cf0695..fb1a816 100644
> --- a/doc/publican/protocol-interfaces-to-docbook.xsl
> +++ b/doc/publican/protocol-interfaces-to-docbook.xsl
> @@ -34,21 +34,15 @@
>  <!-- Interfaces summary -->
>  <xsl:template match="interface" >
>  <varlistentry>
> -    <xsl:attribute name="id">protocol-summary-<xsl:value-of select="name()"/>-<xsl:value-of select="@name" />
> -    </xsl:attribute>
> -    <term>
> +  <term>
> +    <link linkend="protocol-spec-interface-{@name}">
>        <xsl:value-of select="@name" />
>        <xsl:if test="description/@summary">
>          - <xsl:value-of select="description/@summary" />
>        </xsl:if>
> -    </term>
> -    <listitem>
> -    <para>
> -      <xsl:value-of select="description"/>
> -    </para>
> -    </listitem>
> -  </varlistentry>
> -
> +    </link>
> +  </term>
> +</varlistentry>
>  </xsl:template>
>  
>  </xsl:stylesheet>
> -- 
> 1.7.9.5
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel
>
On Wed, 3 Dec 2014 13:51:44 +1000
Peter Hutterer <peter.hutterer@who-t.net> wrote:

> On Tue, Dec 02, 2014 at 06:29:36PM -0800, Bill Spitzak wrote:
> > This text is a duplicate of the text in the protocol documentation, but
> > the converter mangled it by removing the paragraph breaks and some other
> > errors. Instead replace it with a list of links to the protocol docs.
> 
> Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>

Hi,

patches 3 and 4 pushed. Patches 1 and 2 marked as rejected in Patchwork
as I understood they were NAK'd.


Thanks.
pq