[weston] compositor: Fix weston_subsurface_is_synchronized() return value.

Submitted by Carlos Olmedo Escobar on Nov. 4, 2014, 1:38 p.m.

Details

Message ID 1415108319-7257-1-git-send-email-carlos.olmedo.e@gmail.com
State Accepted
Commit 61a9bf5557b7924b710bd561b30f6b27401f9461
Headers show

Not browsing as part of any series.

Commit Message

Carlos Olmedo Escobar Nov. 4, 2014, 1:38 p.m.
Commit 280e7dd918f1717c7d677676384a9cd991097741 introduced a bug in the
return value of weston_subsurface_is_synchronized().

Signed-off-by: Carlos Olmedo Escobar <carlos.olmedo.e@gmail.com>
---
 src/compositor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/src/compositor.c b/src/compositor.c
index ac5bda2..ff62b5f 100644
--- a/src/compositor.c
+++ b/src/compositor.c
@@ -2639,7 +2639,7 @@  weston_subsurface_is_synchronized(struct weston_subsurface *sub)
 		sub = weston_surface_to_subsurface(sub->parent);
 	}
 
-	return true;
+	return false;
 }
 
 static void

Comments

On 04/11/14 07:38 AM, Carlos Olmedo Escobar wrote:
> Commit 280e7dd918f1717c7d677676384a9cd991097741 introduced a bug in the
> return value of weston_subsurface_is_synchronized().

Ouch! Nice catch. :(

Reviewed-by: Derek Foreman <derekf@osg.samsung.com>

> Signed-off-by: Carlos Olmedo Escobar <carlos.olmedo.e@gmail.com>
> ---
>  src/compositor.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/compositor.c b/src/compositor.c
> index ac5bda2..ff62b5f 100644
> --- a/src/compositor.c
> +++ b/src/compositor.c
> @@ -2639,7 +2639,7 @@ weston_subsurface_is_synchronized(struct weston_subsurface *sub)
>  		sub = weston_surface_to_subsurface(sub->parent);
>  	}
>  
> -	return true;
> +	return false;
>  }
>  
>  static void
>
On Tue, 04 Nov 2014 10:36:16 -0600
Derek Foreman <derekf@osg.samsung.com> wrote:

> On 04/11/14 07:38 AM, Carlos Olmedo Escobar wrote:
> > Commit 280e7dd918f1717c7d677676384a9cd991097741 introduced a bug in the
> > return value of weston_subsurface_is_synchronized().
> 
> Ouch! Nice catch. :(
> 
> Reviewed-by: Derek Foreman <derekf@osg.samsung.com>

Damn, how did I miss that... pushed!

Thanks,
pq


> 
> > Signed-off-by: Carlos Olmedo Escobar <carlos.olmedo.e@gmail.com>
> > ---
> >  src/compositor.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/src/compositor.c b/src/compositor.c
> > index ac5bda2..ff62b5f 100644
> > --- a/src/compositor.c
> > +++ b/src/compositor.c
> > @@ -2639,7 +2639,7 @@ weston_subsurface_is_synchronized(struct weston_subsurface *sub)
> >  		sub = weston_surface_to_subsurface(sub->parent);
> >  	}
> >  
> > -	return true;
> > +	return false;
> >  }
> >  
> >  static void
> > 
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel