framework: Listen to 'info'-level dmesg as well.

Submitted by Kenneth Graunke on Nov. 4, 2014, 12:09 a.m.

Details

Message ID 1415059740-32272-1-git-send-email-kenneth@whitecape.org
State New
Headers show

Not browsing as part of any series.

Commit Message

Kenneth Graunke Nov. 4, 2014, 12:09 a.m.
i915 started only reporting GPU hangs at the 'info' log level at one
point in an attempt to silence IGT fake GPU hangs.  I believe Daniel
fixed this in newer kernels, but some people haven't upgraded and are
still hitting this.

I'm not sure this is worth upstreaming in Piglit, but people were
interested in the patch.
---
 framework/dmesg.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Not tested at all.  I believe this is identical to a patch I wrote a month
ago, and used successfully, but I since threw it out.

Patch hide | download patch | download mbox

diff --git a/framework/dmesg.py b/framework/dmesg.py
index 1a8faa2..b3f42ef 100644
--- a/framework/dmesg.py
+++ b/framework/dmesg.py
@@ -152,7 +152,7 @@  class LinuxDmesg(BaseDmesg):
     calls. It requires timestamps to be enabled.
 
     """
-    DMESG_COMMAND = ['dmesg', '--level', 'emerg,alert,crit,err,warn,notice']
+    DMESG_COMMAND = ['dmesg', '--level', 'emerg,alert,crit,err,warn,notice,info']
 
     def __init__(self):
         """ Create a dmesg instance """

Comments

On Mon, Nov 03, 2014 at 04:09:00PM -0800, Kenneth Graunke wrote:
> i915 started only reporting GPU hangs at the 'info' log level at one
> point in an attempt to silence IGT fake GPU hangs.  I believe Daniel
> fixed this in newer kernels, but some people haven't upgraded and are
> still hitting this.
> 
> I'm not sure this is worth upstreaming in Piglit, but people were
> interested in the patch.

Yeah I think that's too much trouble for upstream, there's tons of stuff
we really shouldn't care about at info level. If this bug in i915 is
blocking people too badly we could shovel the patch through stable
backports if you want.
-Daniel

> ---
>  framework/dmesg.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Not tested at all.  I believe this is identical to a patch I wrote a month
> ago, and used successfully, but I since threw it out.
> 
> diff --git a/framework/dmesg.py b/framework/dmesg.py
> index 1a8faa2..b3f42ef 100644
> --- a/framework/dmesg.py
> +++ b/framework/dmesg.py
> @@ -152,7 +152,7 @@ class LinuxDmesg(BaseDmesg):
>      calls. It requires timestamps to be enabled.
>  
>      """
> -    DMESG_COMMAND = ['dmesg', '--level', 'emerg,alert,crit,err,warn,notice']
> +    DMESG_COMMAND = ['dmesg', '--level', 'emerg,alert,crit,err,warn,notice,info']
>  
>      def __init__(self):
>          """ Create a dmesg instance """
> -- 
> 2.1.2
> 
> _______________________________________________
> Piglit mailing list
> Piglit@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit