[spice-server,v2,1/7] smart-channel-client: Remove spicec client reference from comment

Submitted by Frediano Ziglio on Oct. 14, 2019, 9:22 a.m.

Details

Message ID 20191014092217.24405-2-fziglio@redhat.com
State New
Headers show
Series "Thread and Smartcard" ( rev: 1 ) in Spice

Not browsing as part of any series.

Commit Message

Frediano Ziglio Oct. 14, 2019, 9:22 a.m.
spicec is an obsolete client.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
---
 server/smartcard-channel-client.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Patch hide | download patch | download mbox

diff --git a/server/smartcard-channel-client.c b/server/smartcard-channel-client.c
index 43df902f5..da472a2a7 100644
--- a/server/smartcard-channel-client.c
+++ b/server/smartcard-channel-client.c
@@ -252,8 +252,7 @@  bool smartcard_channel_client_handle_message(RedChannelClient *rcc,
     SmartCardChannelClient *scc = SMARTCARD_CHANNEL_CLIENT(rcc);
 
     if (type != SPICE_MSGC_SMARTCARD_DATA) {
-        /* Handles seamless migration protocol. Also handles ack's,
-         * spicy sends them while spicec does not */
+        /* Handles seamless migration protocol. Also handles ack's */
         return red_channel_client_handle_message(rcc, type, size, message);
     }
 

Comments


----- Original Message -----
> From: "Victor Toso" <victortoso@redhat.com>
> To: "Frediano Ziglio" <fziglio@redhat.com>
> Cc: spice-devel@lists.freedesktop.org, cfergeau@redhat.com
> Sent: Monday, 21 October, 2019 9:01:13 AM
> Subject: Re: [Spice-devel] [PATCH spice-server v2 1/7] smart-channel-client: Remove spicec client reference from
> comment
> 
> Hi,
> 
> On Mon, Oct 14, 2019 at 10:22:11AM +0100, Frediano Ziglio wrote:
> > spicec is an obsolete client.
> 
> Should be fine to remove the other last referece (that my grep
> could find) in this commit too?
> 

The only other comment I can find is:

   /* XXX: This needs further investigation as to the underlying cause, it happened
     * after spicec disconnect (but not with spice-gtk) repeatedly. */

in this case maybe it's still valuable to keep although I had a quick look
and I can't understand if this comment still apply.

> server/red-channel-client.c:1187:     * after spicec disconnect
> (but not with spice-gtk) repeatedly. */
> 
> > Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
> 
> Acked-by: Victor Toso <victortoso@redhat.com>
> 
> > ---
> >  server/smartcard-channel-client.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/server/smartcard-channel-client.c
> > b/server/smartcard-channel-client.c
> > index 43df902f5..da472a2a7 100644
> > --- a/server/smartcard-channel-client.c
> > +++ b/server/smartcard-channel-client.c
> > @@ -252,8 +252,7 @@ bool
> > smartcard_channel_client_handle_message(RedChannelClient *rcc,
> >      SmartCardChannelClient *scc = SMARTCARD_CHANNEL_CLIENT(rcc);
> >  
> >      if (type != SPICE_MSGC_SMARTCARD_DATA) {
> > -        /* Handles seamless migration protocol. Also handles ack's,
> > -         * spicy sends them while spicec does not */
> > +        /* Handles seamless migration protocol. Also handles ack's */
> >          return red_channel_client_handle_message(rcc, type, size,
> >          message);
> >      }
> >  
> > --
> > 2.21.0
> > 
> > _______________________________________________
> > Spice-devel mailing list
> > Spice-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/spice-devel
>