[v3,10/17] panfrost: Kill the explicit serialization in panfrost_batch_submit()

Submitted by Boris Brezillon on Sept. 18, 2019, 1:24 p.m.

Details

Message ID 20190918132439.27705-11-boris.brezillon@collabora.com
State Accepted
Commit 70cf93c4d76c573e816c63d4809c0fcc538dbcd4
Headers show
Series "panfrost: Support batch pipelining" ( rev: 2 ) in Mesa

Not browsing as part of any series.

Commit Message

Boris Brezillon Sept. 18, 2019, 1:24 p.m.
Now that we have all the pieces in place to support pipelining batches
we can get rid of the drmSyncobjWait() at the end of
panfrost_batch_submit().

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
---
Changes in v3:
* Collect R-b
---
 src/gallium/drivers/panfrost/pan_job.c | 12 ------------
 1 file changed, 12 deletions(-)

Patch hide | download patch | download mbox

diff --git a/src/gallium/drivers/panfrost/pan_job.c b/src/gallium/drivers/panfrost/pan_job.c
index e7eae399830f..235cb21dc8c8 100644
--- a/src/gallium/drivers/panfrost/pan_job.c
+++ b/src/gallium/drivers/panfrost/pan_job.c
@@ -868,7 +868,6 @@  panfrost_batch_submit(struct panfrost_batch *batch)
                         panfrost_batch_submit((*dep)->batch);
         }
 
-        struct panfrost_context *ctx = batch->ctx;
         int ret;
 
         /* Nothing to do! */
@@ -892,18 +891,7 @@  panfrost_batch_submit(struct panfrost_batch *batch)
 
 out:
         panfrost_freeze_batch(batch);
-
-        /* We always stall the pipeline for correct results since pipelined
-         * rendering is quite broken right now (to be fixed by the panfrost_job
-         * refactor, just take the perf hit for correctness)
-         */
-        if (!batch->out_sync->signaled)
-                drmSyncobjWait(pan_screen(ctx->base.screen)->fd,
-                               &batch->out_sync->syncobj, 1, INT64_MAX, 0,
-                               NULL);
-
         panfrost_free_batch(batch);
-
 }
 
 void